Skip to content

Commit 81ba601

Browse files
bmosshaunagm
andcommitted
Documentation / Docstring Syntax Fixes (#1719)
* Fix missing string closure in write_tests.rst * Fix sphinx warning "title overline too short" * autoclass :: -> autoclass:: * Fix sphinx warning "title underline too short" * Fix sphinx autodoc AttributeError parsing utilities.dbt * Fix sphinx error "Error in "code-block" directive" * Fix sphinx critical error unexpected section title from improper use of markdown code blocks in reStructuredText * Fix sphinx error "Unexpected indentation" * Fix sphinx warning "Inline strong start-string without end-string" * Fix sphinx warning "Duplicate explicit target name" * add missing toc entries * remove trailing whitespace from all files * ensure all files have newline at end of file * convert tabs to spaces in remaining two files * fix improperly-formatted links in zoom documentation * remove unecessary parentheses in method reference * replace tab characters with spaces in getting_set_up.rst * `Args:` -> `Args`: -> Args: (and Returns) * fix no-blank-line-after-section * fix no-blank-line-before-section * fix missing-blank-line-after-last-section * fix overindented-section * install censusgeocode * fix note syntax * fix autoclass references * resolve attempted slackclient import * add mock import for pytz and airtable * fix MobilizeAmerica path * fix inherited-members indentation * don't use autodoc module/class name hinting * add :members: to all autoclasses * try to fix remaining autodoc import warnings * save docs-build artifact on circleci (for testing) * resolve SyntaxWarning for \* in tofrom.py * fix artifact upload path * improve docstring formatting of actblue.py * resolving more docstring syntax errors * Inline strong start-string without end-string. * Duplicate explicit target name * Unknown target name * ERROR: Unknown directive type "notes". * Block quote ends without a blank line * fix Unexpected indentation * Duplicate explicit target name * Enumerated list ends without a blank line * Title underline too short * autodoc: failed to import class 'dbtRunnerParsons * Error parsing content block for the "list-table" directive: two-level bullet list expected, but row 4 does not contain a second-level bullet list. * Definition list ends without a blank line * unexpected unindent. * Bullet list ends without a blank line * link formatting * fix Unknown target name: "user" * Inline strong start-string without end-string * fixing a lot of errors and warnings * fix malformed table * exclude sphinx output from git * Upgrade CircleCI config * more docstring formatting * improve return/yield docstring formatting * don't try to overwrite existing .venv in circleci --------- Co-authored-by: Shauna Gordon-McKeon <shaunagm@gmail.com>
2 parents eb5caaf + e0b65b3 commit 81ba601

File tree

252 files changed

+7287
-4638
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

252 files changed

+7287
-4638
lines changed

.circleci/config.yml

Lines changed: 13 additions & 50 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,15 @@
1-
# Python CircleCI 2.0 configuration file
2-
#
3-
# Check https://circleci.com/docs/2.0/language-python/ for more details
4-
#
5-
6-
version: 2
1+
version: 2.1
72

83
workflows:
94
version: 2
105
docs-build:
116
jobs:
127
- docs-build
138
- docs-build-deploy:
14-
filters:
15-
branches:
16-
only: main
9+
requires:
10+
- docs-build
1711

1812
jobs:
19-
20-
# Documentation CI
2113
docs-build:
2214
docker:
2315
- image: cimg/python:3.13
@@ -58,35 +50,21 @@ jobs:
5850
5951
docs-build-deploy:
6052
docker:
61-
- image: cimg/python:3.13-node
53+
- image: cimg/node:current
6254

6355
steps:
6456
- checkout
6557

66-
- restore_cache:
67-
keys:
68-
- v2-dependencies-python3.13-{{ checksum "pyproject.toml" }}-{{ checksum "setup.py" }}
69-
# fallback to using the latest cache if no exact match is found
70-
- v2-dependencies-python3.13-
58+
- attach_workspace:
59+
at: .
7160

7261
- run:
73-
name: Install parsons
74-
# Note that we the circleci node image installs stuff with a user "circleci", rather
75-
# than root. So we need to tell npm where to install stuff.
62+
name: Validate build artifacts
7663
command: |
77-
npm set prefix=/home/circleci/npm
78-
npm install -g --silent gh-pages@2.0.1
79-
80-
uv sync \
81-
--upgrade \
82-
--no-default-groups \
83-
--group docs \
84-
--all-extras
85-
86-
- save_cache:
87-
paths:
88-
- ./venv
89-
key: v2-dependencies-python3.13-{{ checksum "pyproject.toml" }}-{{ checksum "setup.py" }}
64+
if [ ! -f docs/html/index.html ]; then
65+
echo "Error: docs/html/index.html not found! Build might have failed."
66+
exit 1
67+
fi
9068
9169
- add_ssh_keys:
9270
# This SSH key is "CircleCI Docs" in https://github.com/move-coop/parsons/settings/keys
@@ -95,24 +73,9 @@ jobs:
9573
- '9a:ec:4d:2b:c3:45:b2:f5:55:ca:0b:2b:36:e2:7f:df'
9674

9775
- run:
98-
name: Build and deploy docs
99-
# When running gh-pages, we specify to include dotfiles, so we pick up the .nojerkyll file.
100-
# (This file tell Github Pages that we want to include all files in docs/, including those
101-
# that start with an underscore like _static/).
76+
name: Deploy docs
10277
command: |
103-
uv sync \
104-
--no-default-groups \
105-
--group docs \
106-
--all-extras
107-
108-
cd docs/
109-
uv venv make deploy_docs
110-
111-
cd ..
112-
11378
git config user.email "ci-build@movementcooperative.org"
11479
git config user.name "ci-build"
11580
116-
export PATH=/home/circleci/npm/bin:$PATH
117-
118-
gh-pages --dotfiles --message "[skip ci] Updates" --dist docs
81+
npx gh-pages@2.0.1 --dist docs/html --message "[skip ci] Updates" --dotfiles

.github/ISSUE_TEMPLATE/bug-report.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,4 +29,4 @@ Add any other context about the problem here.
2929

3030

3131
## Priority
32-
Please indicate whether fixing this bug is high, medium, or low priority for you. If the issue is time-sensitive for you, please let us know when you need it addressed by.
32+
Please indicate whether fixing this bug is high, medium, or low priority for you. If the issue is time-sensitive for you, please let us know when you need it addressed by.

.github/ISSUE_TEMPLATE/proposed-feature-addition.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,4 +23,4 @@ assignees: ''
2323

2424

2525
## Priority
26-
<!--- Please indicate whether adding this feature is high, medium, or low priority for you. If the issue is time-sensitive for you, please let us know when you want it addressed by. -->
26+
<!--- Please indicate whether adding this feature is high, medium, or low priority for you. If the issue is time-sensitive for you, please let us know when you want it addressed by. -->

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,12 @@
11
## What is this change?
22
- (List out the changes.)
3-
- (Link to any relevant Github issues or Slack discussion)
3+
- (Link to any relevant Github issues or Slack discussion.)
4+
5+
## Breaking changes (if needed)
6+
- (List out any changes to the API that may cause breaks for developer implementation.)
47

58
## Considerations for discussion
69
- (List out any significant design decisions that were made and why.)
710

811
## How to test the changes (if needed)
9-
- (How should a reviewer test this functionality)
12+
- (How should a reviewer test this functionality.)

.github/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,4 +19,4 @@ changelog:
1919
# -🎉-first-PR
2020
- title: Other Changes
2121
labels:
22-
- "*"
22+
- "*"

.github/workflows/dependency-review.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,4 +23,4 @@ jobs:
2323
2424
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd
2525

26-
- uses: actions/dependency-review-action@3c4e3dcb1aa7874d2c16be7d79418e9b7efd6261
26+
- uses: actions/dependency-review-action@05fe4576374b728f0c523d6a13d64c25081e0803

.github/workflows/python-checks.yml

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ jobs:
5050
python-version: ${{ matrix.python-version }}
5151
cache: pip
5252

53-
- uses: install-pinned/uv@c57eeccb84c14c060f224d6b4dcef7b645f05277
53+
- uses: install-pinned/uv@05d9162df91b0a72301801afd144d0b8b525e0b3
5454

5555
- if: matrix.resolution != 'limited-dependencies'
5656
continue-on-error: ${{ contains(matrix.python-version, '3.14') }}
@@ -114,7 +114,7 @@ jobs:
114114
python-version: '3.13'
115115
cache: pip
116116

117-
- uses: install-pinned/uv@c57eeccb84c14c060f224d6b4dcef7b645f05277
117+
- uses: install-pinned/uv@05d9162df91b0a72301801afd144d0b8b525e0b3
118118

119119
- run: >-
120120
uv sync
@@ -178,7 +178,7 @@ jobs:
178178
python-version: ${{ matrix.python-version }}
179179
cache: pip
180180

181-
- uses: install-pinned/uv@c57eeccb84c14c060f224d6b4dcef7b645f05277
181+
- uses: install-pinned/uv@05d9162df91b0a72301801afd144d0b8b525e0b3
182182

183183
- env:
184184
PARSONS_LIMITED_DEPENDENCIES: 'TRUE'
@@ -218,7 +218,7 @@ jobs:
218218
python-version: '3.13'
219219
cache: pip
220220

221-
- uses: install-pinned/uv@c57eeccb84c14c060f224d6b4dcef7b645f05277
221+
- uses: install-pinned/uv@05d9162df91b0a72301801afd144d0b8b525e0b3
222222

223223
- run: >-
224224
uv sync
@@ -263,7 +263,7 @@ jobs:
263263
python-version: '3.13'
264264
cache: pip
265265

266-
- uses: install-pinned/uv@c57eeccb84c14c060f224d6b4dcef7b645f05277
266+
- uses: install-pinned/uv@05d9162df91b0a72301801afd144d0b8b525e0b3
267267

268268
- run: >-
269269
uv sync
@@ -285,7 +285,7 @@ jobs:
285285
-o results.sarif
286286
.
287287
288-
- uses: github/codeql-action/upload-sarif@45cbd0c69e560cd9e7cd7f8c32362050c9b7ded2
288+
- uses: github/codeql-action/upload-sarif@89a39a4e59826350b863aa6b6252a07ad50cf83e
289289
if: ( success() || failure() ) && contains('["success", "failure"]', steps.run-ruff-sarif.outcome)
290290
with:
291291
sarif_file: results.sarif
@@ -322,7 +322,7 @@ jobs:
322322
python-version: '3.13'
323323
cache: pip
324324

325-
- uses: install-pinned/uv@c57eeccb84c14c060f224d6b4dcef7b645f05277
325+
- uses: install-pinned/uv@05d9162df91b0a72301801afd144d0b8b525e0b3
326326

327327
- run: >-
328328
uv sync
@@ -340,7 +340,7 @@ jobs:
340340
--format 'sarif'
341341
--output 'results.sarif'
342342
343-
- uses: github/codeql-action/upload-sarif@45cbd0c69e560cd9e7cd7f8c32362050c9b7ded2
343+
- uses: github/codeql-action/upload-sarif@89a39a4e59826350b863aa6b6252a07ad50cf83e
344344
if: ( success() || failure() ) && contains('["success", "failure"]', steps.run-bandit-sarif.outcome)
345345
with:
346346
sarif_file: results.sarif
@@ -422,7 +422,7 @@ jobs:
422422
python-version: '3.13'
423423
cache: pip
424424

425-
- uses: install-pinned/uv@c57eeccb84c14c060f224d6b4dcef7b645f05277
425+
- uses: install-pinned/uv@05d9162df91b0a72301801afd144d0b8b525e0b3
426426

427427
- run: >-
428428
uv sync

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ jobs:
2727
cache: pip
2828

2929
- name: Install uv
30-
uses: install-pinned/uv@c57eeccb84c14c060f224d6b4dcef7b645f05277
30+
uses: install-pinned/uv@05d9162df91b0a72301801afd144d0b8b525e0b3
3131

3232
- name: Install parsons
3333
run: >-

.github/workflows/security_scorecard.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,6 @@ jobs:
6262
results_format: sarif
6363
publish_results: true
6464

65-
- uses: github/codeql-action/upload-sarif@45cbd0c69e560cd9e7cd7f8c32362050c9b7ded2
65+
- uses: github/codeql-action/upload-sarif@89a39a4e59826350b863aa6b6252a07ad50cf83e
6666
with:
67-
sarif_file: results.sarif
67+
sarif_file: results.sarif

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,7 @@ instance/
6666

6767
# Sphinx documentation
6868
docs/html
69+
docs/_build/html
6970

7071
# PyBuilder
7172
target/

0 commit comments

Comments
 (0)