Add ruff flake8-bugbear rules (#1325)

* remove xfail_value_error definition since it was only used once

* annotate ruff rules in pyproject.toml

* include all pycodestyle errors except line-too-long (E501) -- conflicts with ruff format

* add flake8-tidy-imports (TID)

* add flake8-import-conventions (ICN)

* add flake8-quotes (Q)

* add flake8-type-checking (TC)

* Add flake8-2020 (YTT) rules

* Add flake8-bugbear (B)

* additional bugbear fixes after merging main

* update success_codes docstrings

* fix docstrings again

Author: bmos

docs/conf.py

@@ -112,7 +112,7 @@
 html_sidebars = {"**": ["versions.html"]}
 
 try:
-    html_context
+    html_context  # noqa: B018
 except NameError:
     html_context = dict()
 

parsons/action_network/action_network.py

@@ -1254,7 +1254,7 @@ def upsert_person(
             mobile_numbers_field = [{"number": str(mobile_number)}]
         elif isinstance(mobile_number, list):
             if len(mobile_number) > 1:
-                raise ("Action Network allows only 1 phone number per activist")
+                raise Exception("Action Network allows only 1 phone number per activist")
             if isinstance(mobile_number[0], list):
                 mobile_numbers_field = [
                     {"number": re.sub("[^0-9]", "", cell)} for cell in mobile_number
@@ -1276,7 +1276,7 @@ def upsert_person(
             mobile_numbers_field = mobile_number
 
         if not email_addresses_field and not mobile_numbers_field:
-            raise (
+            raise Exception(
                 "Either email_address or mobile_number is required and can be formatted "
                 "as a string, list of strings, a dictionary, a list of dictionaries, or "
                 "(for mobile_number only) an integer or list of integers"

parsons/auth0/auth0.py

@@ -82,8 +82,8 @@ def upsert_user(
         username=None,
         given_name=None,
         family_name=None,
-        app_metadata={},
-        user_metadata={},
+        app_metadata=None,
+        user_metadata=None,
         connection="Username-Password-Authentication",
     ):
         """
@@ -106,6 +106,10 @@ def upsert_user(
             Requests Response object
         """
 
+        if user_metadata is None:
+            user_metadata = {}
+        if app_metadata is None:
+            app_metadata = {}
         obj = {
             "email": email.lower(),
             "username": username,

parsons/aws/aws_async.py

@@ -46,8 +46,8 @@ def event_command(event, context):
 
 def run(
     func,
-    args=[],
-    kwargs={},
+    args=None,
+    kwargs=None,
     service="lambda",
     capture_response=False,
     remote_aws_lambda_function_name=None,
@@ -56,6 +56,10 @@ def run(
     func_class_init_kwargs=None,
     **task_kwargs,
 ):
+    if kwargs is None:
+        kwargs = {}
+    if args is None:
+        args = []
     lambda_function_name = remote_aws_lambda_function_name or os.environ.get(
         "AWS_LAMBDA_FUNCTION_NAME"
     )

parsons/box/box.py

@@ -399,6 +399,6 @@ def get_item_id(self, path, base_folder_id=DEFAULT_FOLDER_ID) -> str:
         # recursion, just pass it on up.
         except ValueError as e:
             if base_folder_id == DEFAULT_FOLDER_ID:
-                raise ValueError(f'{e}: "{path}"')
+                raise ValueError(f'{e}: "{path}"') from e
             else:
                 raise

parsons/copper/copper.py

@@ -284,8 +284,8 @@ def process_json(self, json_blob, obj_type, tidy=False):
             for column in list_cols:
                 # Check for nested data
                 list_rows = obj_table.select_rows(
-                    lambda row: isinstance(row[column], list)
-                    and any(isinstance(x, dict) for x in row[column])
+                    lambda row: isinstance(row[column], list)  # noqa: B023
+                    and any(isinstance(x, dict) for x in row[column])  # noqa: B023
                 )
                 # Add separate long table for each column with nested data
                 if list_rows.num_rows > 0:

parsons/databases/alchemy.py

@@ -77,6 +77,6 @@ def split_table_name(full_table_name):
             schema, table = full_table_name.split(".")
         except ValueError as e:
             if "too many values to unpack" in str(e):
-                raise ValueError(f"Invalid database table {full_table_name}")
+                raise ValueError(f"Invalid database table {full_table_name}") from e
 
         return schema, table

parsons/databases/postgres/postgres_create_statement.py

@@ -108,7 +108,7 @@ def generate_data_types(self, table):
         cont = petl.records(table.table)
 
         # Populate empty values for the columns
-        for col in table.columns:
+        for _col in table.columns:
             longest.append(0)
             type_list.append("")
 

parsons/databases/redshift/rs_create_table.py

@@ -107,7 +107,7 @@ def generate_data_types(self, table):
         cont = petl.records(table.table)
 
         # Populate empty values for the columns
-        for col in table.columns:
+        for _col in table.columns:
             longest.append(0)
             type_list.append("")
 

parsons/databases/redshift/rs_table_utilities.py

@@ -755,7 +755,7 @@ def split_full_table_name(full_table_name):
             schema, table = full_table_name.split(".")
         except ValueError as e:
             if "too many values to unpack" in str(e):
-                raise ValueError(f"Invalid Redshift table {full_table_name}")
+                raise ValueError(f"Invalid Redshift table {full_table_name}") from e
 
         return schema, table