improved test_date_to_timestamp_* testing

Author: bmos

test/test_azure/test_azure_blob_storage.py

@@ -4,10 +4,10 @@
 from urllib.parse import parse_qs, urlparse
 
 from azure.storage.blob import BlobClient, ContainerClient
-from test.utils import mark_live_test
 
 from parsons import AzureBlobStorage, Table
 from parsons.utilities import files
+from test.utils import mark_live_test
 
 TEST_ACCOUNT_NAME = os.getenv("PARSONS_AZURE_ACCOUNT_NAME")
 TEST_CREDENTIAL = os.getenv("PARSONS_AZURE_CREDENTIAL")

test/test_box/test_box_storage.py

@@ -7,9 +7,9 @@
 
 import pytest
 from boxsdk.exception import BoxAPIException, BoxOAuthException
-from test.utils import mark_live_test
 
 from parsons import Box, Table
+from test.utils import mark_live_test
 
 """Prior to running, you should ensure that the relevant environment
 variables have been set, e.g. via

test/test_civis.py

@@ -1,8 +1,7 @@
 import unittest
 
-from test.utils import mark_live_test
-
 from parsons import CivisClient, Table
+from test.utils import mark_live_test
 
 # from . import scratch_creds
 

test/test_facebook_ads.py

@@ -1,9 +1,9 @@
 import unittest
 
 import pytest
-from test.utils import mark_live_test
 
 from parsons import FacebookAds, Table
+from test.utils import mark_live_test
 
 users_table = Table(
     [

test/test_utilities.py

@@ -7,6 +7,7 @@
 from unittest import mock
 
 import pytest
+from dateutil.parser import ParserError
 
 from parsons import Table
 from parsons.utilities import check_env, files, json_format, sql_helpers
@@ -18,16 +19,34 @@
     [
         pytest.param("2018-12-13", 1544659200),
         pytest.param("2018-12-13T00:00:00-08:00", 1544688000),
+        pytest.param("2023/04/26 14-00-00", 1682517600),
+        pytest.param("March 3, 2023", 1677801600),
+        pytest.param("01/04/2023", 1672790400),
         pytest.param("", None),
-        pytest.param(
-            "2018-12-13 PST", None, marks=[pytest.mark.xfail(raises=ValueError, strict=True)]
-        ),
     ],
 )
 def test_date_to_timestamp(date, exp_ts):
     assert date_to_timestamp(date) == exp_ts
 
 
+def test_date_to_timestamp_out_of_range():
+    invalid_date = "1682470412"
+    with pytest.raises(ParserError, match=f"year {invalid_date} is out of range"):
+        date_to_timestamp(invalid_date)
+
+
+@pytest.mark.parametrize(
+    "date",
+    [
+        pytest.param("2018-12-13 PST"),
+        pytest.param("2023-04-26 14:30 PM"),
+    ],
+)
+def test_date_to_timestamp_invalid(date):
+    with pytest.raises(ValueError, match="Unknown string format"):
+        date_to_timestamp(date)
+
+
 def test_parse_date():
     # Test parsing an ISO8601 string
     expected = datetime.datetime(year=2020, month=1, day=1, tzinfo=datetime.timezone.utc)