-
Notifications
You must be signed in to change notification settings - Fork 135
Open
Labels
bugImpact - something is currently broken in Parsons and needs to be fixedImpact - something is currently broken in Parsons and needs to be fixedlow priorityPriority - this is a nice-to-have, is non-urgent, and/or has a minor overall imapact on ParsonsPriority - this is a nice-to-have, is non-urgent, and/or has a minor overall imapact on Parsons
Description
The Zoom connector returns a ZoomV1 when ZOOM_PARSONS_VERSION environment variable equals "v2". Passing "v2" as ``parsons_version` returns expected result.
Detailed Description
A .env file with variable ZOOM_PARSONS_VERSION="v2" will not be observed when check_env.check is called. When the default argument parsons_version is passed to check_env.check it stops the the environmental from being searched for.
parsons_version = check_env.check("ZOOM_PARSONS_VERSION", parsons_version)
I've already written a fix. I'm submitting a pull request now.
env_zoom = check_env.check("ZOOM_PARSONS_VERSION", None, optional=True)
if parsons_version == "v1" and env_zoom is not None:
parsons_version = env_zoom
To Reproduce
Set ZOOM_PARSONS_VERSION="v2" and construct Zoom connector.
Priority
Low
Metadata
Metadata
Assignees
Labels
bugImpact - something is currently broken in Parsons and needs to be fixedImpact - something is currently broken in Parsons and needs to be fixedlow priorityPriority - this is a nice-to-have, is non-urgent, and/or has a minor overall imapact on ParsonsPriority - this is a nice-to-have, is non-urgent, and/or has a minor overall imapact on Parsons