Skip to content

Primata/add deploy Hyperliquid and Secondary chains#1312

Open
Primata wants to merge 13 commits into
mainfrom
primata/add-deploy-hypernative
Open

Primata/add deploy Hyperliquid and Secondary chains#1312
Primata wants to merge 13 commits into
mainfrom
primata/add-deploy-hypernative

Conversation

@Primata

@Primata Primata commented Oct 28, 2025

Copy link
Copy Markdown
Contributor

Summary

  • RFCs: Link to RFC, Link to RFC, or $\emptyset$.
  • Categories: any of protocol-units, networks, scripts, util, cicd, or misc.

Adds:

Contracts:

  1. MOVETokenHyperliquid
  2. MOVETokenL2

Test units:

  1. Hyperliquid Mainnet

Scripts:

  1. MOVETokenHyperliquid Mainnet
  2. MOVETokenHyperliquid Testnet

Changelog

Testing

MOVETokenL2 is untested but if we assume MOVETokenHyperliquid is safe, L2 would also be safe. L2 implementation is a version with less features than Hyperliquid.

Outstanding issues

Add script for MOVETokenL2 deployment
Branch typo Hypernative X Hyperliquid OK

@Primata Primata requested a review from 0xmovses as a code owner October 28, 2025 20:56
Copilot AI review requested due to automatic review settings October 28, 2025 20:56
@Primata Primata requested a review from musitdev as a code owner October 28, 2025 20:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds deployment functionality for Hypernative integration and includes several code improvements. The changes introduce a new MOVETokenV3 contract, comprehensive test coverage for deployment scenarios, and Uniswap integration testing capabilities.

  • Adds MOVETokenV3 contract with simplified upgradeable architecture
  • Implements deployment testing infrastructure for Hypernative integration
  • Enhances existing test suite with Uniswap v3/v4 integration testing
  • Updates OpenZeppelin contracts dependency

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
MOVETokenV2.t.sol Adds Uniswap integration testing interfaces and test functions, plus code formatting improvements
DeployHypernative.t.sol New comprehensive test suite for deployment scenarios using CREATE3 factory and Safe multisig
MOVETokenV3.sol New simplified token contract implementation with upgradeable architecture
MOVETokenV2.sol Minor formatting improvements and adds endpoint validation in constructor
openzeppelin-contracts Updates OpenZeppelin contracts submodule to newer commit

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread protocol-units/settlement/mcr/contracts/test/DeployHypernative.t.sol Outdated
Comment thread protocol-units/settlement/mcr/contracts/test/DeployHypernative.t.sol Outdated
* @dev Initializes the contract with initial parameters.
* @param _delegate The address of the delegate.
*/
function initialize(address _delegate) external initializer() {

Copilot AI Oct 28, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The initialize function lacks input validation for the _delegate parameter. Consider adding a check to ensure _delegate is not the zero address, similar to the constructor's endpoint validation.

Suggested change
function initialize(address _delegate) external initializer() {
function initialize(address _delegate) external initializer() {
require(_delegate != address(0), "delegate is zero address");

Copilot uses AI. Check for mistakes.
@Primata Primata changed the title Primata/add deploy hypernative Primata/add deploy Hyperliquid and L2 Nov 1, 2025
@Primata Primata changed the title Primata/add deploy Hyperliquid and L2 Primata/add deploy Hyperliquid and Secondary chains Nov 1, 2025
@ganymedio ganymedio self-requested a review November 1, 2025 23:26

@ganymedio ganymedio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Primata could you add more context to the PR description for example explain "MOVETokenL2 is untested but if we assume MOVETokenHyperliquid is safe, L2 would also be safe."

Eg why MOVETokenHyperliquid should be assumed to be safe and how it can be tested, and why it follows that if MOVETokenHyperliquid is safe, it follows that MOVETokenL2 is safe.

@Primata

Primata commented Nov 2, 2025

Copy link
Copy Markdown
Contributor Author

@Primata could you add more context to the PR description for example explain "MOVETokenL2 is untested but if we assume MOVETokenHyperliquid is safe, L2 would also be safe."

Eg why MOVETokenHyperliquid should be assumed to be safe and how it can be tested, and why it follows that if MOVETokenHyperliquid is safe, it follows that MOVETokenL2 is safe.

updated

@Primata Primata requested a review from ganymedio November 2, 2025 22:59
@0xmovses

0xmovses commented Nov 4, 2025

Copy link
Copy Markdown
Contributor

What cmds did you run for your unit testing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants