Add explicit 'sorted_revisions()' call and replace all uses of 'revisions.all()' with it for 'LandingJob'

Author: ahochheiden

src/lando/api/legacy/workers/landing_worker.py

@@ -300,7 +300,7 @@ def run_job(
                 return True
 
             # Run through the patches one by one and try to apply them.
-            for revision in job.revisions.all():
+            for revision in job.sorted_revisions():
                 patch_buf = StringIO(revision.patch_string)
 
                 try:

src/lando/api/tests/test_landings.py

@@ -879,4 +879,4 @@ def test_landing_job_revisions_sorting(
     job.sort_revisions(new_ordering)
     job.save()
     job = LandingJob.objects.get(id=job.id)
-    assert list(job.revisions.all()) == new_ordering
+    assert list(job.sorted_revisions()) == new_ordering

src/lando/main/management/commands/landing_worker.py

@@ -72,7 +72,7 @@ def run_job(self, job: LandingJob) -> bool:
         repo.reset()
         repo.pull()
 
-        for revision in job.revisions.all():
+        for revision in job.sorted_revisions():
             patch_buffer = StringIO(revision.patch)
             repo.apply_patch(patch_buffer)
 

src/lando/main/models/landing_job.py

@@ -246,6 +246,9 @@ def sort_revisions(self, revisions: list[Revision]):
                 revision=revision, landing_job=self
             ).update(index=index)
 
+    def sorted_revisions(self):
+        return self.revisions.all().order_by('revisionlandingjob__index')
+
     def set_landed_revision_diffs(self):
         """Assign diff_ids, if available, to each association row."""
         # Update association table records with current diff_id values.