Bug 1547678 - Using not existent review group results in AttributeError: 'list' object has no attribute 'keys' r=zalun

Differential Revision: https://phabricator.services.mozilla.com/D29214

Author: globau

moz-phab

@@ -2190,13 +2190,16 @@ def check_for_invalid_reviewers(reviewers, cwd):
             for data in result["data"]
         ]
         # We might be searching by the hashtag.
-        if "maps" in result and "slugMap" in result["maps"]:
-            found_groups.extend(
-                [
-                    "#%s" % normalise_reviewer(r)
-                    for r in result["maps"]["slugMap"].keys()
-                ]
-            )
+        try:
+            if result["maps"]["slugMap"]:
+                found_groups.extend(
+                    [
+                        "#%s" % normalise_reviewer(r)
+                        for r in result["maps"]["slugMap"].keys()
+                    ]
+                )
+        except KeyError:
+            pass
 
     all_reviewers.extend(all_groups)
     found_names.extend(found_groups)

tests/test_helpers.py

@@ -278,7 +278,10 @@ def test_non_existent_reviewers_or_groups_generates_error_list(arc_out):
             {
                 "error": None,
                 "errorMessage": None,
-                "response": {"data": [{"fields": {"slug": "user-group"}}]},
+                "response": {
+                    "data": [{"fields": {"slug": "user-group"}}],
+                    "maps": {"slugMap": []},
+                },
             }
         ),
     )