Remove FXIOS-12029 [Feature flag cleanup] Remove the preferSwitchToOpenTabOverDuplicate flag (#26202)

* Remove feature flag

* pr fix

Author: myaumura

firefox-ios/Client/FeatureFlags/NimbusFlaggableFeature.swift

@@ -33,7 +33,6 @@ enum NimbusFeatureFlagID: String, CaseIterable {
     case noInternetConnectionErrorPage
     case pdfRefactor
     case downloadLiveActivities
-    case preferSwitchToOpenTabOverDuplicate
     case ratingPromptFeature
     case reportSiteIssue
     case searchEngineConsolidation
@@ -129,7 +128,6 @@ struct NimbusFlaggableFeature: HasNimbusSearchBar {
                 .noInternetConnectionErrorPage,
                 .pdfRefactor,
                 .downloadLiveActivities,
-                .preferSwitchToOpenTabOverDuplicate,
                 .ratingPromptFeature,
                 .reportSiteIssue,
                 .feltPrivacySimplifiedUI,

firefox-ios/Client/Frontend/Browser/BrowserViewController/Views/BrowserViewController.swift

@@ -3239,10 +3239,6 @@ class BrowserViewController: UIViewController,
         view.backgroundColor = toolbarLayoutStyle == .baseline ? theme.colors.layer1 : theme.colors.layer3
     }
 
-    var isPreferSwitchToOpenTabOverDuplicateFeatureEnabled: Bool {
-        featureFlags.isFeatureEnabled(.preferSwitchToOpenTabOverDuplicate, checking: .buildOnly)
-    }
-
     // MARK: - Telemetry
 
     private func logTelemetryForAppDidEnterBackground() {
@@ -3266,20 +3262,12 @@ class BrowserViewController: UIViewController,
     func libraryPanel(didSelectURL url: URL, visitType: VisitType) {
         guard let tab = tabManager.selectedTab else { return }
 
-        if isPreferSwitchToOpenTabOverDuplicateFeatureEnabled,
-           let tab = tabManager.tabs.reversed().first(where: {
-               // URL for reading mode comes encoded and we need a separate case to check if it's equal with the tab url
-               ($0.url == url || $0.url == url.safeEncodedUrl) && $0.isPrivate == tab.isPrivate
-           }) {
-            tabManager.selectTab(tab)
-        } else {
-            // Handle keyboard shortcuts from homepage with url selection
-            // (ex: Cmd + Tap on Link; which is a cell in this case)
-            if navigateLinkShortcutIfNeeded(url: url) {
-                return
-            }
-            finishEditingAndSubmit(url, visitType: visitType, forTab: tab)
+        // Handle keyboard shortcuts from homepage with url selection
+        // (ex: Cmd + Tap on Link; which is a cell in this case)
+        if navigateLinkShortcutIfNeeded(url: url) {
+            return
         }
+        finishEditingAndSubmit(url, visitType: visitType, forTab: tab)
     }
 
     func libraryPanelDidRequestToOpenInNewTab(_ url: URL, isPrivate: Bool) {
@@ -3733,26 +3721,18 @@ extension BrowserViewController: HomePanelDelegate {
     func homePanel(didSelectURL url: URL, visitType: VisitType, isGoogleTopSite: Bool) {
         guard let tab = tabManager.selectedTab else { return }
 
-        if isPreferSwitchToOpenTabOverDuplicateFeatureEnabled,
-           let tab = tabManager.tabs.reversed().first(where: {
-               // URL for reading mode comes encoded and we need a separate case to check if it's equal with the tab url
-               ($0.url == url || $0.url == url.safeEncodedUrl) && $0.isPrivate == tab.isPrivate
-           }) {
-            tabManager.selectTab(tab)
-        } else {
-            if isGoogleTopSite {
-                tab.urlType = .googleTopSite
-                searchTelemetry.shouldSetGoogleTopSiteSearch = true
-            }
-
-            // Handle keyboard shortcuts from homepage with url selection
-            // (ex: Cmd + Tap on Link; which is a cell in this case)
-            if navigateLinkShortcutIfNeeded(url: url) {
-                return
-            }
+        if isGoogleTopSite {
+            tab.urlType = .googleTopSite
+            searchTelemetry.shouldSetGoogleTopSiteSearch = true
+        }
 
-            finishEditingAndSubmit(url, visitType: visitType, forTab: tab)
+        // Handle keyboard shortcuts from homepage with url selection
+        // (ex: Cmd + Tap on Link; which is a cell in this case)
+        if navigateLinkShortcutIfNeeded(url: url) {
+            return
         }
+
+        finishEditingAndSubmit(url, visitType: visitType, forTab: tab)
     }
 
     func homePanelDidRequestToOpenInNewTab(_ url: URL, isPrivate: Bool, selectNewTab: Bool = false) {

firefox-ios/Client/Nimbus/NimbusFeatureFlagLayer.swift

@@ -76,9 +76,6 @@ final class NimbusFeatureFlagLayer {
         case .pdfRefactor:
             return checkPdfRefactorFeature(from: nimbus)
 
-        case .preferSwitchToOpenTabOverDuplicate:
-            return checkPreferSwitchToOpenTabOverDuplicate(from: nimbus)
-
         case .ratingPromptFeature:
             return checkRatingPromptFeature(from: nimbus)
 
@@ -317,10 +314,6 @@ final class NimbusFeatureFlagLayer {
         return nimbus.features.pdfRefactorFeature.value().enabled
     }
 
-    private func checkPreferSwitchToOpenTabOverDuplicate(from nimbus: FxNimbus) -> Bool {
-        return nimbus.features.homescreenFeature.value().preferSwitchToOpenTab
-    }
-
     private func checkRatingPromptFeature(from nimbus: FxNimbus) -> Bool {
         return nimbus.features.ratingPromptFeature.value().enabled
     }

firefox-ios/nimbus-features/homescreenFeature.yaml

@@ -11,26 +11,18 @@ features:
           {
             "recent-explorations": false,
           }
-      prefer-switch-to-open-tab:
-        description: >
-           Enables the feature to automatically switch to an existing tab
-           with the same content instead of opening a new one.
-        type: Boolean
-        default: false
     defaults:
       - channel: developer
         value: {
           "sections-enabled": {
             "recent-explorations": false,
           },
-          "prefer-switch-to-open-tab": true
         }
       - channel: beta
         value: {
           "sections-enabled": {
             "recent-explorations": false,
           },
-          "prefer-switch-to-open-tab": false
         }
 
 enums: