Adjust image size of action according to dynamic type preference

[data-sync-user]

┆Issue is synchronized with this Jira Task

[anna-yeddi]

Adjusted the accessibility severity to S4 because the adjacent to the icon is label text that does follow the dynamic type prefs

[lmarceau]

Discussing with Winnie, we can scale using UIFontMetrics.default.scaledValue(for:) method. It would be preferable if this cell is used in multiple places to have a parameter to turn this scaling functionality ON or OFF as well so we can decide on a case by case basis.

[imsanchit]

Sure thanks for the suggestion @lmarceau, what shall be the default value scaling ON/OFF? Also, how about not using this parameter and probably verifying if it's breaking somewhere (if that's possible)?

[lmarceau]

We would have OFF by default, and ON only in this particular view/cell. Those are the PhotonRowActions, and are used in many places throughout the app - testing side effects in all places can be tricky + we don't want this behavior necessarily everywhere.

[data-sync-user]

➤ Sophie Amin commented:

QA: This was finished in fx123 but never QA’d, so if we could check that this is no longer an issue that would be great 🙏

[data-sync-user]

➤ Andrei Bodea commented:

Verified as fixed on v126 (41677) with iPhone 13 Pro (15.7.1).

!image-20240513-141306.png|width=25%,alt="image-20240513-141306.png"!