validator: remove timestamp validation (#86)

Fixes #83

Author: oremj

attributioncode/validator.go

@@ -6,10 +6,8 @@ import (
 	"encoding/base64"
 	"encoding/hex"
 	"net/url"
-	"strconv"
 	"time"
 
-	"github.com/mozilla-services/stubattribution/stubservice/metrics"
 	"github.com/pkg/errors"
 	"github.com/sirupsen/logrus"
 )
@@ -66,13 +64,6 @@ func (v *Validator) Validate(code, sig string) (string, error) {
 		}
 	}
 
-	if since, err := v.validateTimestamp(vals.Get("timestamp")); err != nil {
-		if since > 0 {
-			logEntry = logEntry.WithField("timestamp_age", since.Seconds())
-		}
-		logEntry.WithError(err).WithField("code_ts", vals.Get("timestamp")).Error("could not validate timestamp")
-		return "", err
-	}
 	vals.Del("timestamp")
 
 	// all keys are valid
@@ -106,26 +97,6 @@ func (v *Validator) validateSignature(code, sig string) error {
 	return checkMAC([]byte(v.HMACKey), []byte(code), sigBytes)
 }
 
-func (v *Validator) validateTimestamp(ts string) (since time.Duration, err error) {
-	if ts == "" {
-		return since, nil
-	}
-
-	tsInt, err := strconv.ParseInt(ts, 10, 64)
-	if err != nil {
-		return since, errors.Wrap(err, "Atoi")
-	}
-
-	t := time.Unix(tsInt, 0)
-	since = time.Since(t)
-	metrics.Statsd.Histogram("attributioncode.validator.timestamp.age", since.Seconds())
-	if since > v.Timeout {
-		return since, errors.Errorf("Timestamp: %s is older than timeout: %v", t.UTC(), v.Timeout)
-	}
-
-	return since, nil
-}
-
 func checkMAC(key, msg, msgMAC []byte) error {
 	mac := hmac.New(sha256.New, key)
 	mac.Write(msg)

attributioncode/validator_test.go

@@ -9,18 +9,6 @@ import (
 	"time"
 )
 
-func TestValidateTimeStamp(t *testing.T) {
-	v := NewValidator("", 10*time.Minute)
-
-	ts := "1481143345"
-	if since, err := v.validateTimestamp(ts); err.Error() != "Timestamp: 2016-12-07 20:42:25 +0000 UTC is older than timeout: 10m0s" {
-		if since < 1 {
-			t.Errorf("Expected since > 0: since: %s", since)
-		}
-		t.Errorf("Expected error: %s", err)
-	}
-}
-
 func TestValidateSignature(t *testing.T) {
 	t.Run("static tests", func(t *testing.T) {
 		v := NewValidator("testkey", 10*time.Minute)