Skip to content

Commit 27efc53

Browse files
committed
Implement adr-9: optionally move to the new tracing-support module for logging.
Summary of changes: * Existing `error-support` crate re-exports `log`, `info`, `warn`, `trace` etc. All existing components are changed so that instead of using `log::` directly we use the re-exports from `error-support`. * `error-support` also grows a `testing` feature to expose a couple of helpers for tests. * new crate `tracing-support` which also re-exports `log`, `info`, `warn`, `trace` etc and also has a `testing` feature which re-exports the same test functions. * `error-support` also grows new features to control whether it re-exports the log calls from the `log` and `env_logger` crates, or from `tracing-support`. The intent here is that in app-services we will use the feature which uses `tracing` (because we also have `rust_log_forwarder` setup to support that, but initially on desktop we will enable the feature to continue using `log` while we work on setting up an appropriate tracing subscriber there. There's also a feature to control how error reporting is done - by default it is done like has always been done on mobile, but is setup so that on Desktop it will use the tracing facility. This means we can eventually end up using a single tracing subscriber for both error reports and logs (and also any other event types we invent in the future).
1 parent 2407f72 commit 27efc53

File tree

190 files changed

+1628
-1102
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

190 files changed

+1628
-1102
lines changed

.buildconfig-android.yml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,13 @@ projects:
9999
- name: tabs
100100
type: aar
101101
description: Sync 1.5 remote tabs implementation.
102+
tracing:
103+
path: components/support/tracing/android
104+
artifactId: tracing
105+
publications:
106+
- name: tracing
107+
type: aar
108+
description: Support for logging and tracing.
102109
nimbus:
103110
path: components/nimbus/android
104111
artifactId: nimbus

0 commit comments

Comments
 (0)