Skip to content

Commit 56825a2

Browse files
authored
Patch missing NSS symbols for iOS x86_64 simulators (#7242)
* fix: patch nss condition to account for iOS * chore: add tracking bug to comment
1 parent f347c2b commit 56825a2

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

libs/build-nss-ios.sh

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,16 @@ popd
7373
# Build NSS
7474
BUILD_DIR=$(mktemp -d)
7575
rm -rf "${NSS_SRC_DIR}/nss/out"
76+
77+
# NSS 3.121 gcm.gyp sets HAVE_PLATFORM_GCM for x86_64 iOS
78+
# simulator because 'target_arch=="x64" and OS!="win"' matches iOS.
79+
# `intel-gcm-wrap` is not built for iOS and no lib provides
80+
# platform_gcm_support for this target, causing a linker error.
81+
# Until Bug 2019090 is fixed upstream, this will patch `gcm.gyp` to exclude iOS.
82+
sed -i '' \
83+
's/target_arch=="x64" and OS!="win"/target_arch=="x64" and OS!="win" and OS!="ios"/g' \
84+
"${NSS_SRC_DIR}/nss/lib/freebl/gcm.gyp"
85+
7686
gyp -f ninja "${NSS_SRC_DIR}/nss/nss.gyp" \
7787
--depth "${NSS_SRC_DIR}/nss/" \
7888
--generator-output=. \

0 commit comments

Comments
 (0)