Make it clear that functions added as context within the prompt are "static"

marco-c · suhaibmujahid · commit 0d14e5fee1e7 · 2024-11-25T14:54:33.000-05:00
The LLM was sometimes confused and thought the functions didn't exist or could be modified
diff --git a/bugbug/tools/code_review.py b/bugbug/tools/code_review.py
@@ -1160,7 +1160,7 @@ def run(self, patch: Patch) -> list[InlineComment] | None:
 
                 memory.save_context(
                     {
-                        "input": "Attached, you can find some function definitions that are used in the current patch and might be useful to you, by giving more context about the code under analysis. "
+                        "input": "Attached, you can find some function definitions that are used in the current patch and might be useful to you to have more context about the code under analysis. These functions already exist in the codebase before the patch, and can't be modified. "
                         + function_declaration_text
                     },
                     {

Original file line number	Diff line number	Diff line change
`@@ -1160,7 +1160,7 @@ def run(self, patch: Patch) -> list[InlineComment] \| None:`
`1160`	`1160`
`1161`	`1161`	`memory.save_context(`
`1162`	`1162`	`{`
`1163`		`- "input": "Attached, you can find some function definitions that are used in the current patch and might be useful to you, by giving more context about the code under analysis. "`
	`1163`	`+ "input": "Attached, you can find some function definitions that are used in the current patch and might be useful to you to have more context about the code under analysis. These functions already exist in the codebase before the patch, and can't be modified. "`
`1164`	`1164`	`+ function_declaration_text`
`1165`	`1165`	`},`
`1166`	`1166`	`{`