Unwanted lookups

[davedash]

This happens:

In [22]: product_details.firefox_history_development_releases['4.0b8']
13:04:1299099865 product_details:WARNING Requested product details file firefox_history_development_releases['4 not found! :
/Users/dash/Projects/input/reporter/vendor/src/django-mozilla-product-details/product_details/__init__.py:59

It seems like it shoudl first check to see if 4.0b8 is an item in the dict and then do the lookup.

[fwenzel]

Not sure if that makes sense? If the file you are asking for does not exist, how are we going to know what's in the dict? On the first access to a JSON data file, product_details will load it (and warn if it's not present). From then on, you're working on a regular dict and the file will not be touched again.

[davedash]

The problem is this:

product_details.firefox_history_development_releases['4.0b8']

got parsed as

Look for

"firefox_history_development_releases['4"

rather than:

Look for:
"product_details.firefox_history_development_releases" and treat it as a dictionary and get me the right key.

So the problem is that it too greedily looks for things after the dot.

[ shouldn't be a part of a filename. it's just asking for trouble.

[fwenzel]

Oh how fun the Python parser can be! The language construct that does this is __getattr__. I hope I am not using it wrong? I have no idea why the parser would possibly think that [ or ' could be part of an attribute name.

https://github.com/fwenzel/django-mozilla-product-details/blob/master/product_details/__init__.py#L54

[fwenzel]

jbalogh suggested using setattr in __init__ to make all existing JSON files actual attributes, and then just use __getattr__ as a fallback for when a JSON file is requested that doesn't exist. We should try that.

[davedash]

Hmm... yeah that actually makes sense... pre-load the magic.

The aliases could be implemented there too.