Commit 5d20e9a
feat(nimbus): For complete experiment do not update monitoring data as unenrollment spikes (#15455)
Because
- when the experiment ends clients will all start unenrolling so now
every summary page shows 'unexpectedly high unenrollment' after the
experiment ends because all the clients are unenrolling at the end, we
can do is stop notifying or updating the experiment monitoring data once
the experiment is ended, if we stop updating it, it will never notify it
This commit
- Shows last updated time at summary page
- Does not update monitoring data for the completed experiments.
Fixes #15441
Co-authored-by: Yashika Khurana <yashikakhurana@Yashikas-MBP.home.local>1 parent d2e6aa8 commit 5d20e9a
6 files changed
Lines changed: 48 additions & 17 deletions
File tree
- experimenter/experimenter
- experiments
- migrations
- tests
- jetstream
- tests
- nimbus_ui/templates/nimbus_experiments
Lines changed: 18 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
351 | 351 | | |
352 | 352 | | |
353 | 353 | | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
354 | 359 | | |
355 | 360 | | |
356 | 361 | | |
| |||
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
88 | 88 | | |
89 | 89 | | |
90 | 90 | | |
| 91 | + | |
91 | 92 | | |
92 | 93 | | |
93 | 94 | | |
| |||
220 | 221 | | |
221 | 222 | | |
222 | 223 | | |
| 224 | + | |
223 | 225 | | |
224 | 226 | | |
225 | 227 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
7 | 8 | | |
8 | 9 | | |
9 | 10 | | |
| |||
149 | 150 | | |
150 | 151 | | |
151 | 152 | | |
152 | | - | |
153 | | - | |
154 | | - | |
155 | | - | |
| 153 | + | |
156 | 154 | | |
157 | 155 | | |
158 | 156 | | |
159 | 157 | | |
160 | 158 | | |
| 159 | + | |
161 | 160 | | |
162 | 161 | | |
163 | 162 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3457 | 3457 | | |
3458 | 3458 | | |
3459 | 3459 | | |
3460 | | - | |
3461 | | - | |
3462 | | - | |
3463 | | - | |
3464 | | - | |
3465 | | - | |
3466 | | - | |
| 3460 | + | |
3467 | 3461 | | |
3468 | | - | |
| 3462 | + | |
3469 | 3463 | | |
3470 | 3464 | | |
3471 | 3465 | | |
| |||
3476 | 3470 | | |
3477 | 3471 | | |
3478 | 3472 | | |
| 3473 | + | |
3479 | 3474 | | |
3480 | 3475 | | |
3481 | 3476 | | |
3482 | 3477 | | |
3483 | 3478 | | |
| 3479 | + | |
3484 | 3480 | | |
3485 | 3481 | | |
3486 | | - | |
| 3482 | + | |
3487 | 3483 | | |
3488 | 3484 | | |
3489 | 3485 | | |
| |||
3496 | 3492 | | |
3497 | 3493 | | |
3498 | 3494 | | |
| 3495 | + | |
3499 | 3496 | | |
3500 | 3497 | | |
3501 | 3498 | | |
| |||
Lines changed: 14 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
13 | | - | |
14 | | - | |
15 | | - | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
16 | 21 | | |
17 | 22 | | |
18 | 23 | | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
19 | 29 | | |
20 | 30 | | |
21 | 31 | | |
| |||
0 commit comments