feat(nimbus): Removes eyes and only show complete checkmark for the request (#15007)

Because

- We show both eyes and checkmark emoji if the request is reviewed and
approved, we should only show one emoji at a time, when request is
pending-question mark, when it is under reviewing-eyes, when its
done-checkmark

This commit

- Removes the eyes emoji when request is reviewed and approved, only
shows the check mark emoji for that.

Fixes #15001

Author: yashikakhurana

experimenter/experimenter/slack/constants.py

@@ -49,6 +49,7 @@ class EmojiReaction:
         PENDING = "question"
         CANCEL = "x"
         APPROVE = "eyes"
+        COMPLETE = "white_check_mark"
 
     # Slack API error codes
     class ErrorCode:

experimenter/experimenter/slack/notification.py

@@ -1,3 +1,4 @@
+import contextlib
 import logging
 
 from django.conf import settings
@@ -192,11 +193,20 @@ def send_threaded_success_message(
 
         channel_id = post_response["channel"]
 
-        # Add reaction emoji to original message
+        # Remove eyes emoji (review done) and add checkmark (action complete)
+        # Eyes emoji might not exist, so suppress any errors
+        with contextlib.suppress(SlackApiError):
+            client.reactions_remove(
+                channel=channel_id,
+                name=SlackConstants.EmojiReaction.APPROVE,
+                timestamp=thread_ts,
+            )
+
+        # Add checkmark emoji to original message
         try:
             client.reactions_add(
                 channel=channel_id,
-                name="white_check_mark",
+                name=SlackConstants.EmojiReaction.COMPLETE,
                 timestamp=thread_ts,
             )
         except SlackApiError as emoji_error:

experimenter/experimenter/slack/tests/test_notification.py

@@ -557,6 +557,7 @@ def test_send_experiment_launch_success_message(self, mock_webclient):
         mock_client = Mock()
         mock_webclient.return_value = mock_client
         mock_client.chat_postMessage.return_value = {"ok": True, "channel": "C123456"}
+        mock_client.reactions_remove.return_value = {"ok": True}
         mock_client.reactions_add.return_value = {"ok": True}
 
         thread_ts = "1234567890.123456"
@@ -578,11 +579,20 @@ def test_send_experiment_launch_success_message(self, mock_webclient):
         self.assertIn(self.experiment.slug, call_args.kwargs["text"])
         self.assertEqual(call_args.kwargs["thread_ts"], thread_ts)
 
-        # Verify reaction emoji was added with the correct channel ID
+        # Verify eyes emoji was removed
+        mock_client.reactions_remove.assert_called_once()
+        remove_call = mock_client.reactions_remove.call_args
+        self.assertEqual(remove_call.kwargs["channel"], "C123456")
+        self.assertEqual(remove_call.kwargs["name"], SlackConstants.EmojiReaction.APPROVE)
+        self.assertEqual(remove_call.kwargs["timestamp"], thread_ts)
+
+        # Verify checkmark emoji was added with the correct channel ID
         mock_client.reactions_add.assert_called_once()
         reaction_call = mock_client.reactions_add.call_args
         self.assertEqual(reaction_call.kwargs["channel"], "C123456")
-        self.assertEqual(reaction_call.kwargs["name"], "white_check_mark")
+        self.assertEqual(
+            reaction_call.kwargs["name"], SlackConstants.EmojiReaction.COMPLETE
+        )
         self.assertEqual(reaction_call.kwargs["timestamp"], thread_ts)
 
     @override_settings(
@@ -620,6 +630,7 @@ def test_send_experiment_launch_success_message_reaction_already_exists(
         mock_client = Mock()
         mock_webclient.return_value = mock_client
         mock_client.chat_postMessage.return_value = {"ok": True, "channel": "C123456"}
+        mock_client.reactions_remove.return_value = {"ok": True}
         # Simulate reaction already exists error
         mock_client.reactions_add.side_effect = SlackApiError(
             message="Slack error",
@@ -637,6 +648,7 @@ def test_send_experiment_launch_success_message_reaction_already_exists(
 
         self.assertTrue(result)
         mock_client.chat_postMessage.assert_called_once()
+        mock_client.reactions_remove.assert_called_once()
         mock_client.reactions_add.assert_called_once()
 
     @override_settings(
@@ -648,6 +660,7 @@ def test_send_experiment_launch_success_message_reaction_error(self, mock_webcli
         mock_client = Mock()
         mock_webclient.return_value = mock_client
         mock_client.chat_postMessage.return_value = {"ok": True, "channel": "C123456"}
+        mock_client.reactions_remove.return_value = {"ok": True}
         mock_client.reactions_add.side_effect = SlackApiError(
             message="Slack error", response={"ok": False, "error": "channel_not_found"}
         )