Skip to content

Commit fe32e86

Browse files
AndresRPerez12moz-wptsync-bot
authored andcommitted
Bug 1952876 [wpt PR 51235] - Rename TextCluster begin attribute to start, a=testonly
Automatic update from web-platform-tests Rename TextCluster begin attribute to start This CL renames the begin attribute of TextCluster objects into start. This matches how the function arguments defining character ranges are named, therefore making it consistent. This new naming came to be from the discussion around the spec for the TextMetrics additions: whatwg/html#11000 Bug: 341213359 Change-Id: I55fa6a40d624b29aca56a6af3703efbdab39a541 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6330469 Reviewed-by: Jean-Philippe Gravel <[email protected]> Commit-Queue: Andres Ricardo Perez <[email protected]> Cr-Commit-Position: refs/heads/main@{#1430259} -- wpt-commits: 3dc758379f4b9c49ed5822243a9029edda4ae9f0 wpt-pr: 51235
1 parent ee338ab commit fe32e86

File tree

4 files changed

+24
-24
lines changed

4 files changed

+24
-24
lines changed

testing/web-platform/tests/html/canvas/element/text/2d.text.measure.text-clusters-split.tentative.html

+6-6
Original file line numberDiff line numberDiff line change
@@ -28,22 +28,22 @@ <h1>2d.text.measure.text-clusters-split.tentative</h1>
2828
// Should return 6 clusters(A|B|C| |☺️|❤️).
2929
_assertSame(clusters.length, 6, "clusters.length", "6");
3030
// A from position 0 to 1.
31-
_assertSame(clusters[0].begin, 0, "clusters[\""+(0)+"\"].begin", "0");
31+
_assertSame(clusters[0].start, 0, "clusters[\""+(0)+"\"].start", "0");
3232
_assertSame(clusters[0].end, 1, "clusters[\""+(0)+"\"].end", "1");
3333
// B from position 1 to 2.
34-
_assertSame(clusters[1].begin, 1, "clusters[\""+(1)+"\"].begin", "1");
34+
_assertSame(clusters[1].start, 1, "clusters[\""+(1)+"\"].start", "1");
3535
_assertSame(clusters[1].end, 2, "clusters[\""+(1)+"\"].end", "2");
3636
// C from position 2 to 3.
37-
_assertSame(clusters[2].begin, 2, "clusters[\""+(2)+"\"].begin", "2");
37+
_assertSame(clusters[2].start, 2, "clusters[\""+(2)+"\"].start", "2");
3838
_assertSame(clusters[2].end, 3, "clusters[\""+(2)+"\"].end", "3");
3939
// space from position 3 to 4.
40-
_assertSame(clusters[3].begin, 3, "clusters[\""+(3)+"\"].begin", "3");
40+
_assertSame(clusters[3].start, 3, "clusters[\""+(3)+"\"].start", "3");
4141
_assertSame(clusters[3].end, 4, "clusters[\""+(3)+"\"].end", "4");
4242
// ☺️ from position 4 to 6.
43-
_assertSame(clusters[4].begin, 4, "clusters[\""+(4)+"\"].begin", "4");
43+
_assertSame(clusters[4].start, 4, "clusters[\""+(4)+"\"].start", "4");
4444
_assertSame(clusters[4].end, 6, "clusters[\""+(4)+"\"].end", "6");
4545
// ❤️ from position 6 to 8.
46-
_assertSame(clusters[5].begin, 6, "clusters[\""+(5)+"\"].begin", "6");
46+
_assertSame(clusters[5].start, 6, "clusters[\""+(5)+"\"].start", "6");
4747
_assertSame(clusters[5].end, 8, "clusters[\""+(5)+"\"].end", "8");
4848

4949
});

testing/web-platform/tests/html/canvas/offscreen/text/2d.text.measure.text-clusters-split.tentative.html

+6-6
Original file line numberDiff line numberDiff line change
@@ -29,22 +29,22 @@ <h1>2d.text.measure.text-clusters-split.tentative</h1>
2929
// Should return 6 clusters(A|B|C| |☺️|❤️).
3030
_assertSame(clusters.length, 6, "clusters.length", "6");
3131
// A from position 0 to 1.
32-
_assertSame(clusters[0].begin, 0, "clusters[\""+(0)+"\"].begin", "0");
32+
_assertSame(clusters[0].start, 0, "clusters[\""+(0)+"\"].start", "0");
3333
_assertSame(clusters[0].end, 1, "clusters[\""+(0)+"\"].end", "1");
3434
// B from position 1 to 2.
35-
_assertSame(clusters[1].begin, 1, "clusters[\""+(1)+"\"].begin", "1");
35+
_assertSame(clusters[1].start, 1, "clusters[\""+(1)+"\"].start", "1");
3636
_assertSame(clusters[1].end, 2, "clusters[\""+(1)+"\"].end", "2");
3737
// C from position 2 to 3.
38-
_assertSame(clusters[2].begin, 2, "clusters[\""+(2)+"\"].begin", "2");
38+
_assertSame(clusters[2].start, 2, "clusters[\""+(2)+"\"].start", "2");
3939
_assertSame(clusters[2].end, 3, "clusters[\""+(2)+"\"].end", "3");
4040
// space from position 3 to 4.
41-
_assertSame(clusters[3].begin, 3, "clusters[\""+(3)+"\"].begin", "3");
41+
_assertSame(clusters[3].start, 3, "clusters[\""+(3)+"\"].start", "3");
4242
_assertSame(clusters[3].end, 4, "clusters[\""+(3)+"\"].end", "4");
4343
// ☺️ from position 4 to 6.
44-
_assertSame(clusters[4].begin, 4, "clusters[\""+(4)+"\"].begin", "4");
44+
_assertSame(clusters[4].start, 4, "clusters[\""+(4)+"\"].start", "4");
4545
_assertSame(clusters[4].end, 6, "clusters[\""+(4)+"\"].end", "6");
4646
// ❤️ from position 6 to 8.
47-
_assertSame(clusters[5].begin, 6, "clusters[\""+(5)+"\"].begin", "6");
47+
_assertSame(clusters[5].start, 6, "clusters[\""+(5)+"\"].start", "6");
4848
_assertSame(clusters[5].end, 8, "clusters[\""+(5)+"\"].end", "8");
4949
t.done();
5050

testing/web-platform/tests/html/canvas/offscreen/text/2d.text.measure.text-clusters-split.tentative.worker.js

+6-6
Original file line numberDiff line numberDiff line change
@@ -24,22 +24,22 @@ t.step(function() {
2424
// Should return 6 clusters(A|B|C| |☺️|❤️).
2525
_assertSame(clusters.length, 6, "clusters.length", "6");
2626
// A from position 0 to 1.
27-
_assertSame(clusters[0].begin, 0, "clusters[\""+(0)+"\"].begin", "0");
27+
_assertSame(clusters[0].start, 0, "clusters[\""+(0)+"\"].start", "0");
2828
_assertSame(clusters[0].end, 1, "clusters[\""+(0)+"\"].end", "1");
2929
// B from position 1 to 2.
30-
_assertSame(clusters[1].begin, 1, "clusters[\""+(1)+"\"].begin", "1");
30+
_assertSame(clusters[1].start, 1, "clusters[\""+(1)+"\"].start", "1");
3131
_assertSame(clusters[1].end, 2, "clusters[\""+(1)+"\"].end", "2");
3232
// C from position 2 to 3.
33-
_assertSame(clusters[2].begin, 2, "clusters[\""+(2)+"\"].begin", "2");
33+
_assertSame(clusters[2].start, 2, "clusters[\""+(2)+"\"].start", "2");
3434
_assertSame(clusters[2].end, 3, "clusters[\""+(2)+"\"].end", "3");
3535
// space from position 3 to 4.
36-
_assertSame(clusters[3].begin, 3, "clusters[\""+(3)+"\"].begin", "3");
36+
_assertSame(clusters[3].start, 3, "clusters[\""+(3)+"\"].start", "3");
3737
_assertSame(clusters[3].end, 4, "clusters[\""+(3)+"\"].end", "4");
3838
// ☺️ from position 4 to 6.
39-
_assertSame(clusters[4].begin, 4, "clusters[\""+(4)+"\"].begin", "4");
39+
_assertSame(clusters[4].start, 4, "clusters[\""+(4)+"\"].start", "4");
4040
_assertSame(clusters[4].end, 6, "clusters[\""+(4)+"\"].end", "6");
4141
// ❤️ from position 6 to 8.
42-
_assertSame(clusters[5].begin, 6, "clusters[\""+(5)+"\"].begin", "6");
42+
_assertSame(clusters[5].start, 6, "clusters[\""+(5)+"\"].start", "6");
4343
_assertSame(clusters[5].end, 8, "clusters[\""+(5)+"\"].end", "8");
4444
t.done();
4545
});

testing/web-platform/tests/html/canvas/tools/yaml/text.yaml

+6-6
Original file line numberDiff line numberDiff line change
@@ -2058,22 +2058,22 @@
20582058
// Should return 6 clusters(A|B|C| |☺️|❤️).
20592059
@assert clusters.length === 6;
20602060
// A from position 0 to 1.
2061-
@assert clusters[0].begin === 0;
2061+
@assert clusters[0].start === 0;
20622062
@assert clusters[0].end === 1;
20632063
// B from position 1 to 2.
2064-
@assert clusters[1].begin === 1;
2064+
@assert clusters[1].start === 1;
20652065
@assert clusters[1].end === 2;
20662066
// C from position 2 to 3.
2067-
@assert clusters[2].begin === 2;
2067+
@assert clusters[2].start === 2;
20682068
@assert clusters[2].end === 3;
20692069
// space from position 3 to 4.
2070-
@assert clusters[3].begin === 3;
2070+
@assert clusters[3].start === 3;
20712071
@assert clusters[3].end === 4;
20722072
// ☺️ from position 4 to 6.
2073-
@assert clusters[4].begin === 4;
2073+
@assert clusters[4].start === 4;
20742074
@assert clusters[4].end === 6;
20752075
// ❤️ from position 6 to 8.
2076-
@assert clusters[5].begin === 6;
2076+
@assert clusters[5].start === 6;
20772077
@assert clusters[5].end === 8;
20782078
20792079
- name: 2d.text.measure.text-clusters-exceptions.tentative

0 commit comments

Comments
 (0)