Merge pull request #44 from mozilla/ev-update

EnvVar Naming Updates

Author: bsieber-mozilla

.github/workflows/test-build.yaml

@@ -23,10 +23,10 @@ jobs:
         run: |-
           docker run --rm \
           -e JIRA_USERNAME \
-          -e JIRA_PASSWORD \
+          -e JIRA_API_KEY \
           -e BUGZILLA_API_KEY \
           ghcr.io/${{ github.repository }}:${{ github.sha }}
         env:
           JIRA_USERNAME: "fake_username"
-          JIRA_PASSWORD: "fake_password"
+          JIRA_API_KEY: "fake_api_key"
           BUGZILLA_API_KEY: "fake_api_key"

infra/config/local_dev.env

@@ -2,7 +2,7 @@
 
 # Jira API Secrets
 JIRA_USERNAME="fake_jira_username"
-JIRA_PASSWORD="fake_jira_password"
+JIRA_API_KEY="fake_jira_api_key"
 
 # Bugzilla API Secrets
 BUGZILLA_API_KEY="fake_bugzilla_api_key"

src/app/environment.py

@@ -25,7 +25,7 @@ class Settings(BaseSettings):
     jira_base_url: str = "https://mozit-test.atlassian.net/"
     jira_issue_url: str = f"{jira_base_url}browse/%s"
     jira_username: str
-    jira_password: str
+    jira_api_key: str
 
     # Bugzilla
     bugzilla_base_url: str = "https://bugzilla-dev.allizom.org"

src/jbi/services.py

@@ -16,7 +16,7 @@ def get_jira():
     return Jira(
         url=settings.jira_base_url,
         username=settings.jira_username,
-        password=settings.jira_password,
+        password=settings.jira_api_key,  # package calls this param 'password' but actually expects an api key
     )