Skip to content

Commit 8e9fd93

Browse files
authored
Incrementality metric refactor (#1252)
1 parent 79a88da commit 8e9fd93

File tree

2 files changed

+1
-13
lines changed

2 files changed

+1
-13
lines changed

definitions/firefox_desktop.toml

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1607,12 +1607,6 @@ data_source = "main"
16071607
friendly_name = "SSL Loads Probe Ratio"
16081608
description = "Ratio of clients that have the http_pageload_is_ssl_ratio_v1 probe"
16091609

1610-
[metrics.sponsored_tiles_disabled]
1611-
select_expression = '{{agg_any("sponsored_tiles_disable_count > 0")}}'
1612-
data_source = "sponsored_tiles_clients_daily"
1613-
friendly_name = "Sponsored Tiles Disabled Event"
1614-
description = "Boolean that identifies clients that disabled sponsored tiles during experiment"
1615-
16161610
[metrics.sponsored_tiles_dismissals]
16171611
select_expression = "COALESCE(SUM(sponsored_topsite_tile_dismissals), 0)"
16181612
data_source = "newtab_clients_daily"
@@ -2040,12 +2034,6 @@ experiments_column_type = "native"
20402034
friendly_name = "Activity Stream Events"
20412035
description = "Activity Stream Event pings"
20422036

2043-
[data_sources.sponsored_tiles_clients_daily]
2044-
from_expression = "mozdata.telemetry.sponsored_tiles_clients_daily"
2045-
submission_date_column = "submission_date"
2046-
description = "Sponsored Tiles Clients Daily"
2047-
friendly_name = "Sponsored Tiles Clients Daily"
2048-
20492037
[data_sources.clients_first_seen_v2]
20502038
from_expression = "moz-fx-data-shared-prod.telemetry_derived.clients_first_seen_v2" # TODO: Replace with view
20512039
submission_date_column = "first_seen_date"

jetstream/outcomes/firefox_desktop/incrementality_sponsored_tiles.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
friendly_name = "Incrementality Sponsored Tiles"
22
description = "Interaction metrics for sponsored tiles specifically for incrementality tests."
33

4-
[metrics.sponsored_tiles_disabled.statistics.binomial]
4+
[metrics.newtab_sponsored_tiles_enabled.statistics.binomial]
55
[metrics.any_sponsored_tiles_dismissals.statistics.binomial]
66

77
[metrics.sponsored_tiles_dismissals.statistics.bootstrap_mean]

0 commit comments

Comments
 (0)