Skip to content

Commit 9d5cd5a

Browse files
authored
use MAX instead of SUM for calculating cumulative counts (#1264)
1 parent f0b1cbf commit 9d5cd5a

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

jetstream/whats-new-toast-notification-taskbar-tabs-release-v2.toml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -73,26 +73,26 @@ data_source = "metrics"
7373
friendly_name = "Installed Web App"
7474
description = "Average Installed Web Apps per user (approx from install and uninstall events)"
7575
select_expression = """
76-
COALESCE(SUM(CASE WHEN event_name = 'install' THEN cumulative_count END),0) -
77-
COALESCE(SUM(CASE WHEN event_name = 'uninstall' THEN cumulative_count END),0)
76+
COALESCE(MAX(CASE WHEN event_name = 'install' THEN cumulative_count END),0) -
77+
COALESCE(MAX(CASE WHEN event_name = 'uninstall' THEN cumulative_count END),0)
7878
"""
7979
data_source = "web_app_events"
8080

8181
[metrics.unique_client_pins]
8282
friendly_name = "Pinned Web Apps"
8383
description = "Average Pinned Web Apps per user (approx from pin and unpin events)"
8484
select_expression = """
85-
COALESCE(SUM(CASE WHEN event_name = 'pin' THEN cumulative_count END),0) -
86-
COALESCE(SUM(CASE WHEN event_name = 'unpin' THEN cumulative_count END),0)
85+
COALESCE(MAX(CASE WHEN event_name = 'pin' THEN cumulative_count END),0) -
86+
COALESCE(MAX(CASE WHEN event_name = 'unpin' THEN cumulative_count END),0)
8787
"""
8888
data_source = "web_app_events"
8989

9090
[metrics.web_app_launches]
9191
friendly_name = "Web App Launches"
9292
description = "Average Web Apps Launches per user (approx from activate and move to taskbar events)"
9393
select_expression = """
94-
COALESCE(SUM(CASE WHEN event_name = 'activate' THEN cumulative_count END),0) -
95-
COALESCE(SUM(CASE WHEN event_name = 'install' THEN cumulative_count END),0)
94+
COALESCE(MAX(CASE WHEN event_name = 'activate' THEN cumulative_count END),0) -
95+
COALESCE(MAX(CASE WHEN event_name = 'install' THEN cumulative_count END),0)
9696
"""
9797
data_source = "web_app_events"
9898

0 commit comments

Comments
 (0)