chore: Move all lints to Cargo.toml

Author: Not-Nik

Cargo.toml

@@ -37,20 +37,16 @@ ignored = ["bindgen", "semver", "serde", "serde_derive", "toml"]
 
 [lints.rust]
 absolute_paths_not_starting_with_crate = "warn"
-# TODO: Re-activate with MSRV 1.82.0. See
-# https://github.com/mozilla/neqo/pull/2661 for details.
-# ambiguous_negative_literals = "warn"
+ambiguous_negative_literals = "warn"
 explicit_outlives_requirements = "warn"
 macro_use_extern_crate = "warn"
 missing_abi = "warn"
 non_ascii_idents = "warn"
-# TODO: Re-activate with MSRV 1.82.0. See
-# https://github.com/mozilla/neqo/pull/2661 for details.
-# redundant_imports = "warn"
+redundant_imports = "warn"
 redundant_lifetimes = "warn"
 trivial_numeric_casts = "warn"
 unit_bindings = "warn"
-unexpected_cfgs = { level = "warn", check-cfg = ['cfg(coverage,coverage_nightly)'] }
+unexpected_cfgs = { level = "warn", check-cfg = ['cfg(coverage,coverage_nightly,fuzzing)'] }
 unused_import_braces = "warn"
 unused_lifetimes = "warn"
 unused_macro_rules = "warn"
@@ -74,21 +70,22 @@ float_cmp_const = "warn"
 fn_to_numeric_cast_any = "warn"
 get_unwrap = "warn"
 if_then_some_else_none = "warn"
-# TODO: Re-activate with MSRV 1.82.0. See
-# https://github.com/mozilla/neqo/pull/2661 for details.
-# impl_trait_in_params = "warn"
+impl_trait_in_params = "warn"
 infinite_loop = "warn"
 iter_over_hash_type = "warn"
 large_include_file = "warn"
 let_underscore_must_use = "warn"
 let_underscore_untyped = "warn"
-literal_string_with_formatting_args = "allow" # FIXME: Re-enable "warn" when MSRV is > 1.87. See https://github.com/rust-lang/rust-clippy/pull/13953#issuecomment-2676336899
+literal_string_with_formatting_args = "warn"
 lossy_float_literal = "warn"
 map_with_unused_argument_over_ranges = "warn"
 mem_forget = "warn"
 missing_asserts_for_indexing = "warn"
+missing_errors_doc = "allow"
+missing_panics_doc = "allow"
+missing_safety_doc = "allow"
 mixed_read_write_in_expression = "warn"
-module_name_repetitions = "warn"
+module_name_repetitions = "allow"
 multiple_crate_versions = "allow"
 multiple_inherent_impl = "warn"
 mutex_atomic = "warn"

src/aead.rs

@@ -12,13 +12,12 @@ use std::{
 use crate::{
     constants::{Cipher, Version},
     err::{sec::SEC_ERROR_BAD_DATA, Error, Res},
-    experimental_api,
     p11::{
         self, Context, PK11SymKey, PK11_AEADOp, PK11_CreateContextBySymKey, CKA_DECRYPT,
         CKA_ENCRYPT, CKA_NSS_MESSAGE, CKG_GENERATE_COUNTER_XOR, CKG_NO_GENERATE, CKM_AES_GCM,
         CKM_CHACHA20_POLY1305, CK_ATTRIBUTE_TYPE, CK_GENERATOR_FUNCTION, CK_MECHANISM_TYPE,
     },
-    scoped_ptr, secstatus_to_res,
+    secstatus_to_res,
     ssl::{PRUint16, PRUint64, PRUint8, SSLAeadContext},
     SECItemBorrowed, SymKey,
 };
@@ -374,7 +373,7 @@ impl Aead {
                 aad.as_ptr(),
                 c_int_len(aad.len())?,
                 ct.as_mut_ptr(),
-                &mut ct_len,
+                &raw mut ct_len,
                 c_int_len(ct.len())?, // signed :(
                 tag.as_mut_ptr(),
                 c_int_len(tag.len())?,
@@ -409,7 +408,7 @@ impl Aead {
                 aad.as_ptr(),
                 c_int_len(aad.len())?,
                 pt.as_mut_ptr(),
-                &mut pt_len,
+                &raw mut pt_len,
                 c_int_len(pt.len())?,
                 ct.as_ptr().add(pt_expected).cast_mut(),
                 c_int_len(TAG_LEN)?,

src/constants.rs

@@ -4,8 +4,6 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-use std::convert::TryFrom;
-
 use enum_map::Enum;
 use strum::FromRepr;
 

src/ec.rs

@@ -144,7 +144,7 @@ pub fn ecdh_keygen(curve: &EcCurve) -> Result<EcdhKeypair, Error> {
             *slot,
             ckm,
             oid_ptr.cast(),
-            &mut pk_ptr,
+            &raw mut pk_ptr,
             CK_FALSE.into(),
             CK_FALSE.into(),
             ptr::null_mut(),
@@ -211,7 +211,7 @@ pub fn import_ec_private_key_pkcs8(pki: &[u8]) -> Result<PrivateKey, Error> {
             0,
             0,
             KU_ALL,
-            &mut pk_ptr,
+            &raw mut pk_ptr,
             ptr::null_mut(),
         ))?;
 

src/hkdf.rs

@@ -4,7 +4,7 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-#![allow(non_camel_case_types)]
+#![allow(non_camel_case_types, reason = "C enum naming")]
 
 use std::{
     convert::TryFrom as _,
@@ -101,7 +101,7 @@ impl<'a, T: Sized + 'a> ParamItem<'a, T> {
         })
     }
 
-    pub fn ptr(&mut self) -> *mut SECItem {
+    pub const fn ptr(&mut self) -> *mut SECItem {
         std::ptr::addr_of_mut!(self.item)
     }
 }

src/hmac.rs

@@ -92,7 +92,7 @@ pub fn hmac(alg: &HmacAlgorithm, key: &[u8], data: &[u8]) -> Result<Vec<u8>, Err
         PK11_DigestFinal(
             *context,
             digest.as_mut_ptr(),
-            &mut digest_len,
+            &raw mut digest_len,
             digest.len() as u32,
         )
         .into_result()?;

src/lib.rs

@@ -4,17 +4,6 @@
 // option. This file may not be copied, modified, or distributed
 // except according to those terms.
 
-#![cfg_attr(feature = "deny-warnings", deny(warnings))]
-#![warn(clippy::pedantic)]
-// Bindgen auto generated code
-// won't adhere to the clippy rules below
-#![allow(clippy::borrow_as_ptr)]
-#![allow(clippy::module_name_repetitions)]
-#![allow(clippy::unseparated_literal_suffix)]
-#![allow(clippy::used_underscore_binding)]
-#![allow(clippy::missing_panics_doc)]
-#![allow(clippy::missing_errors_doc)]
-#![allow(clippy::missing_safety_doc)]
 #![cfg_attr(coverage_nightly, feature(coverage_attribute))]
 
 #[cfg(feature = "disable-encryption")]
@@ -49,7 +38,6 @@ mod ssl;
 pub mod time;
 
 use std::{
-    convert::TryFrom,
     env,
     ffi::CString,
     path::{Path, PathBuf},

src/p11.rs

@@ -22,7 +22,7 @@ use crate::{
 };
 
 #[must_use]
-pub fn hex_with_len(buf: impl AsRef<[u8]>) -> String {
+pub fn hex_with_len<B: AsRef<[u8]>>(buf: B) -> String {
     use std::fmt::Write as _;
     let buf = buf.as_ref();
     let mut ret = String::with_capacity(10 + buf.len() * 2);

src/time.rs

@@ -19,6 +19,7 @@ use std::{
 use once_cell::sync::OnceCell;
 
 use crate::{
+    agent::as_c_void,
     err::{Error, Res},
     prio::PRFileDesc,
     ssl::SSLTimeFunc,
@@ -175,19 +176,9 @@ impl TimeHolder {
         *p.as_ref().unwrap()
     }
 
-    #[expect(
-        clippy::not_unsafe_ptr_arg_deref,
-        clippy::ptr_as_ptr,
-        clippy::ref_as_ptr
-    )]
+    #[expect(clippy::not_unsafe_ptr_arg_deref)]
     pub fn bind(&mut self, fd: *mut PRFileDesc) -> Res<()> {
-        unsafe {
-            SSL_SetTimeFunc(
-                fd,
-                Some(Self::time_func),
-                &mut *self.t as *mut _ as *mut c_void,
-            )
-        }
+        unsafe { SSL_SetTimeFunc(fd, Some(Self::time_func), as_c_void(&mut self.t)) }
     }
 
     pub fn set(&mut self, t: Instant) -> Res<()> {

src/util.rs

@@ -203,7 +203,7 @@ impl Drop for SECItemMut {
         // If the second argument is true, it also frees the SECItem itself,
         // which we don't want to do, because rust owns that memory.
         unsafe {
-            SECITEM_FreeItem(&mut self.inner, PRBool::from(false));
+            SECITEM_FreeItem(&raw mut self.inner, PRBool::from(false));
         }
     }
 }