chore: Be more idiomatic (#3463)

Author: larseggert

build.rs

@@ -168,7 +168,7 @@ fn build_nss(dir: PathBuf) {
         String::from("--static"),
     ];
     let target = env::var("TARGET").unwrap();
-    if target.strip_prefix("aarch64-").is_some() {
+    if target.starts_with("aarch64-") {
         build_nss.push(String::from("--target=arm64"));
     }
     let status = Command::new(get_bash())

src/agent.rs

@@ -364,8 +364,8 @@ impl SecretAgentPreInfo {
     }
 
     #[must_use]
-    pub const fn alpn(&self) -> Option<&String> {
-        self.alpn.as_ref()
+    pub fn alpn(&self) -> Option<&str> {
+        self.alpn.as_deref()
     }
 }
 
@@ -428,8 +428,8 @@ impl SecretAgentInfo {
         self.ech_accepted
     }
     #[must_use]
-    pub const fn alpn(&self) -> Option<&String> {
-        self.alpn.as_ref()
+    pub fn alpn(&self) -> Option<&str> {
+        self.alpn.as_deref()
     }
     #[must_use]
     pub const fn signature_scheme(&self) -> SignatureScheme {

src/agentio.rs

@@ -131,8 +131,8 @@ impl RecordList {
 }
 
 impl Deref for RecordList {
-    type Target = Vec<Record>;
-    fn deref(&self) -> &Vec<Record> {
+    type Target = [Record];
+    fn deref(&self) -> &[Record] {
         &self.records
     }
 }

src/cert.rs

@@ -93,12 +93,12 @@ impl CertificateInfo {
     }
 
     #[must_use]
-    pub const fn stapled_ocsp_responses(&self) -> Option<&Vec<Vec<u8>>> {
-        self.stapled_ocsp_responses.as_ref()
+    pub fn stapled_ocsp_responses(&self) -> Option<&[Vec<u8>]> {
+        self.stapled_ocsp_responses.as_deref()
     }
 
     #[must_use]
-    pub const fn signed_cert_timestamp(&self) -> Option<&Vec<u8>> {
-        self.signed_cert_timestamp.as_ref()
+    pub fn signed_cert_timestamp(&self) -> Option<&[u8]> {
+        self.signed_cert_timestamp.as_deref()
     }
 }

tests/agent.rs

@@ -278,8 +278,8 @@ fn alpn() {
     connect(&mut client, &mut server);
 
     let expected = Some(String::from("alpn"));
-    assert_eq!(expected.as_ref(), client.info().unwrap().alpn());
-    assert_eq!(expected.as_ref(), server.info().unwrap().alpn());
+    assert_eq!(expected.as_deref(), client.info().unwrap().alpn());
+    assert_eq!(expected.as_deref(), server.info().unwrap().alpn());
 }
 
 #[test]
@@ -308,8 +308,8 @@ fn alpn_multi() {
     connect(&mut client, &mut server);
 
     let expected = Some(String::from("alpn"));
-    assert_eq!(expected.as_ref(), client.info().unwrap().alpn());
-    assert_eq!(expected.as_ref(), server.info().unwrap().alpn());
+    assert_eq!(expected.as_deref(), client.info().unwrap().alpn());
+    assert_eq!(expected.as_deref(), server.info().unwrap().alpn());
 }
 
 #[test]
@@ -327,8 +327,8 @@ fn alpn_server_pref() {
     connect(&mut client, &mut server);
 
     let expected = Some(String::from("alpn"));
-    assert_eq!(expected.as_ref(), client.info().unwrap().alpn());
-    assert_eq!(expected.as_ref(), server.info().unwrap().alpn());
+    assert_eq!(expected.as_deref(), client.info().unwrap().alpn());
+    assert_eq!(expected.as_deref(), server.info().unwrap().alpn());
 }
 
 #[test]