Skip to content

Commit 9d96c14

Browse files
NetacciNetacci
committed
update input placeholder text
1 parent 910963e commit 9d96c14

File tree

11 files changed

+100
-101
lines changed

11 files changed

+100
-101
lines changed

‎src/__tests__/CompareResults/__snapshots__/ResultsTable.test.tsx.snap‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -233,10 +233,10 @@ exports[`Results Table Should match snapshot 1`] = `
233233
</div>
234234
<input
235235
aria-invalid="false"
236-
aria-label="Search base by ID number, author email or bug number"
236+
aria-label="Search by revision ID, author, bug number and comments"
237237
class="MuiInputBase-input MuiOutlinedInput-input MuiInputBase-inputSizeSmall MuiInputBase-inputAdornedStart css-jrmsot-MuiInputBase-input-MuiOutlinedInput-input"
238238
id="search-base-input"
239-
placeholder="Search base by ID number, author email or bug number"
239+
placeholder="Search by revision ID, author, bug number and comments"
240240
type="text"
241241
value=""
242242
/>
@@ -523,10 +523,10 @@ exports[`Results Table Should match snapshot 1`] = `
523523
</div>
524524
<input
525525
aria-invalid="false"
526-
aria-label="Search revision by ID number, author email or bug number"
526+
aria-label="Search by revision ID, author, bug number and comments"
527527
class="MuiInputBase-input MuiOutlinedInput-input MuiInputBase-inputSizeSmall MuiInputBase-inputAdornedStart css-jrmsot-MuiInputBase-input-MuiOutlinedInput-input"
528528
id="search-new-input"
529-
placeholder="Search revision by ID number, author email or bug number"
529+
placeholder="Search by revision ID, author, bug number and comments"
530530
type="text"
531531
value=""
532532
/>

‎src/__tests__/Search/SearchView.test.tsx‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -133,9 +133,9 @@ describe('Search Container', () => {
133133
name: baseTitle,
134134
});
135135

136-
const baseInput = screen.getByPlaceholderText(
137-
'Search base by ID number, author email or bug number',
138-
);
136+
const baseInput = screen.getAllByPlaceholderText(
137+
'Search by revision ID, author, bug number and comments',
138+
)[0];
139139
const repoDropdown = screen.getByRole('button', { name: 'Base' });
140140

141141
expect(compTitle).toBeInTheDocument();
@@ -160,15 +160,15 @@ describe('Base and OverTime Search', () => {
160160

161161
// Search input appears
162162
expect(
163-
screen.getByPlaceholderText(
164-
/Search base by ID number, author email or bug number/i,
165-
),
163+
screen.getAllByPlaceholderText(
164+
/Search by revision ID, author, bug number and comments/i,
165+
)[0],
166166
).toBeInTheDocument();
167167

168168
await expandOverTimeComponent();
169169
expect(
170170
screen.getAllByPlaceholderText(
171-
/Search revision by ID number, author email or bug number/i,
171+
/Search by revision ID, author, bug number and comments/i,
172172
)[1],
173173
).toBeInTheDocument();
174174

‎src/__tests__/Search/SelectedRevision.test.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ describe('SelectedRevision', () => {
7373
expect(baseDropdown).toHaveTextContent('try');
7474

7575
const firstSearchInput = screen.getAllByPlaceholderText(
76-
'Search base by ID number, author email or bug number',
76+
'Search by revision ID, author, bug number and comments',
7777
)[0];
7878
await user.click(firstSearchInput);
7979
await user.click(

‎src/__tests__/Search/__snapshots__/CompareOverTime.test.tsx.snap‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -264,10 +264,10 @@ exports[`Compare Over Time renders correctly in Search View: Initial state for t
264264
</div>
265265
<input
266266
aria-invalid="false"
267-
aria-label="Search revision by ID number, author email or bug number"
267+
aria-label="Search by revision ID, author, bug number and comments"
268268
class="MuiInputBase-input MuiOutlinedInput-input MuiInputBase-inputAdornedStart css-1rgu65m-MuiInputBase-input-MuiOutlinedInput-input"
269269
id="search-new-input"
270-
placeholder="Search revision by ID number, author email or bug number"
270+
placeholder="Search by revision ID, author, bug number and comments"
271271
type="text"
272272
value=""
273273
/>
@@ -1174,10 +1174,10 @@ exports[`Compare Over Time should have an edit mode in Results View: After click
11741174
</div>
11751175
<input
11761176
aria-invalid="false"
1177-
aria-label="Search revision by ID number, author email or bug number"
1177+
aria-label="Search by revision ID, author, bug number and comments"
11781178
class="MuiInputBase-input MuiOutlinedInput-input MuiInputBase-inputSizeSmall MuiInputBase-inputAdornedStart css-jrmsot-MuiInputBase-input-MuiOutlinedInput-input"
11791179
id="search-new-input"
1180-
placeholder="Search revision by ID number, author email or bug number"
1180+
placeholder="Search by revision ID, author, bug number and comments"
11811181
type="text"
11821182
value=""
11831183
/>
@@ -1970,10 +1970,10 @@ exports[`Compare Over Time should remove the checked revision once X button is c
19701970
</div>
19711971
<input
19721972
aria-invalid="false"
1973-
aria-label="Search revision by ID number, author email or bug number"
1973+
aria-label="Search by revision ID, author, bug number and comments"
19741974
class="MuiInputBase-input MuiOutlinedInput-input MuiInputBase-inputAdornedStart css-1rgu65m-MuiInputBase-input-MuiOutlinedInput-input"
19751975
id="search-new-input"
1976-
placeholder="Search revision by ID number, author email or bug number"
1976+
placeholder="Search by revision ID, author, bug number and comments"
19771977
type="text"
19781978
value=""
19791979
/>
@@ -2856,10 +2856,10 @@ exports[`Compare Over Time should update base repo, revisions and time-range aft
28562856
</div>
28572857
<input
28582858
aria-invalid="false"
2859-
aria-label="Search revision by ID number, author email or bug number"
2859+
aria-label="Search by revision ID, author, bug number and comments"
28602860
class="MuiInputBase-input MuiOutlinedInput-input MuiInputBase-inputSizeSmall MuiInputBase-inputAdornedStart css-jrmsot-MuiInputBase-input-MuiOutlinedInput-input"
28612861
id="search-new-input"
2862-
placeholder="Search revision by ID number, author email or bug number"
2862+
placeholder="Search by revision ID, author, bug number and comments"
28632863
type="text"
28642864
value=""
28652865
/>

‎src/__tests__/Search/__snapshots__/CompareWithBase.test.tsx.snap‎

Lines changed: 30 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -137,10 +137,10 @@ exports[`Compare With Base renders correctly when there are no results: Initial
137137
</div>
138138
<input
139139
aria-invalid="false"
140-
aria-label="Search base by ID number, author email or bug number"
140+
aria-label="Search by revision ID, author, bug number and comments"
141141
class="MuiInputBase-input MuiOutlinedInput-input MuiInputBase-inputSizeSmall MuiInputBase-inputAdornedStart css-jrmsot-MuiInputBase-input-MuiOutlinedInput-input"
142142
id="search-base-input"
143-
placeholder="Search base by ID number, author email or bug number"
143+
placeholder="Search by revision ID, author, bug number and comments"
144144
type="text"
145145
value=""
146146
/>
@@ -447,10 +447,10 @@ exports[`Compare With Base renders correctly when there are no results: Initial
447447
</div>
448448
<input
449449
aria-invalid="false"
450-
aria-label="Search revision by ID number, author email or bug number"
450+
aria-label="Search by revision ID, author, bug number and comments"
451451
class="MuiInputBase-input MuiOutlinedInput-input MuiInputBase-inputSizeSmall MuiInputBase-inputAdornedStart css-jrmsot-MuiInputBase-input-MuiOutlinedInput-input"
452452
id="search-new-input"
453-
placeholder="Search revision by ID number, author email or bug number"
453+
placeholder="Search by revision ID, author, bug number and comments"
454454
type="text"
455455
value=""
456456
/>
@@ -953,10 +953,10 @@ exports[`Compare With Base should have an edit mode in Results View: After click
953953
</div>
954954
<input
955955
aria-invalid="false"
956-
aria-label="Search base by ID number, author email or bug number"
956+
aria-label="Search by revision ID, author, bug number and comments"
957957
class="MuiInputBase-input MuiOutlinedInput-input MuiInputBase-inputSizeSmall MuiInputBase-inputAdornedStart css-jrmsot-MuiInputBase-input-MuiOutlinedInput-input"
958958
id="search-base-input"
959-
placeholder="Search base by ID number, author email or bug number"
959+
placeholder="Search by revision ID, author, bug number and comments"
960960
type="text"
961961
value=""
962962
/>
@@ -1263,10 +1263,10 @@ exports[`Compare With Base should have an edit mode in Results View: After click
12631263
</div>
12641264
<input
12651265
aria-invalid="false"
1266-
aria-label="Search revision by ID number, author email or bug number"
1266+
aria-label="Search by revision ID, author, bug number and comments"
12671267
class="MuiInputBase-input MuiOutlinedInput-input MuiInputBase-inputSizeSmall MuiInputBase-inputAdornedStart css-jrmsot-MuiInputBase-input-MuiOutlinedInput-input"
12681268
id="search-new-input"
1269-
placeholder="Search revision by ID number, author email or bug number"
1269+
placeholder="Search by revision ID, author, bug number and comments"
12701270
type="text"
12711271
value=""
12721272
/>
@@ -1457,10 +1457,10 @@ exports[`Compare With Base should have an edit mode in Results View: After click
14571457
</div>
14581458
<input
14591459
aria-invalid="false"
1460-
aria-label="Search base by ID number, author email or bug number"
1460+
aria-label="Search by revision ID, author, bug number and comments"
14611461
class="MuiInputBase-input MuiOutlinedInput-input MuiInputBase-inputSizeSmall MuiInputBase-inputAdornedStart css-jrmsot-MuiInputBase-input-MuiOutlinedInput-input"
14621462
id="search-base-input"
1463-
placeholder="Search base by ID number, author email or bug number"
1463+
placeholder="Search by revision ID, author, bug number and comments"
14641464
type="text"
14651465
value=""
14661466
/>
@@ -1767,10 +1767,10 @@ exports[`Compare With Base should have an edit mode in Results View: After click
17671767
</div>
17681768
<input
17691769
aria-invalid="false"
1770-
aria-label="Search revision by ID number, author email or bug number"
1770+
aria-label="Search by revision ID, author, bug number and comments"
17711771
class="MuiInputBase-input MuiOutlinedInput-input MuiInputBase-inputSizeSmall MuiInputBase-inputAdornedStart css-jrmsot-MuiInputBase-input-MuiOutlinedInput-input"
17721772
id="search-new-input"
1773-
placeholder="Search revision by ID number, author email or bug number"
1773+
placeholder="Search by revision ID, author, bug number and comments"
17741774
type="text"
17751775
value=""
17761776
/>
@@ -2148,10 +2148,10 @@ exports[`Compare With Base should have an edit mode in Results View: Initial sta
21482148
</div>
21492149
<input
21502150
aria-invalid="false"
2151-
aria-label="Search base by ID number, author email or bug number"
2151+
aria-label="Search by revision ID, author, bug number and comments"
21522152
class="MuiInputBase-input MuiOutlinedInput-input MuiInputBase-inputSizeSmall MuiInputBase-inputAdornedStart css-jrmsot-MuiInputBase-input-MuiOutlinedInput-input"
21532153
id="search-base-input"
2154-
placeholder="Search base by ID number, author email or bug number"
2154+
placeholder="Search by revision ID, author, bug number and comments"
21552155
type="text"
21562156
value=""
21572157
/>
@@ -2458,10 +2458,10 @@ exports[`Compare With Base should have an edit mode in Results View: Initial sta
24582458
</div>
24592459
<input
24602460
aria-invalid="false"
2461-
aria-label="Search revision by ID number, author email or bug number"
2461+
aria-label="Search by revision ID, author, bug number and comments"
24622462
class="MuiInputBase-input MuiOutlinedInput-input MuiInputBase-inputSizeSmall MuiInputBase-inputAdornedStart css-jrmsot-MuiInputBase-input-MuiOutlinedInput-input"
24632463
id="search-new-input"
2464-
placeholder="Search revision by ID number, author email or bug number"
2464+
placeholder="Search by revision ID, author, bug number and comments"
24652465
type="text"
24662466
value=""
24672467
/>
@@ -2826,10 +2826,10 @@ exports[`Compare With Base should have an edit mode in Results View: after remov
28262826
</div>
28272827
<input
28282828
aria-invalid="false"
2829-
aria-label="Search base by ID number, author email or bug number"
2829+
aria-label="Search by revision ID, author, bug number and comments"
28302830
class="MuiInputBase-input MuiOutlinedInput-input MuiInputBase-inputSizeSmall MuiInputBase-inputAdornedStart css-jrmsot-MuiInputBase-input-MuiOutlinedInput-input"
28312831
id="search-base-input"
2832-
placeholder="Search base by ID number, author email or bug number"
2832+
placeholder="Search by revision ID, author, bug number and comments"
28332833
type="text"
28342834
value=""
28352835
/>
@@ -2970,10 +2970,10 @@ exports[`Compare With Base should have an edit mode in Results View: after remov
29702970
</div>
29712971
<input
29722972
aria-invalid="false"
2973-
aria-label="Search revision by ID number, author email or bug number"
2973+
aria-label="Search by revision ID, author, bug number and comments"
29742974
class="MuiInputBase-input MuiOutlinedInput-input MuiInputBase-inputSizeSmall MuiInputBase-inputAdornedStart css-jrmsot-MuiInputBase-input-MuiOutlinedInput-input"
29752975
id="search-new-input"
2976-
placeholder="Search revision by ID number, author email or bug number"
2976+
placeholder="Search by revision ID, author, bug number and comments"
29772977
type="text"
29782978
value=""
29792979
/>
@@ -3376,10 +3376,10 @@ exports[`Compare With Base should have an edit mode in Results View: after remov
33763376
</div>
33773377
<input
33783378
aria-invalid="false"
3379-
aria-label="Search base by ID number, author email or bug number"
3379+
aria-label="Search by revision ID, author, bug number and comments"
33803380
class="MuiInputBase-input MuiOutlinedInput-input MuiInputBase-inputSizeSmall MuiInputBase-inputAdornedStart css-jrmsot-MuiInputBase-input-MuiOutlinedInput-input"
33813381
id="search-base-input"
3382-
placeholder="Search base by ID number, author email or bug number"
3382+
placeholder="Search by revision ID, author, bug number and comments"
33833383
type="text"
33843384
value=""
33853385
/>
@@ -3686,10 +3686,10 @@ exports[`Compare With Base should have an edit mode in Results View: after remov
36863686
</div>
36873687
<input
36883688
aria-invalid="false"
3689-
aria-label="Search revision by ID number, author email or bug number"
3689+
aria-label="Search by revision ID, author, bug number and comments"
36903690
class="MuiInputBase-input MuiOutlinedInput-input MuiInputBase-inputSizeSmall MuiInputBase-inputAdornedStart css-jrmsot-MuiInputBase-input-MuiOutlinedInput-input"
36913691
id="search-new-input"
3692-
placeholder="Search revision by ID number, author email or bug number"
3692+
placeholder="Search by revision ID, author, bug number and comments"
36933693
type="text"
36943694
value=""
36953695
/>
@@ -4000,10 +4000,10 @@ exports[`Compare With Base should remove the checked revision once X button is c
40004000
</div>
40014001
<input
40024002
aria-invalid="false"
4003-
aria-label="Search base by ID number, author email or bug number"
4003+
aria-label="Search by revision ID, author, bug number and comments"
40044004
class="MuiInputBase-input MuiOutlinedInput-input MuiInputBase-inputAdornedStart css-1rgu65m-MuiInputBase-input-MuiOutlinedInput-input"
40054005
id="search-base-input"
4006-
placeholder="Search base by ID number, author email or bug number"
4006+
placeholder="Search by revision ID, author, bug number and comments"
40074007
type="text"
40084008
value=""
40094009
/>
@@ -4144,10 +4144,10 @@ exports[`Compare With Base should remove the checked revision once X button is c
41444144
</div>
41454145
<input
41464146
aria-invalid="false"
4147-
aria-label="Search revision by ID number, author email or bug number"
4147+
aria-label="Search by revision ID, author, bug number and comments"
41484148
class="MuiInputBase-input MuiOutlinedInput-input MuiInputBase-inputAdornedStart css-1rgu65m-MuiInputBase-input-MuiOutlinedInput-input"
41494149
id="search-new-input"
4150-
placeholder="Search revision by ID number, author email or bug number"
4150+
placeholder="Search by revision ID, author, bug number and comments"
41514151
type="text"
41524152
value=""
41534153
/>
@@ -4566,10 +4566,10 @@ exports[`Compare With Base should remove the checked revision once X button is c
45664566
</div>
45674567
<input
45684568
aria-invalid="false"
4569-
aria-label="Search revision by ID number, author email or bug number"
4569+
aria-label="Search by revision ID, author, bug number and comments"
45704570
class="MuiInputBase-input MuiOutlinedInput-input MuiInputBase-inputAdornedStart css-1rgu65m-MuiInputBase-input-MuiOutlinedInput-input"
45714571
id="search-new-input"
4572-
placeholder="Search revision by ID number, author email or bug number"
4572+
placeholder="Search by revision ID, author, bug number and comments"
45734573
type="text"
45744574
value=""
45754575
/>

0 commit comments

Comments
 (0)