API Optimizations (#3827)

* API view field optimizations, N+1 fix in TermSearchListView, DynamicViewSerializer applied to ProjectLocale

* Update test_views.py

* change locale visibility for LocaleIndividualView

* remove unused request check

* Update pontoon/api/views.py

Co-authored-by: Eemeli Aro <[email protected]>

* tweak conditional logic

* Update pontoon/api/views.py

Co-authored-by: Eemeli Aro <[email protected]>

* tweak set comprehension

* add mixin for request fields, remove code dupes

* remove unnecessary needs_* conditionals

* Update pontoon/api/serializers.py

Co-authored-by: Eemeli Aro <[email protected]>

* Update pontoon/api/serializers.py

Co-authored-by: Eemeli Aro <[email protected]>

---------

Co-authored-by: Eemeli Aro <[email protected]>

Author: functionzz

pontoon/api/serializers.py

@@ -155,7 +155,7 @@ class Meta:
         ]
 
 
-class ProjectLocaleSerializer(TranslationStatsMixin, serializers.ModelSerializer):
+class ProjectLocaleSerializer(TranslationStatsMixin, DynamicFieldsModelSerializer):
     locale = CompactLocaleSerializer(read_only=True)
     project = CompactProjectSerializer(read_only=True)
 
@@ -190,10 +190,6 @@ def get_locales(self, obj):
         return [pl.locale.code for pl in getattr(obj, "fetched_project_locales", [])]
 
     def get_localizations(self, obj):
-        request = self.context.get("request")
-        if not request:
-            return None
-
         project_locales = obj.project_locale.stats_data(project=obj)
         serialized = ProjectLocaleSerializer(project_locales, many=True).data
         return [
@@ -222,10 +218,6 @@ def get_projects(self, obj):
         return [pl.project.slug for pl in getattr(obj, "fetched_project_locales", [])]
 
     def get_localizations(self, obj):
-        request = self.context.get("request")
-        if not request:
-            return None
-
         project_locales = obj.project_locale.stats_data(locale=obj)
         serialized = ProjectLocaleSerializer(project_locales, many=True).data
         return [{k: v for k, v in item.items() if k != "locale"} for item in serialized]
@@ -254,14 +246,10 @@ class Meta:
         ]
 
     def get_translation_text(self, obj):
-        request = self.context.get("request")
-        locale = request.query_params.get("locale") if request else None
-
-        if not locale:
-            return None
+        if hasattr(obj, "filtered_translations") and (ft := obj.filtered_translations):
+            return ft[0].text
 
-        term = obj.translations.filter(locale__code=locale).first()
-        return term.text if term else None
+        return None
 
 
 class TranslationMemorySerializer(DynamicFieldsModelSerializer):
@@ -368,11 +356,6 @@ def __init__(self, *args, **kwargs):
                     self.fields.pop("translations", None)
 
     def get_translations(self, obj):
-        request = self.context.get("request")
-
-        if not request:
-            return None
-
         return TranslationSerializer(
             obj.filtered_translations, many=True, context=self.context
         ).data
@@ -385,11 +368,6 @@ class Meta(EntitySerializer.Meta):
         fields = EntitySerializer.Meta.fields + ["translation"]
 
     def get_translation(self, obj):
-        request = self.context.get("request")
-
-        if not request:
-            return None
-
         translation = (
             obj.filtered_translations[0] if obj.filtered_translations else None
         )

pontoon/api/tests/test_views.py

@@ -940,6 +940,10 @@ def test_terminology_search(django_assert_num_queries):
         code="kg",
         name="Klingon",
     )
+    locale_b = LocaleFactory(
+        code="gs",
+        name="Geonosian",
+    )
     term1 = Term.objects.create(
         text="open",
         part_of_speech="verb",
@@ -952,17 +956,31 @@ def test_terminology_search(django_assert_num_queries):
         definition="Shut or block access",
         usage="Close the door.",
     )
+    term3 = Term.objects.create(
+        text="opened",
+        part_of_speech="verb",
+        definition="Allow access (past tense)",
+        usage="Opened the door.",
+    )
+    term4 = Term.objects.create(
+        text="click",
+        part_of_speech="verb",
+        definition="press",
+        usage="Click the button.",
+    )
 
     TermTranslation.objects.create(term=term1, locale=locale_a, text="odpreti")
     TermTranslation.objects.create(term=term2, locale=locale_a, text="zapreti")
+    TermTranslation.objects.create(term=term3, locale=locale_a, text="odprto")
+    TermTranslation.objects.create(term=term4, locale=locale_b, text="klikni")
 
-    with django_assert_num_queries(5):
+    with django_assert_num_queries(3):
         response = APIClient().get("/api/v2/search/terminology/?text=open&locale=kg")
 
     assert response.status_code == 200
 
     assert response.data == {
-        "count": 1,
+        "count": 2,
         "next": None,
         "previous": None,
         "results": [
@@ -973,7 +991,15 @@ def test_terminology_search(django_assert_num_queries):
                 "translation_text": "odpreti",
                 "usage": "Open the door.",
                 "notes": "",
-            }
+            },
+            {
+                "definition": "Allow access (past tense)",
+                "part_of_speech": "verb",
+                "text": "opened",
+                "translation_text": "odprto",
+                "usage": "Opened the door.",
+                "notes": "",
+            },
         ],
     }