Disabled users should not receive emails (#3870)

Author: functionzz

docs/admin/deployment.rst

@@ -553,7 +553,7 @@ is designed to run daily.
 
 .. code-block:: bash
 
-   ./manage.py send_oboarding_emails
+   ./manage.py send_onboarding_emails
 
 Send Inactive Account Emails
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~

pontoon/messaging/emails.py

@@ -174,7 +174,7 @@ def send_monthly_activity_summary():
     log.info("Start sending Monthly activity summary emails.")
 
     # Get user monthly actions
-    users = User.objects.filter(profile__monthly_activity_summary=True)
+    users = User.objects.filter(is_active=True, profile__monthly_activity_summary=True)
     user_month_actions = _get_monthly_user_actions(users, months_ago=1)
     previous_user_month_actions = _get_monthly_user_actions(users, months_ago=2)
 
@@ -262,7 +262,7 @@ def send_notification_digest(frequency="Daily"):
         start_time = timezone.now() - datetime.timedelta(weeks=1)
 
     users = (
-        User.objects
+        User.objects.filter(is_active=True)
         # Users with the selected notification email frequency
         .filter(profile__notification_email_frequency=frequency)
         # Users subscribed to at least one email notification type

…gement/commands/send_oboarding_emails.py …ement/commands/send_onboarding_emails.pypontoon/messaging/management/commands/send_oboarding_emails.py renamed to pontoon/messaging/management/commands/send_onboarding_emails.py pontoon/messaging/management/commands/send_oboarding_emails.py renamed to pontoon/messaging/management/commands/send_onboarding_emails.py

@@ -13,6 +13,7 @@ def handle(self, *args, **kwargs):
         # Send the 2nd onboarding email to users that have received the 1st email
         # and have joined at least ONBOARDING_EMAIL_2_DELAY days ago.
         users_for_email_2 = User.objects.filter(
+            is_active=True,
             profile__onboarding_email_status=1,
             date_joined__lt=(now() - timedelta(days=settings.ONBOARDING_EMAIL_2_DELAY)),
         )
@@ -22,6 +23,7 @@ def handle(self, *args, **kwargs):
         # Send the 3rd onboarding email to users that have received the 2nd email
         # and have joined at least ONBOARDING_EMAIL_3_DELAY days ago.
         users_for_email_3 = User.objects.filter(
+            is_active=True,
             profile__onboarding_email_status=2,
             date_joined__lt=(now() - timedelta(days=settings.ONBOARDING_EMAIL_3_DELAY)),
         )