Skip to content

Commit 437ec9b

Browse files
authored
Merge pull request #165 from alison985/162_fix_json_url_fetcher
add catching key error & removing data_scanned from url query_runner
2 parents 45aa946 + c0f6df8 commit 437ec9b

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

redash/models.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -682,8 +682,8 @@ def get_latest(cls, data_source, query, max_age=0):
682682
def store_result(cls, org, data_source, query_hash, query, data, run_time, retrieved_at):
683683
try:
684684
data_scanned_information = json.loads(data)['data_scanned']
685-
except (ValueError, TypeError) as e:
686-
data_scanned_information = 'error'
685+
except (ValueError, TypeError, KeyError) as e:
686+
data_scanned_information = ''
687687

688688
query_result = cls(org=org,
689689
query_hash=query_hash,

redash/query_runner/url.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@ def run_query(self, query, user):
5454

5555
response = requests.get(url)
5656
response.raise_for_status()
57-
response.update({'data_scanned':'N/A'})
5857
json_data = response.content.strip()
5958

6059
if not json_data:

0 commit comments

Comments
 (0)