Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timezonechange event (defer). #306

Merged
merged 3 commits into from
Apr 14, 2020
Merged

Add timezonechange event (defer). #306

merged 3 commits into from
Apr 14, 2020

Conversation

dbaron
Copy link
Contributor

@dbaron dbaron commented Apr 9, 2020

Fixes #241.

@dbaron dbaron requested a review from annevk April 9, 2020 23:42
@dbaron dbaron self-assigned this Apr 10, 2020
martinthomson
martinthomson approved these changes Apr 14, 2020
View reviewed changes
Copy link
Member

@martinthomson martinthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found the words a little unclear, but I am OK with either version.

dbaron
dbaron commented Apr 14, 2020
View reviewed changes
@dbaron dbaron merged commit 90f5f89 into mozilla:master Apr 14, 2020
@dbaron
Copy link
Contributor Author

dbaron commented Apr 14, 2020

I took @martinthomson's suggestion and then tweaked the wording a drop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tantek tantek tantek approved these changes

@martinthomson martinthomson martinthomson approved these changes

@annevk annevk annevk approved these changes

Assignees

@dbaron dbaron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

timezonechange event
4 participants
@dbaron @tantek @martinthomson @annevk