Skip to content

Commit 0811e71

Browse files
authored
fix: remove unnecessary tool installs in kenlm build script (#1069)
cmake 4.0 was released recently and its installation in this script is causing its toolchain build to fail. I traced this back a bit and figure out exactly why we're doing it - cmake and the other tools were already installed on this docker image when this script was added. It was probably leftover from some early iteration of my work.
1 parent de07640 commit 0811e71

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

taskcluster/scripts/toolchain/build-kenlm.sh

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,16 +4,7 @@ set -x
44

55
KENLM_DIR=$MOZ_FETCHES_DIR/kenlm-source
66

7-
# TODO: I don't think we actually need the C++ stuff? just the python module
8-
# build_dir=$(mktemp -d)
9-
# cd $build_dir
10-
# cmake $KENLM_DIR -DKENLM_MAX_ORDER=7
11-
# make -j$(nproc)
12-
137
cd $KENLM_DIR
14-
# Install these separately so they will install as wheels.
15-
# Using `--build-option` below disables wheels even for dependencies.
16-
pip install setuptools wheel cmake
178
MAX_ORDER=7 python3 setup.py bdist_wheel
189
find .
1910
cp $KENLM_DIR/dist/kenlm-0.0.0-cp310-cp310-linux_x86_64.whl $UPLOAD_DIR/

0 commit comments

Comments
 (0)