Skip to content

Commit d8bf5aa

Browse files
authored
polish UI for new failure message in error summary box (#7699)
1 parent 88f0322 commit d8bf5aa

File tree

5 files changed

+65
-9
lines changed

5 files changed

+65
-9
lines changed

Diff for: ui/css/failure-summary.css

+7
Original file line numberDiff line numberDiff line change
@@ -21,3 +21,10 @@
2121
/* Override the selector complexity of: "ul.failure-summary-list li .btn-xs" */
2222
font-size: 11px !important;
2323
}
24+
25+
.failure-summary-new-message {
26+
padding: 2px 4px 0;
27+
font-size: 11px;
28+
background-color: var(--failure-bg-color);
29+
color: var(--failure-color);
30+
}

Diff for: ui/css/treeherder-base.css

+5
Original file line numberDiff line numberDiff line change
@@ -50,3 +50,8 @@ kbd {
5050
input[type='checkbox'] {
5151
margin-right: 5px;
5252
}
53+
54+
:root {
55+
--failure-bg-color: #f7c194;
56+
--failure-color: #743603;
57+
}

Diff for: ui/css/treeherder-job-buttons.css

+2-2
Original file line numberDiff line numberDiff line change
@@ -181,8 +181,8 @@
181181

182182
/* Orange, testfailed */
183183
.btn-orange {
184-
background-color: #f7c194;
185-
color: #743603;
184+
background-color: var(--failure-bg-color);
185+
color: var(--failure-color);
186186
}
187187
.btn-orange:hover,
188188
.btn-orange:focus,

Diff for: ui/shared/tabs/failureSummary/FailureSummaryTab.jsx

+5-1
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,11 @@ class FailureSummaryTab extends React.Component {
194194
id="failure-summary-scroll-area"
195195
>
196196
{selectedJob.newFailure > 0 && (
197-
<Button className="btn-orange" outline title="New Test Failure">
197+
<Button
198+
className="failure-summary-new-message"
199+
outline
200+
title="New Test Failure"
201+
>
198202
{selectedJob.newFailure} new failure line(s). First one is
199203
flagged, it might be good to look at all failures in this job.
200204
</Button>

Diff for: yarn.lock

+46-6
Original file line numberDiff line numberDiff line change
@@ -3170,14 +3170,14 @@ [email protected]:
31703170
resolved "https://registry.yarnpkg.com/bytes/-/bytes-3.1.2.tgz#8b0beeb98605adf1b128fa4386403c009e0221a5"
31713171
integrity sha512-/Nf7TyzTx6S3yRJObOAV7956r8cr2+Oj8AC5dt8wSP3BQAoeX58NoHyCU8P8zGkNXStjTSi6fzO6F0pBdcYbEg==
31723172

3173-
3174-
version "17.0.4"
3175-
resolved "https://registry.yarnpkg.com/cacache/-/cacache-17.0.4.tgz#5023ed892ba8843e3b7361c26d0ada37e146290c"
3176-
integrity sha512-Z/nL3gU+zTUjz5pCA5vVjYM8pmaw2kxM7JEiE0fv3w77Wj+sFbi70CrBruUWH0uNcEdvLDixFpgA2JM4F4DBjA==
3173+
3174+
version "17.0.5"
3175+
resolved "https://registry.yarnpkg.com/cacache/-/cacache-17.0.5.tgz#6dbec26c11f1f6a2b558bc11ed3316577c339ebc"
3176+
integrity sha512-Y/PRQevNSsjAPWykl9aeGz8Pr+OI6BYM9fYDNMvOkuUiG9IhG4LEmaYrZZZvioMUEQ+cBCxT0v8wrnCURccyKA==
31773177
dependencies:
31783178
"@npmcli/fs" "^3.1.0"
31793179
fs-minipass "^3.0.0"
3180-
glob "^8.0.1"
3180+
glob "^9.3.1"
31813181
lru-cache "^7.7.1"
31823182
minipass "^4.0.0"
31833183
minipass-collect "^1.0.2"
@@ -5135,7 +5135,17 @@ glob@^7.0.3, glob@^7.1.3, glob@^7.1.4:
51355135
once "^1.3.0"
51365136
path-is-absolute "^1.0.0"
51375137

5138-
glob@^8.0.1, glob@~8.0.3:
5138+
glob@^9.3.1:
5139+
version "9.3.5"
5140+
resolved "https://registry.yarnpkg.com/glob/-/glob-9.3.5.tgz#ca2ed8ca452781a3009685607fdf025a899dfe21"
5141+
integrity sha512-e1LleDykUz2Iu+MTYdkSsuWX8lvAjAcs0Xef0lNIu0S2wOAzuTxCJtcd9S3cijlwYF18EsU3rzb8jPVobxDh9Q==
5142+
dependencies:
5143+
fs.realpath "^1.0.0"
5144+
minimatch "^8.0.2"
5145+
minipass "^4.2.4"
5146+
path-scurry "^1.6.1"
5147+
5148+
glob@~8.0.3:
51395149
version "8.0.3"
51405150
resolved "https://registry.yarnpkg.com/glob/-/glob-8.0.3.tgz#415c6eb2deed9e502c68fa44a272e6da6eeca42e"
51415151
integrity sha512-ull455NHSHI/Y1FqGaaYFaLGkNMMJbavMrEGFXG/PGrg6y7sutWHUHrz6gy6WEBH6akM1M414dWKCNs+IhKdiQ==
@@ -6916,6 +6926,11 @@ lru-cache@^7.7.1:
69166926
resolved "https://registry.yarnpkg.com/lru-cache/-/lru-cache-7.14.1.tgz#8da8d2f5f59827edb388e63e459ac23d6d408fea"
69176927
integrity sha512-ysxwsnTKdAx96aTRdhDOCQfDgbHnt8SK0KY8SEjO0wHinhWOFTESbjVCMPbU1uGXg/ch4lifqx0wfjOawU2+WA==
69186928

6929+
lru-cache@^9.1.1:
6930+
version "9.1.1"
6931+
resolved "https://registry.yarnpkg.com/lru-cache/-/lru-cache-9.1.1.tgz#c58a93de58630b688de39ad04ef02ef26f1902f1"
6932+
integrity sha512-65/Jky17UwSb0BuB9V+MyDpsOtXKmYwzhyl+cOa9XUiI4uV2Ouy/2voFP3+al0BjZbJgMBD8FojMpAf+Z+qn4A==
6933+
69196934
lz-string@^1.4.4:
69206935
version "1.4.4"
69216936
resolved "https://registry.npmjs.org/lz-string/-/lz-string-1.4.4.tgz"
@@ -7123,6 +7138,13 @@ minimatch@^5.0.1, minimatch@~5.1.0:
71237138
dependencies:
71247139
brace-expansion "^2.0.1"
71257140

7141+
minimatch@^8.0.2:
7142+
version "8.0.4"
7143+
resolved "https://registry.yarnpkg.com/minimatch/-/minimatch-8.0.4.tgz#847c1b25c014d4e9a7f68aaf63dedd668a626229"
7144+
integrity sha512-W0Wvr9HyFXZRGIDgCicunpQ299OKXs9RgZfaukz4qAW/pJhcpUfupc9c+OObPOFueNy8VSrZgEmDtk6Kh4WzDA==
7145+
dependencies:
7146+
brace-expansion "^2.0.1"
7147+
71267148
minimist@^1.2.0, minimist@^1.2.5, minimist@^1.2.6:
71277149
version "1.2.7"
71287150
resolved "https://registry.yarnpkg.com/minimist/-/minimist-1.2.7.tgz#daa1c4d91f507390437c6a8bc01078e7000c4d18"
@@ -7163,6 +7185,16 @@ minipass@^4.0.0:
71637185
dependencies:
71647186
yallist "^4.0.0"
71657187

7188+
minipass@^4.2.4:
7189+
version "4.2.8"
7190+
resolved "https://registry.yarnpkg.com/minipass/-/minipass-4.2.8.tgz#f0010f64393ecfc1d1ccb5f582bcaf45f48e1a3a"
7191+
integrity sha512-fNzuVyifolSLFL4NzpF+wEF4qrgqaaKX0haXPQEdQ7NKAN+WecoKMHV09YcuL/DHxrUsYQOK3MiuDf7Ip2OXfQ==
7192+
7193+
"minipass@^5.0.0 || ^6.0.2":
7194+
version "6.0.2"
7195+
resolved "https://registry.yarnpkg.com/minipass/-/minipass-6.0.2.tgz#542844b6c4ce95b202c0995b0a471f1229de4c81"
7196+
integrity sha512-MzWSV5nYVT7mVyWCwn2o7JH13w2TBRmmSqSRCKzTw+lmft9X4z+3wjvs06Tzijo5z4W/kahUCDpRXTF+ZrmF/w==
7197+
71667198
minizlib@^2.1.1:
71677199
version "2.1.2"
71687200
resolved "https://registry.yarnpkg.com/minizlib/-/minizlib-2.1.2.tgz#e90d3466ba209b932451508a11ce3d3632145931"
@@ -7641,6 +7673,14 @@ path-parse@^1.0.6, path-parse@^1.0.7:
76417673
resolved "https://registry.npmjs.org/path-parse/-/path-parse-1.0.7.tgz"
76427674
integrity sha512-LDJzPVEEEPR+y48z93A0Ed0yXb8pAByGWo/k5YYdYgpY2/2EsOsksJrq7lOHxryrVOn1ejG6oAp8ahvOIQD8sw==
76437675

7676+
path-scurry@^1.6.1:
7677+
version "1.9.2"
7678+
resolved "https://registry.yarnpkg.com/path-scurry/-/path-scurry-1.9.2.tgz#90f9d296ac5e37e608028e28a447b11d385b3f63"
7679+
integrity sha512-qSDLy2aGFPm8i4rsbHd4MNyTcrzHFsLQykrtbuGRknZZCBBVXSv2tSCDN2Cg6Rt/GFRw8GoW9y9Ecw5rIPG1sg==
7680+
dependencies:
7681+
lru-cache "^9.1.1"
7682+
minipass "^5.0.0 || ^6.0.2"
7683+
76447684
76457685
version "0.1.7"
76467686
resolved "https://registry.yarnpkg.com/path-to-regexp/-/path-to-regexp-0.1.7.tgz#df604178005f522f15eb4490e7247a1bfaa67f8c"

0 commit comments

Comments
 (0)