Bump eslint-plugin-react from 7.16.0 to 7.37.4 (#8411)

* Bump eslint-plugin-react from 7.16.0 to 7.37.4

Bumps [eslint-plugin-react](https://github.com/jsx-eslint/eslint-plugin-react) from 7.16.0 to 7.37.4.
- [Release notes](https://github.com/jsx-eslint/eslint-plugin-react/releases)
- [Changelog](https://github.com/jsx-eslint/eslint-plugin-react/blob/master/CHANGELOG.md)
- [Commits](jsx-eslint/eslint-plugin-react@v7.16.0...v7.37.4)

---
updated-dependencies:
- dependency-name: eslint-plugin-react
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* increase max asset size by 200kB to allow eslint-plugin-react update

* PropTypes fixes

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Author: Archaeopteryx

Diff for: package.json

@@ -97,7 +97,7 @@
     "eslint-plugin-jest": "27.1.7",
     "eslint-plugin-jsx-a11y": "6.10.2",
     "eslint-plugin-prettier": "4.2.1",
-    "eslint-plugin-react": "7.16.0",
+    "eslint-plugin-react": "7.37.4",
     "fetch-mock": "9.4.0",
     "html-loader": "5.1.0",
     "html-webpack-plugin": "5.6.3",

Diff for: ui/intermittent-failures/BugDetailsView.jsx

@@ -316,25 +316,62 @@ const BugDetailsView = (props) => {
 };
 
 BugDetailsView.propTypes = {
-  location: PropTypes.shape({}).isRequired,
+  location: PropTypes.shape({
+    pathname: PropTypes.string,
+    search: PropTypes.string,
+    state: PropTypes.shape({}),
+    hash: PropTypes.string,
+  }).isRequired,
+  lastLocation: PropTypes.shape({
+    pathname: PropTypes.string,
+    search: PropTypes.string,
+    state: PropTypes.shape({}),
+    hash: PropTypes.string,
+  }).isRequired,
   tree: PropTypes.string.isRequired,
   updateAppState: PropTypes.func,
   updateState: PropTypes.func.isRequired,
   updateHash: PropTypes.func.isRequired,
   startday: PropTypes.string.isRequired,
   failurehash: PropTypes.string.isRequired,
   endday: PropTypes.string.isRequired,
-  tableData: PropTypes.arrayOf(PropTypes.shape({})),
-  graphData: PropTypes.arrayOf(PropTypes.shape({})),
+  tableData: PropTypes.arrayOf(
+    PropTypes.shape({
+      // Define the expected structure of tableData objects here
+      push_time: PropTypes.string,
+      tree: PropTypes.string,
+      revision: PropTypes.string,
+      platform: PropTypes.string,
+      build_type: PropTypes.string,
+      test_suite: PropTypes.string,
+      machine_name: PropTypes.string,
+      job_id: PropTypes.string,
+      lines: PropTypes.arrayOf(PropTypes.string),
+    }),
+  ),
+  graphData: PropTypes.arrayOf(
+    PropTypes.shape({
+      // Define the expected structure of graphData objects here
+      // Example:
+      timestamp: PropTypes.number,
+      value: PropTypes.number,
+    }),
+  ),
   initialParamsSet: PropTypes.bool.isRequired,
   bug: PropTypes.string.isRequired,
   summary: PropTypes.string.isRequired,
   errorMessages: PropTypes.arrayOf(PropTypes.string),
-  lastLocation: PropTypes.shape({}).isRequired,
   tableFailureStatus: PropTypes.string,
   graphFailureStatus: PropTypes.string,
-  uniqueLines: PropTypes.arrayOf(PropTypes.array),
-  uniqueFrequency: PropTypes.shape({}),
+  uniqueLines: PropTypes.arrayOf(PropTypes.arrayOf(PropTypes.string)),
+  uniqueFrequency: PropTypes.shape({
+    // Define the expected structure of uniqueFrequency object here
+    all: PropTypes.arrayOf(
+      PropTypes.shape({
+        count: PropTypes.number,
+      }),
+    ),
+  }),
 };
 
 BugDetailsView.defaultProps = {

Diff for: ui/job-view/details/DetailsPanel.jsx

@@ -436,11 +436,11 @@ DetailsPanel.propTypes = {
   currentRepo: PropTypes.shape({}).isRequired,
   user: PropTypes.shape({}).isRequired,
   resizedHeight: PropTypes.number.isRequired,
-  classificationTypes: PropTypes.arrayOf(PropTypes.object).isRequired,
+  classificationTypes: PropTypes.arrayOf(PropTypes.shape({})).isRequired,
   classificationMap: PropTypes.shape({}).isRequired,
   setPinBoardVisible: PropTypes.func.isRequired,
   isPinBoardVisible: PropTypes.bool.isRequired,
-  pushList: PropTypes.arrayOf(PropTypes.object).isRequired,
+  pushList: PropTypes.arrayOf(PropTypes.shape({})).isRequired,
   selectedJob: PropTypes.shape({}),
 };
 

Diff for: ui/job-view/details/PinBoard.jsx

@@ -698,7 +698,7 @@ PinBoard.propTypes = {
   recalculateUnclassifiedCounts: PropTypes.func.isRequired,
   decisionTaskMap: PropTypes.shape({}).isRequired,
   jobMap: PropTypes.shape({}).isRequired,
-  classificationTypes: PropTypes.arrayOf(PropTypes.object).isRequired,
+  classificationTypes: PropTypes.arrayOf(PropTypes.shape({})).isRequired,
   isLoggedIn: PropTypes.bool.isRequired,
   isStaff: PropTypes.bool.isRequired,
   isPinBoardVisible: PropTypes.bool.isRequired,
@@ -718,7 +718,7 @@ PinBoard.propTypes = {
   failureClassificationComment: PropTypes.string.isRequired,
   selectedJobFull: PropTypes.shape({}),
   email: PropTypes.string,
-  revisionTips: PropTypes.arrayOf(PropTypes.object),
+  revisionTips: PropTypes.arrayOf(PropTypes.shape({})),
 };
 
 PinBoard.defaultProps = {

Diff for: ui/job-view/details/summary/ActionBar.jsx

@@ -543,7 +543,7 @@ ActionBar.propTypes = {
   selectedJobFull: PropTypes.shape({}).isRequired,
   logParseStatus: PropTypes.string.isRequired,
   notify: PropTypes.func.isRequired,
-  jobLogUrls: PropTypes.arrayOf(PropTypes.object),
+  jobLogUrls: PropTypes.arrayOf(PropTypes.shape({})),
   currentRepo: PropTypes.shape({}).isRequired,
   isTryRepo: PropTypes.bool,
   logViewerUrl: PropTypes.string,

Diff for: ui/job-view/details/summary/ClassificationsPanel.jsx

@@ -63,5 +63,5 @@ ClassificationsPanel.propTypes = {
   classification: PropTypes.shape({}).isRequired,
   classificationMap: PropTypes.shape({}).isRequired,
   job: PropTypes.shape({}).isRequired,
-  bugs: PropTypes.arrayOf(PropTypes.object).isRequired,
+  bugs: PropTypes.arrayOf(PropTypes.shape({})).isRequired,
 };

Diff for: ui/job-view/details/summary/LogItem.jsx

@@ -116,7 +116,7 @@ export default function LogItem(props) {
 }
 
 LogItem.propTypes = {
-  logUrls: PropTypes.arrayOf(PropTypes.object).isRequired,
+  logUrls: PropTypes.arrayOf(PropTypes.shape({})).isRequired,
   logViewerUrl: PropTypes.string,
   logViewerFullUrl: PropTypes.string,
 };

Diff for: ui/job-view/details/summary/LogUrls.jsx

@@ -42,7 +42,7 @@ export default function LogUrls(props) {
 }
 
 LogUrls.propTypes = {
-  logUrls: PropTypes.arrayOf(PropTypes.object).isRequired,
+  logUrls: PropTypes.arrayOf(PropTypes.shape({})).isRequired,
   logViewerUrl: PropTypes.string,
   logViewerFullUrl: PropTypes.string,
 };

Diff for: ui/job-view/details/summary/SummaryPanel.jsx

@@ -89,13 +89,13 @@ class SummaryPanel extends React.PureComponent {
 }
 
 SummaryPanel.propTypes = {
-  bugs: PropTypes.arrayOf(PropTypes.object).isRequired,
+  bugs: PropTypes.arrayOf(PropTypes.shape({})).isRequired,
   user: PropTypes.shape({}).isRequired,
   currentRepo: PropTypes.shape({}).isRequired,
   classificationMap: PropTypes.shape({}).isRequired,
   selectedJobFull: PropTypes.shape({}).isRequired,
   latestClassification: PropTypes.shape({}),
-  jobLogUrls: PropTypes.arrayOf(PropTypes.object),
+  jobLogUrls: PropTypes.arrayOf(PropTypes.shape({})),
   jobDetailLoading: PropTypes.bool,
   logParseStatus: PropTypes.string,
   logViewerUrl: PropTypes.string,

Diff for: ui/job-view/details/tabs/AnnotationsTab.jsx

@@ -67,7 +67,7 @@ function RelatedBug(props) {
 
 RelatedBug.propTypes = {
   deleteBug: PropTypes.func.isRequired,
-  bugs: PropTypes.arrayOf(PropTypes.object).isRequired,
+  bugs: PropTypes.arrayOf(PropTypes.shape({})).isRequired,
 };
 
 function TableRow(props) {
@@ -145,7 +145,7 @@ function AnnotationsTable(props) {
 
 AnnotationsTable.propTypes = {
   deleteClassification: PropTypes.func.isRequired,
-  classifications: PropTypes.arrayOf(PropTypes.object).isRequired,
+  classifications: PropTypes.arrayOf(PropTypes.shape({})).isRequired,
   classificationMap: PropTypes.shape({}).isRequired,
 };
 
@@ -248,8 +248,8 @@ class AnnotationsTab extends React.Component {
 
 AnnotationsTab.propTypes = {
   classificationMap: PropTypes.shape({}).isRequired,
-  bugs: PropTypes.arrayOf(PropTypes.object).isRequired,
-  classifications: PropTypes.arrayOf(PropTypes.object).isRequired,
+  bugs: PropTypes.arrayOf(PropTypes.shape({})).isRequired,
+  classifications: PropTypes.arrayOf(PropTypes.shape({})).isRequired,
   recalculateUnclassifiedCounts: PropTypes.func.isRequired,
   notify: PropTypes.func.isRequired,
   selectedJobFull: PropTypes.shape({}).isRequired,

Diff for: ui/job-view/details/tabs/PerfData.jsx

@@ -98,7 +98,7 @@ class PerfData extends React.PureComponent {
 }
 
 PerfData.propTypes = {
-  perfJobDetail: PropTypes.arrayOf(PropTypes.object),
+  perfJobDetail: PropTypes.arrayOf(PropTypes.shape({})),
 };
 
 PerfData.defaultProps = {

Diff for: ui/job-view/details/tabs/PerformanceTab.jsx

@@ -278,8 +278,8 @@ class PerformanceTab extends React.PureComponent {
 
 PerformanceTab.propTypes = {
   repoName: PropTypes.string.isRequired,
-  jobDetails: PropTypes.arrayOf(PropTypes.object),
-  perfJobDetail: PropTypes.arrayOf(PropTypes.object),
+  jobDetails: PropTypes.arrayOf(PropTypes.shape({})),
+  perfJobDetail: PropTypes.arrayOf(PropTypes.shape({})),
   revision: PropTypes.string,
   decisionTaskMap: PropTypes.shape({}).isRequired,
 };

Diff for: ui/job-view/details/tabs/SideBySide.jsx

@@ -186,7 +186,7 @@ class SideBySide extends React.PureComponent {
 }
 
 SideBySide.propTypes = {
-  jobDetails: PropTypes.arrayOf(PropTypes.object),
+  jobDetails: PropTypes.arrayOf(PropTypes.shape({})),
 };
 
 SideBySide.defaultProps = {

Diff for: ui/job-view/details/tabs/SideBySideVideo.jsx

@@ -77,5 +77,5 @@ export default class SideBySideVideo extends React.Component {
 }
 
 SideBySideVideo.propTypes = {
-  videos: PropTypes.arrayOf(PropTypes.object).isRequired,
+  videos: PropTypes.arrayOf(PropTypes.shape({})).isRequired,
 };

Diff for: ui/job-view/details/tabs/TabsPanel.jsx

@@ -286,19 +286,19 @@ class TabsPanel extends React.Component {
 
 TabsPanel.propTypes = {
   classificationMap: PropTypes.shape({}).isRequired,
-  jobDetails: PropTypes.arrayOf(PropTypes.object).isRequired,
+  jobDetails: PropTypes.arrayOf(PropTypes.shape({})).isRequired,
   jobArtifactsLoading: PropTypes.bool,
-  classifications: PropTypes.arrayOf(PropTypes.object).isRequired,
+  classifications: PropTypes.arrayOf(PropTypes.shape({})).isRequired,
   togglePinBoardVisibility: PropTypes.func.isRequired,
   isPinBoardVisible: PropTypes.bool.isRequired,
   pinnedJobs: PropTypes.shape({}).isRequired,
-  bugs: PropTypes.arrayOf(PropTypes.object).isRequired,
+  bugs: PropTypes.arrayOf(PropTypes.shape({})).isRequired,
   clearSelectedJob: PropTypes.func.isRequired,
   selectedJobFull: PropTypes.shape({}).isRequired,
   currentRepo: PropTypes.shape({}).isRequired,
-  perfJobDetail: PropTypes.arrayOf(PropTypes.object),
+  perfJobDetail: PropTypes.arrayOf(PropTypes.shape({})),
   jobRevision: PropTypes.string,
-  jobLogUrls: PropTypes.arrayOf(PropTypes.object),
+  jobLogUrls: PropTypes.arrayOf(PropTypes.shape({})),
   logParseStatus: PropTypes.string,
   logViewerFullUrl: PropTypes.string,
   taskId: PropTypes.string.isRequired,

Diff for: ui/job-view/headerbars/ActiveFilters.jsx

@@ -258,10 +258,10 @@ class ActiveFilters extends React.Component {
 
 ActiveFilters.propTypes = {
   filterModel: PropTypes.shape({}).isRequired,
-  filterBarFilters: PropTypes.arrayOf(PropTypes.object).isRequired,
+  filterBarFilters: PropTypes.arrayOf(PropTypes.shape({})).isRequired,
   isFieldFilterVisible: PropTypes.bool.isRequired,
   toggleFieldFilterVisible: PropTypes.func.isRequired,
-  classificationTypes: PropTypes.arrayOf(PropTypes.object).isRequired,
+  classificationTypes: PropTypes.arrayOf(PropTypes.shape({})).isRequired,
   router: PropTypes.shape({}).isRequired,
   clearSelectedJob: PropTypes.func.isRequired,
 };

Diff for: ui/job-view/headerbars/NotificationsMenu.jsx

@@ -106,7 +106,7 @@ class NotificationsMenu extends React.Component {
 }
 
 NotificationsMenu.propTypes = {
-  storedNotifications: PropTypes.arrayOf(PropTypes.object).isRequired,
+  storedNotifications: PropTypes.arrayOf(PropTypes.shape({})).isRequired,
   clearStoredNotifications: PropTypes.func.isRequired,
 };
 

Diff for: ui/job-view/headerbars/PrimaryNavBar.jsx

@@ -106,7 +106,7 @@ PrimaryNavBar.propTypes = {
   setCurrentRepoTreeStatus: PropTypes.func.isRequired,
   toggleFieldFilterVisible: PropTypes.func.isRequired,
   filterModel: PropTypes.shape({}).isRequired,
-  repos: PropTypes.arrayOf(PropTypes.object).isRequired,
+  repos: PropTypes.arrayOf(PropTypes.shape({})).isRequired,
   serverChanged: PropTypes.bool.isRequired,
   user: PropTypes.shape({}).isRequired,
   duplicateJobsVisible: PropTypes.bool.isRequired,

Diff for: ui/job-view/headerbars/ReposMenu.jsx

@@ -100,5 +100,5 @@ export default function ReposMenu(props) {
 }
 
 ReposMenu.propTypes = {
-  repos: PropTypes.arrayOf(PropTypes.object).isRequired,
+  repos: PropTypes.arrayOf(PropTypes.shape({})).isRequired,
 };

Diff for: ui/job-view/headerbars/SecondaryNavBar.jsx

@@ -400,7 +400,7 @@ SecondaryNavBar.propTypes = {
   updateButtonClick: PropTypes.func.isRequired,
   serverChanged: PropTypes.bool.isRequired,
   filterModel: PropTypes.shape({}).isRequired,
-  repos: PropTypes.arrayOf(PropTypes.object).isRequired,
+  repos: PropTypes.arrayOf(PropTypes.shape({})).isRequired,
   setCurrentRepoTreeStatus: PropTypes.func.isRequired,
   allUnclassifiedFailureCount: PropTypes.number.isRequired,
   recalculateUnclassifiedCounts: PropTypes.func.isRequired,

Diff for: ui/job-view/pushes/FuzzyJobFinder.jsx

@@ -316,8 +316,8 @@ FuzzyJobFinder.propTypes = {
   notify: PropTypes.func.isRequired,
   toggle: PropTypes.func.isRequired,
   decisionTaskId: PropTypes.string,
-  jobList: PropTypes.arrayOf(PropTypes.object),
-  filteredJobList: PropTypes.arrayOf(PropTypes.object),
+  jobList: PropTypes.arrayOf(PropTypes.shape({})),
+  filteredJobList: PropTypes.arrayOf(PropTypes.shape({})),
   currentRepo: PropTypes.shape({}).isRequired,
 };
 

Diff for: ui/job-view/pushes/JobsAndGroups.jsx

@@ -84,7 +84,7 @@ export default class JobsAndGroups extends React.Component {
 }
 
 JobsAndGroups.propTypes = {
-  groups: PropTypes.arrayOf(PropTypes.object).isRequired,
+  groups: PropTypes.arrayOf(PropTypes.shape({})).isRequired,
   repoName: PropTypes.string.isRequired,
   filterModel: PropTypes.shape({}).isRequired,
   filterPlatformCb: PropTypes.func.isRequired,

Diff for: ui/job-view/pushes/PushHeader.jsx

@@ -364,7 +364,7 @@ PushHeader.propTypes = {
   expandAllPushGroups: PropTypes.func.isRequired,
   notificationSupported: PropTypes.bool.isRequired,
   getAllShownJobs: PropTypes.func.isRequired,
-  selectedRunnableJobs: PropTypes.arrayOf(PropTypes.object).isRequired,
+  selectedRunnableJobs: PropTypes.arrayOf(PropTypes.shape({})).isRequired,
   collapsed: PropTypes.bool.isRequired,
   notify: PropTypes.func.isRequired,
   jobCounts: PropTypes.shape({}).isRequired,

Diff for: ui/job-view/pushes/PushJobs.jsx

@@ -159,7 +159,7 @@ PushJobs.propTypes = {
   runnableVisible: PropTypes.bool.isRequired,
   duplicateJobsVisible: PropTypes.bool.isRequired,
   groupCountsExpanded: PropTypes.bool.isRequired,
-  platforms: PropTypes.arrayOf(PropTypes.object).isRequired,
+  platforms: PropTypes.arrayOf(PropTypes.shape({})).isRequired,
   filterModel: PropTypes.shape({}).isRequired,
 };
 

Diff for: ui/job-view/pushes/PushList.jsx

@@ -212,7 +212,7 @@ class PushList extends React.Component {
 PushList.propTypes = {
   repoName: PropTypes.string.isRequired,
   filterModel: PropTypes.shape({}).isRequired,
-  pushList: PropTypes.arrayOf(PropTypes.object).isRequired,
+  pushList: PropTypes.arrayOf(PropTypes.shape({})).isRequired,
   fetchPushes: PropTypes.func.isRequired,
   pollPushes: PropTypes.func.isRequired,
   updateRange: PropTypes.func.isRequired,

Diff for: ui/perfherder/alerts/AlertTableRow.jsx

@@ -1,5 +1,3 @@
-/* eslint-disable react/no-did-update-set-state */
-
 import React from 'react';
 import PropTypes from 'prop-types';
 import { Button, FormGroup, Input, Label } from 'reactstrap';

Diff for: ui/perfherder/alerts/AlertsView.jsx

@@ -1,4 +1,3 @@
-/* eslint-disable react/no-did-update-set-state */
 import React from 'react';
 import PropTypes from 'prop-types';
 import { Alert, Container } from 'reactstrap';

Diff for: ui/perfherder/alerts/AlertsViewControls.jsx

@@ -36,7 +36,7 @@ export default class AlertsViewControls extends React.Component {
       this.alertsRef = new Array(alertsLength)
         .fill(null)
         .map(() => React.createRef());
-      // eslint-disable-next-line react/no-did-update-set-state
+
       this.setState({
         currentAlert: -1,
         alertsLength,

Diff for: ui/perfherder/compare/CompareTableControls.jsx

@@ -1,4 +1,3 @@
-/* eslint-disable react/no-did-update-set-state */
 import React from 'react';
 import PropTypes from 'prop-types';
 import { Container, Row } from 'reactstrap';

Diff for: ui/perfherder/graphs/GraphsView.jsx

@@ -74,7 +74,6 @@ class GraphsView extends React.Component {
       loading !== true &&
       location.search !== prevProps.location.search
     ) {
-      // eslint-disable-next-line react/no-did-update-set-state
       this.setState({
         testData: [],
       });