Skip to content

Commit 36b9526

Browse files
committed
Show proper Windows download link based on architecture
1 parent f605e65 commit 36b9526

6 files changed

Lines changed: 34 additions & 2 deletions

File tree

media/css/cms/pages/flare26-channels.css

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -176,6 +176,19 @@ ul.download-list strong {
176176
display: block !important;
177177
}
178178

179+
.windows .force-win64 .os_win,
180+
.windows .force-win64-aarch64 .os_win {
181+
display: none !important;
182+
}
183+
184+
.windows .force-win64 .os_win64 {
185+
display: block !important;
186+
}
187+
188+
.windows .force-win64-aarch64 .os_win64-aarch64 {
189+
display: block !important;
190+
}
191+
179192
/* add spacing between displayed buttons */
180193
.download-list {
181194
display: grid;

media/css/protocol/components/_download-button.scss

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,19 @@ ul.download-list {
101101
display: block !important;
102102
}
103103

104+
.windows .force-win64 .os_win,
105+
.windows .force-win64-aarch64 .os_win {
106+
display: none !important;
107+
}
108+
109+
.windows .force-win64 .os_win64 {
110+
display: block !important;
111+
}
112+
113+
.windows .force-win64-aarch64 .os_win64-aarch64 {
114+
display: block !important;
115+
}
116+
104117
// add spacing between displayed buttons
105118
.download-list {
106119
display: grid;

springfield/firefox/templates/firefox/includes/download-button.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@
6161
{# ESR download buttons to display on unsupported systems: issue 13317 #}
6262
{% include 'firefox/includes/download-unsupported.html' %}
6363
{% endif %}
64-
<ul class="download-list fl-download-list">
64+
<ul class="download-list fl-download-list{%if force_arch %} force-{{ force_arch }}{% endif %}">
6565
{% for plat in builds %}
6666
<li class="os_{{ plat.os }}{% if plat.arch %} {{ plat.arch }}{% endif %}">
6767
<a class="download-link button {{ button_class }} fl-button mzp-c-button mzp-t-product ga-product-download"

springfield/firefox/templates/firefox/installer-help.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ <h1 class="mzp-c-callout-title">{{ ftl('installer-help-page-title') }}</h1>
5757
<section class="installer-channel-card mzp-c-card mzp-c-card-extra-small">
5858
<img src="{{ static(channel_logo) }}" alt="{{ ftl('installer-help-firefox-release-title') }}" width="347" height="64">
5959
<div class="mzp-c-card-content">
60-
{{ download_firefox(installer_channel, platform='desktop', force_direct=True, force_full_installer=True, locale=installer_lang, button_class='mzp-t-md', alt_copy=ftl('download-button-download-now')) }}
60+
{{ download_firefox(installer_channel, platform='desktop', force_direct=True, force_full_installer=True, locale=installer_lang, button_class='mzp-t-md', alt_copy=ftl('download-button-download-now'), force_arch=installer_arch) }}
6161
</div>
6262
</section>
6363
{% else %}

springfield/firefox/templatetags/helpers.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,7 @@ def download_firefox(
114114
button_class="mzp-t-xl",
115115
locale_in_transition=False,
116116
download_location=None,
117+
force_arch=None,
117118
):
118119
"""Output a "download firefox" button.
119120
@@ -171,6 +172,7 @@ def download_firefox(
171172
"button_class": button_class,
172173
"download_location": download_location,
173174
"fluent_l10n": ctx["fluent_l10n"],
175+
"force_arch": force_arch,
174176
}
175177

176178
html = render_to_string("firefox/includes/download-button.html", data, request=ctx["request"])

springfield/firefox/views.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,9 +64,13 @@ def get_context_data(self, **kwargs):
6464
ctx = super().get_context_data(**kwargs)
6565
installer_lang = self.request.GET.get("installer_lang", None)
6666
installer_channel = self.request.GET.get("channel", None)
67+
installer_arch = self.request.GET.get("installer_arch", None)
6768
ctx["installer_lang"] = None
6869
ctx["installer_channel"] = None
6970

71+
if installer_arch is not None:
72+
ctx["installer_arch"] = {"1": "win", "2": "win64", "3": "win64-aarch64"}[installer_arch]
73+
7074
if installer_lang and installer_lang in firefox_desktop.languages:
7175
ctx["installer_lang"] = installer_lang
7276

0 commit comments

Comments
 (0)