Ensure stale essential data is refreshed

This applies to all except auto-download pages. On those pages, we
can assume the user clicked to download from the preceding page, and
the preceding page set all necessary attribution data.

This change also removes fallback values in python code because we
cannot reliably know if marketing data is allowed at this point.

Author: maureenlholland

media/js/base/download-attribution/download-attribution-init.es6.js

@@ -8,10 +8,8 @@ import DownloadAttribution from './download-attribution.es6';
 
 DownloadAttribution.applyAttributionDataToLinks();
 
-if (
-    document.documentElement.hasAttribute(
-        'data-stub-attribution-campaign-force'
-    )
-) {
-    DownloadAttribution.initEssential();
-}
+// We always want to refresh the essential data
+// to avoid an outdated download experience
+// If there's new essential data, update
+// If there's no essential data, remove
+DownloadAttribution.initEssential();

media/js/base/download-attribution/download-attribution.es6.js

@@ -754,6 +754,8 @@ const DownloadAttribution = {
             DownloadAttribution.COOKIE_MARKETING_RAW_ID
         );
 
+        // We have last touch essential attribution to avoid a stale download experience
+        // REMOVE essential data if it is no longer applicable
         if (Object.keys(essential).length === 0) {
             if (marketing) {
                 // remove essential only
@@ -801,6 +803,16 @@ const DownloadAttribution = {
         }
 
         if (isConsentGranted) {
+            // We have first touch marketing attribution
+            // DO NOT UPDATE if we have existing marketing data
+            if (
+                DownloadAttribution.getRawCookie(
+                    DownloadAttribution.COOKIE_MARKETING_RAW_ID
+                )
+            ) {
+                return;
+            }
+
             if (!DownloadAttribution.withinAttributionRate()) {
                 return;
             }

media/js/firefox/download/auto-download.es6.js

@@ -156,7 +156,7 @@ function onTimeout() {
     beginFirefoxDownload();
 }
 
-// Force cookie update if there is essential data to add
+// Force cookie update before download if there is essential data to add
 if (
     Mozilla.DownloadAttribution !== undefined &&
     document.documentElement.hasAttribute(
@@ -172,6 +172,7 @@ if (
     timeout = setTimeout(onTimeout, 2000);
     Mozilla.DownloadAttribution.initEssential();
 } else {
+    // Otherwise, we can assume an existing cookie has latest data
     beginFirefoxDownload();
 }
 

springfield/firefox/views.py

@@ -114,20 +114,23 @@ def stub_attribution_code(request):
         else:
             codes[name] = default_value
 
-    if codes["source"] == "(not set)" and "referrer" in data:
-        try:
-            domain = urlparse(data["referrer"]).netloc
-            if domain and STUB_VALUE_RE.match(domain):
-                codes["source"] = domain
-                codes["medium"] = "referral"
-                has_value = True
-        except Exception:
-            # any problems and we should just ignore it
-            pass
-
-    if not has_value:
-        codes["source"] = "www.firefox.com"
-        codes["medium"] = "(none)"
+    # We are not going to provide fallbacks because we may not have marketing data consent
+    # Consent checks are in JS, so we will rely on what is provided through JS only
+    if not waffle.switch("ENABLE_ATTRIBUTION_REFACTOR"):
+        if codes["source"] == "(not set)" and "referrer" in data:
+            try:
+                domain = urlparse(data["referrer"]).netloc
+                if domain and STUB_VALUE_RE.match(domain):
+                    codes["source"] = domain
+                    codes["medium"] = "referral"
+                    has_value = True
+            except Exception:
+                # any problems and we should just ignore it
+                pass
+
+        if not has_value:
+            codes["source"] = "www.firefox.com"
+            codes["medium"] = "(none)"
 
     code_data = sign_attribution_codes(codes)
     if code_data: