Addressed feedback from PR #257

Author: mpatfield

CHANGELOG.md

@@ -2,7 +2,7 @@
 
 All notable changes to homebridge-dummy will be documented in this file.
 
-## 1.5.17-beta.1 ()
+## 1.5.17-beta.2 ()
 
 ### Added
 - 'Simulate Duration' option to enable auto-shutoff for [`Valves`](https://github.com/mpatfield/homebridge-easy-mqtt/wiki/Valve) that do not have duration topics
@@ -11,6 +11,9 @@ All notable changes to homebridge-dummy will be documented in this file.
 ### Fixed
 - Potential crash on launch
 
+### Notes
+Please consider giving this plugin a ⭐️ on [GitHub](https://github.com/mpatfield/homebridge-easy-mqtt) if you're finding it useful!
+
 ## 1.5.16 (2026-05-25)
 
 ### Added

config.schema.template.json

@@ -202,12 +202,12 @@
             "minimumDuration": {
               "type": "integer",
               "title": "${config.title.minimumDuration}",
-              "minimum": 5
+              "minimum": 1
             },
             "maximumDuration": {
               "type": "integer",
               "title": "${config.title.maximumDuration}",
-              "minimum": 5
+              "minimum": 1
             },
             "simulateDuration": {
               "type": "boolean",

package-lock.json

@@ -4,7 +4,7 @@
   "displayName": "Homebridge Easy MQTT",
   "description": "Homebridge plugin for MQTT devices",
   "type": "module",
-  "version": "1.5.17-beta.1",
+  "version": "1.5.17-beta.2",
   "homepage": "https://github.com/mpatfield/homebridge-easy-mqtt#readme",
   "repository": {
     "type": "git",

package.json

@@ -37,8 +37,8 @@ export abstract class Common<C extends Assertable> {
   public teardown() {
     if (this.timeout !== undefined && this.timeoutCallback !== undefined) {
       this.log.warning(strings.autoReset.teardown, this.name);
-      clearTimeout(this.timeout);
       this.timeoutCallback();
+      this.stopTimeout();
     }
   }
 
@@ -553,9 +553,7 @@ export abstract class Common<C extends Assertable> {
       this.logIfDesired(strings.autoReset.reset);
     }
 
-    clearTimeout(this.timeout);
-    this.timeout = undefined;
-    this.timeoutCallback = undefined;
+    this.stopTimeout();
 
     if (config === undefined) {
 
@@ -602,6 +600,12 @@ export abstract class Common<C extends Assertable> {
     this.logIfDesired(string, config.time.toString());
   }
 
+  protected stopTimeout() {
+    clearTimeout(this.timeout);
+    this.timeout = undefined;
+    this.timeoutCallback = undefined;
+  }
+
   protected logIfDesired(message: string, ...parameters: string[]): void;
   protected logIfDesired(level: LogType, message: string, ...parameters: string[]): void;
   protected logIfDesired(levelOrMessage: LogType | string, ...rest: string[]) {

src/accessory/abstract/common.ts

@@ -58,7 +58,7 @@ export class ValveAccessory extends BaseAccessory<ValveConfig> {
         dependency.log.warning(strings.valve.durationTopicsIgnored, this.name, `(${durationTopics.join(', ')})`);
       }
 
-      this.setupTopicless(HKCharacteristicKey.SetDuration, minimumDuration)?.setProps( {
+      this.setupTopicless(HKCharacteristicKey.SetDuration, minimumDuration, ()=>{})?.setProps( {
         minValue: minimumDuration,
         maxValue: maximumDuration,
       });
@@ -98,8 +98,13 @@ export class ValveAccessory extends BaseAccessory<ValveConfig> {
 
   override onUpdate(key: HKCharacteristicKey, value: CharacteristicValue, logString: string | undefined = undefined): boolean {
 
-    if (this.simulateDuration && key === HKCharacteristicKey.InUse && value === this.Characteristic.InUse.IN_USE) {
-      this.startTimerSimulator();
+    if (this.simulateDuration && key === HKCharacteristicKey.InUse) {
+
+      if (value === this.Characteristic.InUse.IN_USE) {
+        this.startTimerSimulator();
+      } else if (value === this.Characteristic.InUse.NOT_IN_USE) {
+        this.stopTimerSimulator();
+      }
     }
 
     return super.onUpdate(key, value, logString);
@@ -112,7 +117,7 @@ export class ValveAccessory extends BaseAccessory<ValveConfig> {
     }
 
     const remainingSeconds = (this.durationFinishTime - Date.now()) / SECOND;
-    return Math.max(0, remainingSeconds);
+    return Math.max(0, Math.ceil(remainingSeconds));
   }
 
   private startTimerSimulator() {
@@ -150,6 +155,12 @@ export class ValveAccessory extends BaseAccessory<ValveConfig> {
     this.onUpdateNumeric(HKCharacteristicKey.RemainingDuration, duration);
   }
 
+  private stopTimerSimulator() {
+    this.durationFinishTime = undefined;
+    this.onUpdateNumeric(HKCharacteristicKey.RemainingDuration, 0);
+    this.stopTimeout();
+  }
+
   private toValveTypeCV(value: ValveType | undefined): CharacteristicValue {
 
     if (value === undefined) {