Release: consolidate remaining changes

Author: mpieniak01

README.md

@@ -70,6 +70,11 @@ python -m pc_client.main
 
 📚 **[Full Documentation](docs/README.md)** - Complete documentation and guides
 
+### Localization & Translation Status
+- **English UI coverage**: all `/web/*.html` screens now rely on `web/assets/i18n.js` keys, the Polish strings have English fallbacks, and the chat/chat-pc/control/system scripts no longer declare duplicate helpers.
+- **Verification**: run `node scripts/check_i18n.mjs` to ensure every key includes an English value, and `pytest` (inside `.venv`) covers the back-end regressions tied to UI rendering.
+- **Notes**: run `?lang=en` against `view`, `control`, `navigation`, `system`, `models`, `project`, `assistant`, `chat`, `chat-pc`, `google_home`, `mode`, and `providers` to keep translations in sync.
+
 ### Quick Links
 
 - **[Quick Start Guide](docs/QUICKSTART.md)** - Get started quickly

docs/README.md

@@ -65,6 +65,11 @@ Full instructions: [QUICKSTART.md](QUICKSTART.md)
 ### Management
 - **[SERVICE_AND_RESOURCE_MANAGEMENT.md](SERVICE_AND_RESOURCE_MANAGEMENT.md)** - Operations, monitoring, troubleshooting
 
+### Localization & Translation
+- **Screens in English**: Every `/web/*.html` view now uses `data-i18n` bindings and the shared dictionary (`web/assets/i18n.js`), so the `/view`, `/control`, `/navigation`, `/system`, `/models`, `/project`, `/assistant`, `/chat`, `/chat-pc`, `/google_home`, `/mode`, and `/providers` pages display correctly when `?lang=en`.
+- **Dictionary guard**: `scripts/check_i18n.mjs` parses the JS dictionary at runtime and fails if any key lacks an English entry.
+- **Validation**: Activating `.venv` (`source .venv/bin/activate`) and running `pytest` ensures the Playwright UIs and related back-end APIs remain stable after these translation updates.
+
 ### API Specifications
 - **[api-specs/](api-specs/)** - Detailed REST endpoint specifications
   - [api-specs/README.md](api-specs/README.md) - API overview

docs_pl/README.md

@@ -65,6 +65,11 @@ Pełna instrukcja: [SZYBKI_START.md](SZYBKI_START.md)
 ### Zarządzanie
 - **[ZARZADZANIE_USLUGAMI_I_ZASOBAMI.md](ZARZADZANIE_USLUGAMI_I_ZASOBAMI.md)** - Operacje, monitoring, troubleshooting
 
+### Lokalizacja i Tłumaczenia
+- **Ekrany po angielsku**: Każdy widok `/web/*.html` korzysta z `data-i18n` oraz `web/assets/i18n.js`, więc `/view`, `/control`, `/navigation`, `/system`, `/models`, `/project`, `/assistant`, `/chat`, `/chat-pc`, `/google_home`, `/mode` i `/providers` działają poprawnie po ustawieniu `?lang=en`.
+- **Kontrola słownika**: Skrypt `scripts/check_i18n.mjs` analizuje `web/assets/i18n.js` i raportuje brakujące wpisy `en`.
+- **Testy**: Aktywuj środowisko `.venv` (`source .venv/bin/activate`) i uruchom `pytest`, aby zweryfikować, że Playwright i backend znoszą zmiany z tłumaczeniami.
+
 ### Specyfikacje API
 - **[api-specs/](api-specs/)** - Szczegółowe specyfikacje endpointów REST
   - [api-specs/README.md](api-specs/README.md) - Przegląd API

docs_pl/_to_do/000_nowa-funkcja-x.md

@@ -0,0 +1,30 @@
+# Zadanie #151: Nowa Funkcja X
+
+**Status:** :hourglass_flowing_sand: W trakcie
+**Link:** https://github.com/mpieniak01/rider-pc/issues/151
+**Autor:** Nieprzypisane
+
+## Cel
+(brak opisu)
+
+## Plan Realizacji
+- [ ] Analiza
+- [ ] Implementacja
+- [ ] Testy
+
+## Audyt środowiska / req
+
+### Stan repozytorium
+- `git status -sb` → `## main...origin/main` z lokalnym diffem ograniczonym do tego req (`D docs_pl/_to_do/151_nowa-funkcja-x.md`, `?? docs_pl/_to_do/000_nowa-funkcja-x.md`).
+
+### Środowisko wykonawcze
+- System bazowy: Ubuntu 24.04.3 LTS (`lsb_release -a`), Docker CLI 28.2.2 – dostępne tylko stare `docker-compose 1.29.2`, polecenie `docker compose` nie istnieje.
+- Python: `python` nie jest zmapowany; dostępny `python3 3.12.3` oraz `pip 24.0`. Skrypty wywołujące `python` wymagają aliasu lub instalacji `python-is-python3`.
+- Node toolchain: `node 18.19.1`, `npm 9.2.0`. Lokalne `node_modules` istnieją, ale brak możliwości weryfikacji aktualności pakietów offline.
+- `pip list --outdated` i `npm outdated` kończą się błędami sieciowymi (`EAI_AGAIN`, brak DNS do PyPI/npm) – audyt wersji zależy od odblokowania dostępu do rejestrów.
+
+### Co trzeba zaktualizować / „podbić stos”
+- Doinstalować Compose v2 (plugin `docker compose`) lub aliasować polecenia z Makefile/dokumentacji na `docker-compose`, aby pipeline Dockera był zgodny z bieżącą składnią.
+- Zapewnić alias `python`/`pip` (np. `sudo apt install python-is-python3`) i odświeżyć wirtualne środowiska `.venv` oraz `node_modules`, bo projekt nie był aktualizowany od miesięcy.
+- Po odblokowaniu sieci uruchomić `npm outdated`, `npm audit`, `pip list --outdated`, `pip-audit` i zaktualizować kluczowe zależności (`fastapi`, `uvicorn`, `redis`, `celery`, `torch`, `stylelint`, `ollama`, `prometheus-client`, itp.) pod Python 3.12.
+- Zweryfikować `requirements*.txt` i `package-lock.json` vs. realne środowisko; możliwe, że wersje (np. `grpcio`, `protobuf`, modele vision/audio) wymagają rewizji przed wdrożeniem nowej funkcji X.

docs_pl/_to_do/160_nowa-funkcja-y.md

@@ -0,0 +1,13 @@
+# Zadanie #160: Nowa Funkcja Y
+
+**Status:** :hourglass_flowing_sand: W trakcie
+**Link:** https://github.com/mpieniak01/rider-pc/issues/160
+**Autor:** Nieprzypisane
+
+## Cel
+Opis zadania testowego
+
+## Plan Realizacji
+- [ ] Analiza
+- [ ] Implementacja
+- [ ] Testy

pc_client/adapters/git_adapter.py

@@ -91,7 +91,7 @@ def invalidate_cache(self) -> None:
         self._cache = {}
         self._cache_ts = 0
 
-    async def _run_command(self, *args: str) -> Tuple[int, str, str]:
+    async def _run_command(self, *args: str) -> Tuple[Optional[int], str, str]:
         """
         Run an async subprocess command.
 
@@ -116,6 +116,11 @@ async def _run_command(self, *args: str) -> Tuple[int, str, str]:
             logger.error("Failed to execute command %s: %s", " ".join(args), e)
             return -1, "", str(e)
 
+    @staticmethod
+    def _normalize_returncode(returncode: Optional[int]) -> int:
+        """Normalize return codes coming from subprocess (None -> -1)."""
+        return returncode if returncode is not None else -1
+
     async def _is_in_git_repo(self) -> bool:
         """
         Check if current directory is inside a git repository.
@@ -131,7 +136,8 @@ async def _is_in_git_repo(self) -> bool:
             cmd = ["git", "-C", self._repo_path, "rev-parse", "--git-dir"]
 
         returncode, _, _ = await self._run_command(*cmd)
-        return returncode == 0
+        rc = self._normalize_returncode(returncode)
+        return rc == 0
 
     async def get_current_branch(self) -> str:
         """
@@ -148,8 +154,9 @@ async def get_current_branch(self) -> str:
             cmd = ["git", "-C", self._repo_path, "rev-parse", "--abbrev-ref", "HEAD"]
 
         returncode, stdout, stderr = await self._run_command(*cmd)
+        rc = self._normalize_returncode(returncode)
 
-        if returncode != 0:
+        if rc != 0:
             logger.warning("Failed to get current branch: %s", stderr or stdout)
             return "unknown"
 
@@ -170,8 +177,9 @@ async def get_current_commit(self) -> str:
             cmd = ["git", "-C", self._repo_path, "rev-parse", "--short", "HEAD"]
 
         returncode, stdout, stderr = await self._run_command(*cmd)
+        rc = self._normalize_returncode(returncode)
 
-        if returncode != 0:
+        if rc != 0:
             logger.warning("Failed to get current commit: %s", stderr or stdout)
             return "unknown"
 
@@ -192,8 +200,9 @@ async def is_dirty(self) -> bool:
             cmd = ["git", "-C", self._repo_path, "status", "--porcelain"]
 
         returncode, stdout, _ = await self._run_command(*cmd)
+        rc = self._normalize_returncode(returncode)
 
-        if returncode != 0:
+        if rc != 0:
             return False
 
         # If there's any output, the repo is dirty
@@ -214,8 +223,9 @@ async def get_last_commit_message(self) -> str:
             cmd = ["git", "-C", self._repo_path, "log", "-1", "--pretty=%B"]
 
         returncode, stdout, stderr = await self._run_command(*cmd)
+        rc = self._normalize_returncode(returncode)
 
-        if returncode != 0:
+        if rc != 0:
             logger.warning("Failed to get last commit message: %s", stderr or stdout)
             return ""
 
@@ -281,8 +291,9 @@ async def get_local_branches(self) -> List[str]:
             cmd = ["git", "-C", self._repo_path, "branch", "--format=%(refname:short)"]
 
         returncode, stdout, stderr = await self._run_command(*cmd)
+        rc = self._normalize_returncode(returncode)
 
-        if returncode != 0:
+        if rc != 0:
             logger.warning("Failed to get local branches: %s", stderr or stdout)
             return []
 
@@ -313,8 +324,9 @@ async def checkout_branch(self, name: str) -> Tuple[bool, str]:
             cmd = ["git", "-C", self._repo_path, "checkout", name.strip()]
 
         returncode, stdout, stderr = await self._run_command(*cmd)
+        rc = self._normalize_returncode(returncode)
 
-        if returncode != 0:
+        if rc != 0:
             error = stderr or stdout or "Nieznany błąd"
             logger.warning("Failed to checkout branch %s: %s", name, error)
             return False, error
@@ -350,8 +362,9 @@ async def create_branch(self, name: str, base: str = "main") -> Tuple[bool, str]
             cmd = ["git", "-C", self._repo_path, "checkout", "-b", name.strip(), base.strip()]
 
         returncode, stdout, stderr = await self._run_command(*cmd)
+        rc = self._normalize_returncode(returncode)
 
-        if returncode != 0:
+        if rc != 0:
             error = stderr or stdout or "Nieznany błąd"
             logger.warning("Failed to create branch %s: %s", name, error)
             return False, error
@@ -396,8 +409,9 @@ async def add_file(self, path: str) -> Tuple[bool, str]:
             cmd = ["git", "-C", self._repo_path, "add", path.strip()]
 
         returncode, stdout, stderr = await self._run_command(*cmd)
+        rc = self._normalize_returncode(returncode)
 
-        if returncode != 0:
+        if rc != 0:
             error = stderr or stdout or "Nieznany błąd"
             logger.warning("Failed to add file %s: %s", path, error)
             return False, error
@@ -425,8 +439,9 @@ async def commit(self, message: str) -> Tuple[bool, str]:
             cmd = ["git", "-C", self._repo_path, "commit", "-m", message.strip()]
 
         returncode, stdout, stderr = await self._run_command(*cmd)
+        rc = self._normalize_returncode(returncode)
 
-        if returncode != 0:
+        if rc != 0:
             error = stderr or stdout or "Nieznany błąd"
             logger.warning("Failed to commit: %s", error)
             return False, error

pc_client/adapters/github_adapter.py

@@ -171,7 +171,7 @@ async def get_open_issues(
         try:
             client = await self._get_client()
             url = f"{self.BASE_URL}/repos/{self._owner}/{self._repo}/issues"
-            params = {
+            params: Dict[str, str | int] = {
                 "state": "open",
                 "per_page": min(max(1, limit), 100),
                 "sort": "updated",

pc_client/adapters/mock_rest_adapter.py

@@ -7,7 +7,7 @@
 import copy
 import logging
 import time
-from typing import Any, Dict, Optional, Tuple
+from typing import Any, Dict, Optional, Tuple, cast
 
 logger = logging.getLogger(__name__)
 
@@ -33,23 +33,27 @@ def __init__(
         self.timeout = timeout
         logger.info("MockRestAdapter initialized (TEST MODE)")
         now = time.time()
-        self._control_state = {
+        self._control_state: Dict[str, Any] = {
             "present": True,
             "mode": "auto",
             "tracking": {"mode": "none", "enabled": False, "target": None},
             "navigator": {"active": False, "strategy": "standard", "state": "idle"},
             "camera": {"vision_enabled": True, "on": True, "res": [1280, 720]},
         }
-        self._ai_mode = {"mode": "pc_offload", "available_modes": ["pc_offload", "local"], "changed_ts": now - 120}
-        self._provider_state = {
+        self._ai_mode: Dict[str, Any] = {
+            "mode": "pc_offload",
+            "available_modes": ["pc_offload", "local"],
+            "changed_ts": now - 120,
+        }
+        self._provider_state: Dict[str, Any] = {
             "domains": {
                 "vision": {"mode": "pc", "status": "ready", "changed_ts": now - 300, "reason": "mock"},
                 "voice": {"mode": "local", "status": "ready", "changed_ts": now - 600, "reason": "mock"},
                 "text": {"mode": "pc", "status": "ready", "changed_ts": now - 30, "reason": "sync"},
             },
             "pc_health": {"reachable": True, "status": "ok", "latency_ms": 12.4},
         }
-        self._provider_health = {
+        self._provider_health: Dict[str, Dict[str, Any]] = {
             "vision": {"status": "ok", "latency_ms": 11.2, "success_rate": 0.99, "last_check": now - 5},
             "voice": {"status": "warn", "latency_ms": 32.5, "success_rate": 0.93, "last_check": now - 15},
             "text": {"status": "ok", "latency_ms": 8.7, "success_rate": 0.98, "last_check": now - 9},
@@ -72,13 +76,13 @@ def __init__(
                 "yaw": 0.2,
             },
         ]
-        self._remote_models = [
+        self._remote_models: list[Dict[str, Any]] = [
             {"name": "pi-vision-prod", "category": "vision", "type": "onnx", "format": "onnx", "size_mb": 32.1},
             {"name": "pi-asr-lo", "category": "voice_asr", "type": "whisper", "format": "en", "size_mb": 42.4},
             {"name": "pi-tts-hi", "category": "voice_tts", "type": "piper", "format": "onnx", "size_mb": 48.9},
             {"name": "pi-utils", "category": "unknown", "type": "custom", "format": "bin", "size_mb": 12.3},
         ]
-        self._services = [
+        self._services: list[Dict[str, Any]] = [
             {
                 "unit": "rider-cam-preview.service",
                 "desc": "Camera preview pipeline",
@@ -115,7 +119,7 @@ def __init__(
                 "enabled": "enabled",
             },
         ]
-        self._logic_blueprints = [
+        self._logic_blueprints: list[Dict[str, Any]] = [
             {
                 "name": "s0_manual",
                 "scenario": "S0",
@@ -141,13 +145,15 @@ def __init__(
                 "default_active": False,
             },
         ]
-        self._feature_state = {bp["name"]: bool(bp.get("default_active")) for bp in self._logic_blueprints}
-        self._home_state = {
+        self._feature_state: Dict[str, bool] = {
+            bp["name"]: bool(bp.get("default_active")) for bp in self._logic_blueprints
+        }
+        self._home_state: Dict[str, Any] = {
             "authenticated": True,
             "profile": {"email": "mock-user@rider.ai", "name": "Mock User"},
             "scopes": ["homegraph", "cloud-control"],
         }
-        self._home_devices = [
+        self._home_devices: list[Dict[str, Any]] = [
             {
                 "name": "devices/light/living-room",
                 "type": "action.devices.types.LIGHT",
@@ -360,9 +366,8 @@ async def get_providers_state(self) -> Dict[str, Any]:
     async def patch_provider(self, domain: str, payload: Dict[str, Any]) -> Dict[str, Any]:
         """Return success for provider update."""
         target = str(payload.get("target", "local")).lower()
-        state = self._provider_state.setdefault("domains", {}).setdefault(
-            domain, {"mode": "local", "status": "local_only", "changed_ts": None}
-        )
+        domains = cast(Dict[str, Dict[str, Any]], self._provider_state.setdefault("domains", {}))
+        state = domains.setdefault(domain, {"mode": "local", "status": "local_only", "changed_ts": None})
         state["mode"] = target
         state["status"] = "pc_active" if target == "pc" else "local_only"
         state["changed_ts"] = time.time()
@@ -556,27 +561,32 @@ async def post_home_command(self, payload: Dict[str, Any]) -> Dict[str, Any]:
         device = next((d for d in self._home_devices if d.get("name") == device_id), None)
         if not device:
             return {"ok": False, "error": "device_not_found"}
-        traits = device.setdefault("traits", {})
+        traits = cast(Dict[str, Dict[str, Any]], device.setdefault("traits", {}))
+
+        def _trait_bucket(name: str) -> Dict[str, Any]:
+            return cast(Dict[str, Any], traits.setdefault(name, {}))
+
         if command == "action.devices.commands.OnOff":
-            traits.setdefault("sdm.devices.traits.OnOff", {})["on"] = bool(params.get("on"))
+            _trait_bucket("sdm.devices.traits.OnOff")["on"] = bool(params.get("on"))
         elif command == "action.devices.commands.BrightnessAbsolute":
-            traits.setdefault("sdm.devices.traits.Brightness", {})["brightness"] = int(params.get("brightness", 0))
+            _trait_bucket("sdm.devices.traits.Brightness")["brightness"] = int(params.get("brightness", 0))
         elif command == "action.devices.commands.ColorAbsolute":
-            traits.setdefault("sdm.devices.traits.ColorSetting", {})["color"] = params.get("color", {})
+            _trait_bucket("sdm.devices.traits.ColorSetting")["color"] = params.get("color", {})
         elif command == "action.devices.commands.ThermostatTemperatureSetpoint":
-            traits.setdefault("sdm.devices.traits.ThermostatTemperatureSetpoint", {}).update(params)
+            _trait_bucket("sdm.devices.traits.ThermostatTemperatureSetpoint").update(params)
         elif command == "action.devices.commands.StartStop":
-            traits.setdefault("sdm.devices.traits.StartStop", {}).update(
+            _trait_bucket("sdm.devices.traits.StartStop").update(
                 {"isRunning": bool(params.get("start")), "isPaused": False}
             )
         elif command == "action.devices.commands.PauseUnpause":
-            traits.setdefault("sdm.devices.traits.StartStop", {}).update({"isPaused": bool(params.get("pause"))})
+            _trait_bucket("sdm.devices.traits.StartStop").update({"isPaused": bool(params.get("pause"))})
         elif command == "action.devices.commands.Dock":
-            traits.setdefault("sdm.devices.traits.Dock", {})["lastDockTs"] = time.time()
+            _trait_bucket("sdm.devices.traits.Dock")["lastDockTs"] = time.time()
         return {"ok": True, "device": device_id, "command": command}
 
     async def post_home_auth(self) -> Dict[str, Any]:
         """Simulate successful Google auth."""
         self._home_state["authenticated"] = True
-        self._home_state.setdefault("profile", {})["updated_at"] = time.time()
+        profile = cast(Dict[str, Any], self._home_state.setdefault("profile", {}))
+        profile["updated_at"] = time.time()
         return {"ok": True, "profile": self._home_state.get("profile")}

pc_client/adapters/rest_adapter.py

@@ -38,7 +38,7 @@ def __init__(
         self.timeout = timeout
 
         # Initialize httpx client based on secure mode
-        client_kwargs = {"timeout": timeout}
+        client_kwargs: Dict[str, Any] = {"timeout": timeout}
 
         if secure_mode:
             if mtls_cert_path and mtls_key_path and mtls_ca_path: