hwdec_d3d11egl: EGL_EXT_device_query is client extension #11142
Conversation
| const char *exts = eglQueryString(egl_display, EGL_EXTENSIONS); | ||
| if (!gl_check_extension(exts, "EGL_ANGLE_d3d_share_handle_client_buffer") || | ||
| !gl_check_extension(exts, "EGL_ANGLE_stream_producer_d3d_texture") || | ||
| !(gl_check_extension(gl->extensions, "GL_OES_EGL_image_external_essl3") || | ||
| gl->es == 200) || | ||
| !gl_check_extension(exts, "EGL_EXT_device_query") || | ||
| !(gl_check_extension(client_exts, "EGL_EXT_device_query") || | ||
| gl_check_extension(exts, "EGL_EXT_device_query")) || |
There was a problem hiding this comment.
if its a client extension why keep the second check?
There was a problem hiding this comment.
If I understand the comments in #10212 correctly, before November 2020 ANGLE exposed this in the old location, while current binaries like the one I just tested this with (https://github.com/google/gfbuild-angle/releases/tag/github%2Fgoogle%2Fgfbuild-angle%2Ff810e998993290f049bbdad4fae975e4867100ad) expose it in the new location.
This PR seems to attempt to support both ages of libraries.
edit: My slight personal opinion is that since it's already been two years and the new location seems to be the technically correct one, we might as well switch to supporting the new version only at this point?
There was a problem hiding this comment.
supporting old version is trivial work. some users may use outdated angle provided by framework(eg. qt?)
There was a problem hiding this comment.
This seems to have gotten completely lost but given that's been yet another two years, I think only supporting the new location at this point is the way to go.
close #10212