-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCS/options: altered spdif passthrough warning #12072
base: master
Are you sure you want to change the base?
Conversation
I think the warning is still applicable, but partially. |
Would agree that in most cases passthrough should not be encouraged. |
I don't have any opinion on this change in general, but it says |
Co-authored-by: sfan5 <[email protected]>
Sorry, dont know about the current state of DCA decoder, if it shoud still referred to as 'new' or if it is not needed anymore. |
It's not like that sentence becomes invalid when the new isn't there anymore. I don't see any value in it being there, even if the decoder is still recent enough to be considered new, and by removing it now there is no need to do so in the future. |
In general it is not recommended to use passthrough, since HDMI | ||
supports uncompressed multichannel PCM, and mpv supports lossless | ||
DTS-HD decoding via FFmpeg's new DCA decoder (based on libdcadec). | ||
|
||
Nevertheless there are some cases in which it must be activated for | ||
correct playback, such as 3D audio formats like Dolby Atmos or DTS:X. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general it is not recommended to use passthrough, since HDMI | |
supports uncompressed multichannel PCM, and mpv supports lossless | |
DTS-HD decoding via FFmpeg's new DCA decoder (based on libdcadec). | |
Nevertheless there are some cases in which it must be activated for | |
correct playback, such as 3D audio formats like Dolby Atmos or DTS:X. | |
Generally, passthrough is not recommended because HDMI supports | |
uncompressed multichannel PCM, and mpv supports lossless DTS-HD decoding. | |
However, there are cases where passthrough must be enabled for proper | |
playback, particularly for 3D audio formats such as Dolby Atmos or DTS:X. |
How about something like this? Particularity mentioning "new" (now almost 10 years old) decoder is not important detail.
The warning for not using spdif passthrough, does not take 3D audio formats into account.
Only when having up to 8 channel sources, decoding to PCM is feasible. With 3D audio formats like Atmos, Auro, ... passthrough needs to be used.