vf_vapoursynth: copy side data (Dolby Vision, etc) from the source frame #12593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasper93
reviewed
Oct 7, 2023
kasper93
reviewed
Oct 7, 2023
|
any chance? |
|
Better to manually @sfan5 @Dudemanguy . |
sfan5
reviewed
Mar 13, 2024
| { | ||
| VSMap *map = p->vsapi->getFramePropsRW(frame); | ||
| if (!map) | ||
| return -1; | ||
| p->vsapi->propSetInt(map, "_DurationNum", dur_num, 0); | ||
| p->vsapi->propSetInt(map, "_DurationDen", dur_den, 0); | ||
| p->vsapi->propSetInt(map, "__frameno", frameno, 0); | ||
| if(img->dovi && img->dovi->size) | ||
| p->vsapi->propSetData(map,"_DoVi", img->dovi->data, img->dovi->size, 0); |
|
FYI, After merge of #13458 |
sfan5
added
priority:stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #10438.
Continue from 10884, now copying everything and using existing function.
2nd commit is about passing DoVi data into Vapoursynth, so the script could take care in some way (which is required for any interpolation filter, for example).