diff --git a/.gitignore b/.gitignore index 7c49b2d..d27bd82 100644 --- a/.gitignore +++ b/.gitignore @@ -7,6 +7,7 @@ ## Directory-based project format: .idea/ +.vscode/ # if you remove the above rule, at least ignore the following: # User-specific stuff: diff --git a/README.md b/README.md index 74cd2d4..38bd29a 100644 --- a/README.md +++ b/README.md @@ -25,7 +25,7 @@ documents into XML using the ```bash > cd nifi-edireader-processor > mvn package -> cp nifi-edireader-nar/target/nifi-edireader-nar-1.9.2.nar /NIFI_INSTALL/lib/ +> cp nifi-edireader-nar/target/nifi-edireader-nar-2.0.0.nar /NIFI_INSTALL/lib/ ``` ## License diff --git a/nifi-edireader-nar/pom.xml b/nifi-edireader-nar/pom.xml index d5dfa53..54f7617 100644 --- a/nifi-edireader-nar/pom.xml +++ b/nifi-edireader-nar/pom.xml @@ -5,12 +5,12 @@ nifi-edireader-bundle org.apache.nifi - 1.9.2 + 2.0.0 4.0.0 nifi-edireader-nar - 1.9.2 + 2.0.0 nar true @@ -21,7 +21,7 @@ org.apache.nifi nifi-edireader-processors - 1.9.2 + 2.0.0 diff --git a/nifi-edireader-processors/pom.xml b/nifi-edireader-processors/pom.xml index a5c0f0b..6258c05 100644 --- a/nifi-edireader-processors/pom.xml +++ b/nifi-edireader-processors/pom.xml @@ -5,7 +5,7 @@ nifi-edireader-bundle org.apache.nifi - 1.9.2 + 2.0.0 4.0.0 @@ -31,7 +31,7 @@ com.berryworks edireader - 5.4.17 + 5.6.5 org.apache.nifi diff --git a/nifi-edireader-processors/src/main/java/org/apache/nifi/processors/edireader/EdiToXML.java b/nifi-edireader-processors/src/main/java/org/apache/nifi/processors/edireader/EdiToXML.java index 6860c89..edecf71 100644 --- a/nifi-edireader-processors/src/main/java/org/apache/nifi/processors/edireader/EdiToXML.java +++ b/nifi-edireader-processors/src/main/java/org/apache/nifi/processors/edireader/EdiToXML.java @@ -2,7 +2,6 @@ import com.berryworks.edireader.EDIParserFactory; -import com.berryworks.edireader.error.MissingMandatoryElementException; import org.apache.nifi.annotation.documentation.CapabilityDescription; import org.apache.nifi.annotation.documentation.Tags; import org.apache.nifi.components.PropertyDescriptor; diff --git a/nifi-edireader-processors/src/main/java/org/apache/nifi/processors/edireader/split/Interchange.java b/nifi-edireader-processors/src/main/java/org/apache/nifi/processors/edireader/split/Interchange.java index 0f47c56..d1d809e 100644 --- a/nifi-edireader-processors/src/main/java/org/apache/nifi/processors/edireader/split/Interchange.java +++ b/nifi-edireader-processors/src/main/java/org/apache/nifi/processors/edireader/split/Interchange.java @@ -53,7 +53,7 @@ private static String generateFileName(String elementSeparator, String isa, Stri public Map writer() { - Map results = new HashMap(); + Map results = new HashMap<>(); transactions.forEach(t -> { diff --git a/nifi-edireader-processors/src/main/java/org/apache/nifi/processors/edireader/split/Splitter.java b/nifi-edireader-processors/src/main/java/org/apache/nifi/processors/edireader/split/Splitter.java index 15925e3..586c414 100644 --- a/nifi-edireader-processors/src/main/java/org/apache/nifi/processors/edireader/split/Splitter.java +++ b/nifi-edireader-processors/src/main/java/org/apache/nifi/processors/edireader/split/Splitter.java @@ -88,6 +88,7 @@ public List splitData(ProcessSession session, FlowFile flowFile) throw break; } } + scanner.close(); return flowFiles; } diff --git a/nifi-edireader-processors/src/test/java/org/apache/nifi/processors/edireader/EdiToJSONTest.java b/nifi-edireader-processors/src/test/java/org/apache/nifi/processors/edireader/EdiToJSONTest.java index e6c69df..23467e9 100644 --- a/nifi-edireader-processors/src/test/java/org/apache/nifi/processors/edireader/EdiToJSONTest.java +++ b/nifi-edireader-processors/src/test/java/org/apache/nifi/processors/edireader/EdiToJSONTest.java @@ -10,7 +10,6 @@ import java.io.File; import java.io.IOException; import java.nio.charset.Charset; -import java.nio.file.Files; import java.nio.file.Paths; import java.util.List; @@ -68,10 +67,13 @@ public void testOnTriggerPrettyJson() throws IOException { MockFlowFile result = results.get(0); - byte[] bytes = Files.readAllBytes(Paths.get(output)); + // Change line ending of the output file to be inline with the operating system line separator + File outputFile = FileUtils.getFile(output); + String outputContent = FileUtils.readFileToString(outputFile, Charset.defaultCharset()); + outputContent = outputContent.replaceAll("\n", System.getProperty("line.separator")); // Test attributes and content - result.assertContentEquals(bytes); + result.assertContentEquals(outputContent.getBytes(Charset.defaultCharset())); } @Test @@ -91,10 +93,13 @@ public void testOnTriggerPrettyJsonDouble() throws IOException { MockFlowFile result = results.get(0); - byte[] bytes = Files.readAllBytes(Paths.get(output)); + // Change line ending of the output file to be inline with the operating system line separator + File outputFile = FileUtils.getFile(output); + String outputContent = FileUtils.readFileToString(outputFile, Charset.defaultCharset()); + outputContent = outputContent.replaceAll("\n", System.getProperty("line.separator")); // Test attributes and content - result.assertContentEquals(bytes); + result.assertContentEquals(outputContent.getBytes(Charset.defaultCharset())); } @Test @@ -117,7 +122,7 @@ public void testOnTriggerBadEdiFile() throws IOException { } private String ediFile(String fileName) { - return this.getClass().getResource(fileName).getPath(); + return new File(this.getClass().getResource(fileName).getPath()).toPath().toString(); } } diff --git a/nifi-edireader-processors/src/test/java/org/apache/nifi/processors/edireader/EdiToXMLTest.java b/nifi-edireader-processors/src/test/java/org/apache/nifi/processors/edireader/EdiToXMLTest.java index 7564467..abefa52 100644 --- a/nifi-edireader-processors/src/test/java/org/apache/nifi/processors/edireader/EdiToXMLTest.java +++ b/nifi-edireader-processors/src/test/java/org/apache/nifi/processors/edireader/EdiToXMLTest.java @@ -66,6 +66,6 @@ public void testOnTriggerError() throws IOException { } private String ediFile(String fileName) { - return this.getClass().getResource(fileName).getPath(); + return new File(this.getClass().getResource(fileName).getPath()).toPath().toString(); } } diff --git a/nifi-edireader-processors/src/test/java/org/apache/nifi/processors/edireader/SplitEdiTest.java b/nifi-edireader-processors/src/test/java/org/apache/nifi/processors/edireader/SplitEdiTest.java index d9d0414..c513dad 100644 --- a/nifi-edireader-processors/src/test/java/org/apache/nifi/processors/edireader/SplitEdiTest.java +++ b/nifi-edireader-processors/src/test/java/org/apache/nifi/processors/edireader/SplitEdiTest.java @@ -87,6 +87,6 @@ public void testOnTriggerFailure() throws IOException { } private String ediFile(String fileName) { - return this.getClass().getResource(fileName).getPath(); + return new File(this.getClass().getResource(fileName).getPath()).toPath().toString(); } } diff --git a/pom.xml b/pom.xml index deeb728..c6cb51a 100644 --- a/pom.xml +++ b/pom.xml @@ -16,7 +16,7 @@ nifi-edireader-bundle - 1.9.2 + 2.0.0 pom