Merge pull request #13784 from donmccurdy/feat-gltfloader-normalscale-inverty

mrdoob · web-flow · commit 606b9d1c01a7 · 2018-04-05T19:33:16.000-07:00
GLTFLoader: Invert normalScale.y, not normalScale.x.
diff --git a/examples/js/loaders/GLTFLoader.js b/examples/js/loaders/GLTFLoader.js
@@ -2042,7 +2042,7 @@ THREE.GLTFLoader = ( function () {
 			// https://github.com/KhronosGroup/glTF/tree/master/specification/2.0#materialnormaltexture
 			if ( material.normalScale ) {
 
-				material.normalScale.x = - material.normalScale.x;
+				material.normalScale.y = - material.normalScale.y;
 
 			}
 

Original file line number	Diff line number	Diff line change
`@@ -2042,7 +2042,7 @@ THREE.GLTFLoader = ( function () {`
`2042`	`2042`	`// https://github.com/KhronosGroup/glTF/tree/master/specification/2.0#materialnormaltexture`
`2043`	`2043`	`if ( material.normalScale ) {`
`2044`	`2044`
`2045`		`- material.normalScale.x = - material.normalScale.x;`
	`2045`	`+ material.normalScale.y = - material.normalScale.y;`
`2046`	`2046`
`2047`	`2047`	`}`
`2048`	`2048`