feat: improve play command by extracting the m4a audio instead of re-encoding it into mp3 & and also both play and video command now cache the files and if the user requested for the audio or video id it'll use that instead of downloading it over again

Author: mrepol742

src/commands/play.ts

@@ -18,6 +18,15 @@ export const info = {
   cooldown: 5000,
 };
 
+const fileExists = async (filePath: string) => {
+  try {
+    await fs.promises.access(filePath, fs.constants.F_OK);
+    return true;
+  } catch {
+    return false;
+  }
+};
+
 async function search(yt: Innertube, query: string) {
   log.info("Play", `Searching for ${query}`);
   const results = await yt.music.search(query, { type: "song" });
@@ -65,6 +74,17 @@ export default async function play(msg: Message) {
 
   await msg.react("🔍");
 
+  const tempDir = "./.temp";
+  await fs.promises.mkdir(tempDir, { recursive: true });
+  const tempPath = path.join(tempDir, `${audio.id}.mp3`);
+  const savePath = path.join(tempDir, `${audio.id}.m4a`);
+
+  if (await fileExists(savePath)) {
+    const media = MessageMedia.fromFilePath(savePath);
+    await msg.reply(media);
+    return;
+  }
+
   const stream = await yt.download(audio.id, {
     type: "video+audio",
     quality: "best",
@@ -81,9 +101,6 @@ export default async function play(msg: Message) {
 
   await msg.react("⬇️");
 
-  const tempDir = "./.temp";
-  await fs.promises.mkdir(tempDir, { recursive: true });
-  const tempPath = path.join(tempDir, `${audio.id}.mp3`);
   let writeStream = fs.createWriteStream(tempPath);
 
   for await (const chunk of Utils.streamToIterable(stream)) {
@@ -100,17 +117,7 @@ export default async function play(msg: Message) {
   const chat = await msg.getChat();
   chat.sendStateRecording();
 
-  await execPromise(
-    `ffmpeg -y -i "${tempPath}" -vn -ar 44100 -ac 2 -b:a 192k "${tempPath}.mp3"`,
-  );
-
-  const media = MessageMedia.fromFilePath(`${tempPath}.mp3`);
-  await msg.reply(media, undefined, {
-    caption: audio.title,
-  });
-
-  Promise.all([
-    fs.promises.unlink(tempPath),
-    fs.promises.unlink(`${tempPath}.mp3`),
-  ]);
+  await execPromise(`ffmpeg -y -i "${tempPath}" -vn -c:a copy "${savePath}"`);
+  const media = MessageMedia.fromFilePath(savePath);
+  Promise.all([msg.reply(media), fs.promises.unlink(tempPath)]);
 }

src/commands/video.ts

@@ -14,6 +14,15 @@ export const info = {
   cooldown: 5000,
 };
 
+const fileExists = async (filePath: string) => {
+  try {
+    await fs.promises.access(filePath, fs.constants.F_OK);
+    return true;
+  } catch {
+    return false;
+  }
+};
+
 async function search(yt: Innertube, query: string) {
   log.info("Video", `Searching for ${query}`);
   const results = await yt.search(query, { type: "video" });
@@ -57,6 +66,18 @@ export default async function (msg: Message) {
 
   await msg.react("🔍");
 
+  const tempDir = "./.temp";
+  await fs.promises.mkdir(tempDir, { recursive: true });
+  const tempPath = path.join(tempDir, `${video.video_id}.mp4`);
+
+  if (await fileExists(tempPath)) {
+    const media = MessageMedia.fromFilePath(tempPath);
+    await msg.reply(media, undefined, {
+      caption: video.title.text,
+    });
+    return;
+  }
+
   const stream = await yt.download(video.video_id, {
     type: "video+audio",
     quality: "best",
@@ -73,9 +94,6 @@ export default async function (msg: Message) {
 
   await msg.react("⬇️");
 
-  const tempDir = "./.temp";
-  await fs.promises.mkdir(tempDir, { recursive: true });
-  const tempPath = path.join(tempDir, `${video.video_id}.mp4`);
   let writeStream = fs.createWriteStream(tempPath);
 
   for await (const chunk of Utils.streamToIterable(stream)) {
@@ -92,6 +110,4 @@ export default async function (msg: Message) {
   await msg.reply(media, undefined, {
     caption: video.title.text,
   });
-
-  fs.promises.unlink(tempPath);
 }