feat: improve play and video command

Author: mrepol742

src/commands/play.ts

@@ -29,7 +29,7 @@ export default async function play(msg: Message) {
   const yt = await Innertube.create({
     cache: new UniversalCache(false),
     generate_session_locally: true,
-    player_id: "0004de42"
+    player_id: "0004de42",
   });
   const search = await yt.music.search(query, { type: "song" });
 
@@ -42,7 +42,7 @@ export default async function play(msg: Message) {
   // Only allow audios shorter than 10 minutes (600 seconds)
   if (audio.length && audio.length.seconds > 600) {
     await msg.reply(
-      "Sorry, only videos shorter than 10 minutes can be downloaded.",
+      "Sorry, it seems like im not able to get any search results.",
     );
     return;
   }
@@ -62,18 +62,24 @@ export default async function play(msg: Message) {
 
   const tempDir = "./.temp";
   await fs.promises.mkdir(tempDir, { recursive: true });
-  const tempPath = path.join(tempDir, `${audio.id}.mp4`);
+  const tempPath = path.join(tempDir, `${audio.id}.mp3`);
   let writeStream = fs.createWriteStream(tempPath);
 
   for await (const chunk of Utils.streamToIterable(stream)) {
     writeStream.write(chunk);
   }
 
+  await new Promise<void>((resolve, reject) => {
+    writeStream.end();
+    writeStream.on("finish", resolve);
+    writeStream.on("error", reject);
+  });
+
   await execPromise(
     `ffmpeg -y -i "${tempPath}" -vn -ar 44100 -ac 2 -b:a 192k "${tempPath}.mp3"`,
   );
 
-  const audioBuffer = fs.readFileSync(tempPath + ".mp3");
+  const audioBuffer = fs.readFileSync(`${tempPath}.mp3`);
   const media = new MessageMedia(
     "audio/mpeg",
     audioBuffer.toString("base64"),
@@ -84,5 +90,8 @@ export default async function play(msg: Message) {
     caption: audio.title,
   });
 
-  Promise.all([fs.promises.unlink(tempPath), fs.promises.unlink(tempPath)]);
+  Promise.all([
+    fs.promises.unlink(tempPath),
+    fs.promises.unlink(`${tempPath}.mp3`),
+  ]);
 }

src/commands/video.ts

@@ -27,15 +27,17 @@ export default async function (msg: Message) {
   }
 
   const yt = await Innertube.create({
-   cache: new UniversalCache(false),
-   generate_session_locally: true,
-   player_id: "0004de42",
+    cache: new UniversalCache(false),
+    generate_session_locally: true,
+    player_id: "0004de42",
   });
   const search = await yt.search(query, { type: "video" });
 
   const video = search.results[0];
   if (!video.video_id) {
-    await msg.reply("Unable to find resources for the given query.");
+    await msg.reply(
+      "Sorry, it seems like im not able to get any search results.",
+    );
     return;
   }
 
@@ -69,11 +71,13 @@ export default async function (msg: Message) {
     writeStream.write(chunk);
   }
 
-  await execPromise(
-    `ffmpeg -y -i "${tempPath}" -c:v copy -c:a copy "${tempPath}.mp4"`,
-  );
+  await new Promise<void>((resolve, reject) => {
+    writeStream.end();
+    writeStream.on("finish", resolve);
+    writeStream.on("error", reject);
+  });
 
-  const audioBuffer = fs.readFileSync(tempPath + ".mp4");
+  const audioBuffer = fs.readFileSync(`${tempPath}`);
   const media = new MessageMedia(
     "audio/mpeg",
     audioBuffer.toString("base64"),
@@ -84,5 +88,5 @@ export default async function (msg: Message) {
     caption: `${video.title}`,
   });
 
-  Promise.all([fs.promises.unlink(tempPath), fs.promises.unlink(tempPath)]);
+  fs.promises.unlink(tempPath);
 }

src/components/events/message.ts

@@ -257,8 +257,8 @@ export default async function (msg: Message, type: string) {
         const text = `
         \`${errors[Math.floor(Math.random() * errors.length)]}\`\`
 
-          We encountered an error while processing ${key}.
-          Provider returned an error ${statusMessages[status]}.
+        We encountered an error while processing ${key}.
+        Provider returned an error ${statusMessages[status]}.
         `;
         await msg.reply(text);
         return;
@@ -268,7 +268,7 @@ export default async function (msg: Message, type: string) {
     const text = `
     \`${errors[Math.floor(Math.random() * errors.length)]}\`
 
-      We encountered an error while processing ${key}.
+    We encountered an error while processing ${key}.
     `;
     await msg.reply(text);
   }