Skip to content

Commit 9f40662

Browse files
author
Dan Cherniavsky
committed
fabtests/pytest/efa: Only check server tx_bytes in device selection non dgram test
The test is asserting that both server and client tx_bytes counters progressed after running fi_dgram_pingpong. Since UD is unreliable, if the first ping is dropped, no pong is received and the server counters won't progress, causing spurious failures. Only check server tx_bytes for non dgram iterations, since the client initiates the ping and its tx counter must progress if the EFA dgram endpoint was picked up. For rdm iterations, both counters are still verified since the transport is reliable. Change-Id: I2755ea712041f35e464e8977cb9343052cbaf589 Signed-off-by: Dan Cherniavsky <dchern@amazon.com>
1 parent f13d09d commit 9f40662

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

fabtests/pytest/efa/test_efa_device_selection.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,9 +64,13 @@ def test_efa_device_selection(cmdline_args, fabric, selection_approach):
6464
client_tx_bytes_after_test = efa_retrieve_hw_counter_value(cmdline_args.client_id, "tx_bytes", client_device_name)
6565

6666
# Verify EFA traffic
67-
assert server_tx_bytes_before_test < server_tx_bytes_after_test
6867
assert client_tx_bytes_before_test < client_tx_bytes_after_test
6968

69+
# For dgram (UD), skip server check — if the first packet is
70+
# dropped, server counters won't progress.
71+
if strict_fabtests_mode:
72+
assert server_tx_bytes_before_test < server_tx_bytes_after_test
73+
7074
# Verify that fi_getinfo does not return any info objects when FI_EFA_IFACE is set to an invalid value
7175
@pytest.mark.functional
7276
def test_efa_device_selection_negative(cmdline_args, fabric):

0 commit comments

Comments
 (0)