fix bad continue

romainmenke · romainmenke · commit 164c5f093666 · 2019-12-18T11:10:52.000+01:00
diff --git a/composer.json b/composer.json
@@ -31,5 +31,13 @@
 		"post-update-cmd": [
 			"\"vendor/bin/phpcs\" --config-set installed_paths vendor/wp-coding-standards/wpcs"
 		]
+	},
+	"archive": {
+		"exclude": [
+			".git",
+			".github",
+			"tests",
+			"composer.lock"
+		]
 	}
 }
diff --git a/inc/class-s3-uploads.php b/inc/class-s3-uploads.php
@@ -138,7 +138,7 @@ public function delete_attachment_files( $post_id ) {
 
 		$file = \apply_filters( 's3_delete_attachment_file', $file );
 		if ( empty( $file ) ) {
-			continue;
+			return;
 		}
 
 		if ( $deleted[ $file ] ?? false ) {

Original file line number	Diff line number	Diff line change
`@@ -31,5 +31,13 @@`
`31`	`31`	`"post-update-cmd": [`
`32`	`32`	`"\"vendor/bin/phpcs\" --config-set installed_paths vendor/wp-coding-standards/wpcs"`
`33`	`33`	`]`
	`34`	`+ },`
	`35`	`+ "archive": {`
	`36`	`+ "exclude": [`
	`37`	`+ ".git",`
	`38`	`+ ".github",`
	`39`	`+ "tests",`
	`40`	`+ "composer.lock"`
	`41`	`+ ]`
`34`	`42`	`}`
`35`	`43`	`}`
Original file line number	Diff line number	Diff line change
`@@ -138,7 +138,7 @@ public function delete_attachment_files( $post_id ) {`
`138`	`138`
`139`	`139`	`$file = \apply_filters( 's3_delete_attachment_file', $file );`
`140`	`140`	`if ( empty( $file ) ) {`
`141`		`- continue;`
	`141`	`+ return;`
`142`	`142`	`}`
`143`	`143`
`144`	`144`	`if ( $deleted[ $file ] ?? false ) {`