Skip to content

Commit 21dfd13

Browse files
committed
Resolve inconsistencies in test files
1 parent 37eb17e commit 21dfd13

2 files changed

Lines changed: 5 additions & 9 deletions

File tree

src/test/java/seedu/address/logic/parser/AddCommandParserTest.java

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -46,29 +46,25 @@ public void parse_allFieldsPresent_success() {
4646

4747
// whitespace only preamble
4848
assertParseSuccess(parser, PREAMBLE_WHITESPACE + NAME_DESC_BOB + PHONE_DESC_BOB + EMAIL_DESC_BOB
49-
+ ADDRESS_DESC_BOB + TAG_DESC_FRIEND, new AddCommand(expectedTask));
49+
+ TAG_DESC_FRIEND, new AddCommand(expectedTask));
5050

5151
// multiple names - last name accepted
5252
assertParseSuccess(parser, NAME_DESC_AMY + NAME_DESC_BOB + PHONE_DESC_BOB + EMAIL_DESC_BOB
53-
+ ADDRESS_DESC_BOB + TAG_DESC_FRIEND, new AddCommand(expectedTask));
53+
+ TAG_DESC_FRIEND, new AddCommand(expectedTask));
5454

5555
// multiple phones - last phone accepted
5656
assertParseSuccess(parser, NAME_DESC_BOB + PHONE_DESC_AMY + PHONE_DESC_BOB + EMAIL_DESC_BOB
57-
+ ADDRESS_DESC_BOB + TAG_DESC_FRIEND, new AddCommand(expectedTask));
57+
+ TAG_DESC_FRIEND, new AddCommand(expectedTask));
5858

5959
// multiple emails - last email accepted
6060
assertParseSuccess(parser, NAME_DESC_BOB + PHONE_DESC_BOB + EMAIL_DESC_AMY + EMAIL_DESC_BOB
61-
+ ADDRESS_DESC_BOB + TAG_DESC_FRIEND, new AddCommand(expectedTask));
62-
63-
// multiple addresses - last address accepted
64-
assertParseSuccess(parser, NAME_DESC_BOB + PHONE_DESC_BOB + EMAIL_DESC_BOB
6561
+ TAG_DESC_FRIEND, new AddCommand(expectedTask));
6662

6763
// multiple tags - all accepted
6864
Task expectedTaskMultipleTags = new PersonBuilder(BOB).withTags(VALID_TAG_FRIEND, VALID_TAG_HUSBAND)
6965
.build();
7066

71-
assertParseSuccess(parser, NAME_DESC_BOB + PHONE_DESC_BOB + EMAIL_DESC_BOB + ADDRESS_DESC_BOB
67+
assertParseSuccess(parser, NAME_DESC_BOB + PHONE_DESC_BOB + EMAIL_DESC_BOB
7268
+ TAG_DESC_HUSBAND + TAG_DESC_FRIEND, new AddCommand(expectedTaskMultipleTags));
7369
}
7470

src/test/java/seedu/address/testutil/TypicalPersons.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
public class TypicalPersons {
2323

2424
public static final Task ALICE = new PersonBuilder().withName("Alice Pauline")
25-
.withPhone("94351253")
25+
.withPhone("94351253").withEmail("alice@example.com")
2626
.withTags("friends").build();
2727
public static final Task BENSON = new PersonBuilder().withName("Benson Meier")
2828
.withEmail("johnd@example.com").withPhone("98765432")

0 commit comments

Comments
 (0)