test(git): update Clone method mock to accept additional argument

Modified all instances of the Clone method mock to include an additional argument, ensuring compatibility with recent changes in the Git operations. This update enhances the test coverage and maintains alignment with the updated method signature across various test files.

Author: mrz1836

internal/config/defaults.go

@@ -1,6 +1,11 @@
 // Package config provides configuration defaults and helpers for go-broadcast.
 package config
 
+// DefaultBlobSizeLimit is the default maximum blob size for partial clone.
+// Blobs larger than this are excluded during git clone operations.
+// Use "0" to disable filtering and clone all blobs.
+const DefaultBlobSizeLimit = "10m"
+
 // DefaultExclusions returns smart default exclusions for development artifacts
 func DefaultExclusions() []string {
 	return []string{

internal/config/parser.go

@@ -70,6 +70,11 @@ func applyDefaults(config *Config) {
 			group.Source.Branch = "main"
 		}
 
+		// Set default blob size limit for source
+		if group.Source.BlobSizeLimit == "" {
+			group.Source.BlobSizeLimit = DefaultBlobSizeLimit
+		}
+
 		// Set default branch prefix if not specified
 		if group.Defaults.BranchPrefix == "" {
 			group.Defaults.BranchPrefix = "chore/sync-files"
@@ -87,6 +92,11 @@ func applyDefaults(config *Config) {
 
 		// Apply directory defaults to group targets
 		for j := range group.Targets {
+			// Set default blob size limit for targets (inherits from source if not set)
+			if group.Targets[j].BlobSizeLimit == "" {
+				group.Targets[j].BlobSizeLimit = group.Source.BlobSizeLimit
+			}
+
 			for k := range group.Targets[j].Directories {
 				ApplyDirectoryDefaults(&group.Targets[j].Directories[k])
 			}

internal/config/types.go

@@ -12,10 +12,11 @@ type Config struct {
 
 // SourceConfig defines the source repository settings
 type SourceConfig struct {
-	Repo          string `yaml:"repo"`                     // Format: org/repo
-	Branch        string `yaml:"branch"`                   // Default: master
-	SecurityEmail string `yaml:"security_email,omitempty"` // Security contact email address (for transformation)
-	SupportEmail  string `yaml:"support_email,omitempty"`  // Support/contact email address (for transformation)
+	Repo          string `yaml:"repo"`                      // Format: org/repo
+	Branch        string `yaml:"branch"`                    // Default: master
+	BlobSizeLimit string `yaml:"blob_size_limit,omitempty"` // Max blob size for partial clone (e.g., "10m"), "0" to disable
+	SecurityEmail string `yaml:"security_email,omitempty"`  // Security contact email address (for transformation)
+	SupportEmail  string `yaml:"support_email,omitempty"`   // Support/contact email address (for transformation)
 }
 
 // GlobalConfig contains global settings applied across all targets
@@ -40,6 +41,7 @@ type DefaultConfig struct {
 type TargetConfig struct {
 	Repo              string             `yaml:"repo"`                          // Format: org/repo
 	Branch            string             `yaml:"branch,omitempty"`              // Target branch for PR base (defaults to repo's default branch)
+	BlobSizeLimit     string             `yaml:"blob_size_limit,omitempty"`     // Override source blob size limit for partial clone
 	Files             []FileMapping      `yaml:"files,omitempty"`               // Files to sync
 	Directories       []DirectoryMapping `yaml:"directories,omitempty"`         // Directories to sync
 	FileListRefs      []string           `yaml:"file_list_refs,omitempty"`      // References to file lists by ID

internal/git/client.go

@@ -12,14 +12,25 @@ type RepositoryInfo struct {
 	IsGitHub bool   // Whether this is a GitHub repository
 }
 
+// CloneOptions configures git clone behavior
+type CloneOptions struct {
+	// BlobSizeLimit sets the maximum blob size for partial clone.
+	// Uses git's --filter=blob:limit=<size> option.
+	// Examples: "10m" (10 megabytes), "1g" (1 gigabyte)
+	// Use "0" or empty string to disable filtering (clone all blobs).
+	BlobSizeLimit string
+}
+
 // Client defines the interface for Git operations
 type Client interface {
-	// Clone clones a repository to the specified path
-	Clone(ctx context.Context, url, path string) error
-
-	// CloneWithBranch clones a repository to the specified path with a specific branch
-	// If branch is empty, behaves like Clone
-	CloneWithBranch(ctx context.Context, url, path, branch string) error
+	// Clone clones a repository to the specified path.
+	// opts can be nil to use default behavior.
+	Clone(ctx context.Context, url, path string, opts *CloneOptions) error
+
+	// CloneWithBranch clones a repository to the specified path with a specific branch.
+	// If branch is empty, behaves like Clone.
+	// opts can be nil to use default behavior.
+	CloneWithBranch(ctx context.Context, url, path, branch string, opts *CloneOptions) error
 
 	// Checkout switches to the specified branch
 	Checkout(ctx context.Context, repoPath, branch string) error

internal/git/git_integration_test.go

@@ -26,7 +26,7 @@ func TestGitClient_FullWorkflow_Integration(t *testing.T) {
 
 	// Clone a real repository
 	t.Run("Clone", func(t *testing.T) {
-		err := client.Clone(ctx, "https://github.com/octocat/Hello-World.git", repoPath)
+		err := client.Clone(ctx, "https://github.com/octocat/Hello-World.git", repoPath, nil)
 		require.NoError(t, err)
 		assert.DirExists(t, filepath.Join(repoPath, ".git"))
 

internal/git/git_retry_test.go

@@ -155,7 +155,7 @@ func TestGitClient_CloneWithRetry(t *testing.T) {
 		require.NoError(t, cmd.Run())
 
 		// Clone should succeed on first attempt
-		err = client.Clone(ctx, sourceRepo, repoPath)
+		err = client.Clone(ctx, sourceRepo, repoPath, nil)
 		require.NoError(t, err)
 
 		// Verify the repository was cloned
@@ -173,7 +173,7 @@ func TestGitClient_CloneWithRetry(t *testing.T) {
 		// Create the directory first
 		require.NoError(t, os.MkdirAll(repoPath, 0o750))
 
-		err = client.Clone(ctx, "https://example.com/repo.git", repoPath)
+		err = client.Clone(ctx, "https://example.com/repo.git", repoPath, nil)
 		require.Error(t, err)
 		assert.Contains(t, err.Error(), "repository already exists")
 	})
@@ -190,7 +190,7 @@ func TestGitClient_CloneWithRetry(t *testing.T) {
 		defer cancel()
 
 		// Use a URL that will trigger network errors
-		err = client.Clone(cancelCtx, "https://invalid-url-that-causes-timeout.invalid/repo.git", repoPath)
+		err = client.Clone(cancelCtx, "https://invalid-url-that-causes-timeout.invalid/repo.git", repoPath, nil)
 		require.Error(t, err)
 		// Should get either context canceled or network error
 		assert.True(t, errors.Is(err, context.DeadlineExceeded) || strings.Contains(err.Error(), "clone repository"))

internal/git/git_test.go

@@ -543,7 +543,7 @@ func TestGitClient_Clone(t *testing.T) {
 	repoPath := filepath.Join(tmpDir, "test-repo")
 
 	// Clone a small public repository
-	err = client.Clone(ctx, "https://github.com/octocat/Hello-World.git", repoPath)
+	err = client.Clone(ctx, "https://github.com/octocat/Hello-World.git", repoPath, nil)
 	require.NoError(t, err)
 
 	// Verify the repository was cloned
@@ -568,7 +568,7 @@ func TestGitClient_Clone_AlreadyExists(t *testing.T) {
 	require.NoError(t, err)
 
 	// Try to clone into existing directory
-	err = client.Clone(ctx, "https://github.com/octocat/Hello-World.git", repoPath)
+	err = client.Clone(ctx, "https://github.com/octocat/Hello-World.git", repoPath, nil)
 	require.Error(t, err)
 	assert.ErrorIs(t, err, ErrRepositoryExists)
 }
@@ -606,7 +606,7 @@ func TestGitClient_CloneWithBranch(t *testing.T) {
 			repoPath := filepath.Join(tmpDir, "test-repo-"+tt.name)
 
 			// Clone with specific branch
-			err = client.CloneWithBranch(ctx, "https://github.com/octocat/Hello-World.git", repoPath, tt.branch)
+			err = client.CloneWithBranch(ctx, "https://github.com/octocat/Hello-World.git", repoPath, tt.branch, nil)
 			require.NoError(t, err)
 
 			// Verify the repository was cloned
@@ -640,7 +640,7 @@ func TestGitClient_CloneWithBranch_AlreadyExists(t *testing.T) {
 	require.NoError(t, err)
 
 	// Try to clone with branch into existing directory
-	err = client.CloneWithBranch(ctx, "https://github.com/octocat/Hello-World.git", repoPath, "master")
+	err = client.CloneWithBranch(ctx, "https://github.com/octocat/Hello-World.git", repoPath, "master", nil)
 	require.Error(t, err)
 	assert.ErrorIs(t, err, ErrRepositoryExists)
 }
@@ -658,7 +658,7 @@ func TestGitClient_CloneWithBranch_InvalidBranch(t *testing.T) {
 	repoPath := filepath.Join(tmpDir, "test-repo")
 
 	// Try to clone with non-existent branch
-	err = client.CloneWithBranch(ctx, "https://github.com/octocat/Hello-World.git", repoPath, "non-existent-branch")
+	err = client.CloneWithBranch(ctx, "https://github.com/octocat/Hello-World.git", repoPath, "non-existent-branch", nil)
 	require.Error(t, err)
 	assert.Contains(t, err.Error(), "clone repository with branch non-existent-branch")
 }
@@ -747,7 +747,7 @@ func TestGitClient_GetRemoteURL(t *testing.T) {
 	repoPath := filepath.Join(tmpDir, "test-repo")
 
 	// Clone a repository with a remote
-	err = client.Clone(ctx, "https://github.com/octocat/Hello-World.git", repoPath)
+	err = client.Clone(ctx, "https://github.com/octocat/Hello-World.git", repoPath, nil)
 	require.NoError(t, err)
 
 	// Get remote URL
@@ -892,7 +892,7 @@ func TestGitClient_CloneError(t *testing.T) {
 	ctx := context.Background()
 
 	// Test clone with invalid URL
-	err = client.Clone(ctx, "invalid://url", "/tmp/test-clone-error")
+	err = client.Clone(ctx, "invalid://url", "/tmp/test-clone-error", nil)
 	require.Error(t, err)
 	assert.Contains(t, err.Error(), "failed to clone repository")
 }

internal/git/mock.go

@@ -19,14 +19,14 @@ func NewMockClient() *MockClient {
 }
 
 // Clone mock implementation
-func (m *MockClient) Clone(ctx context.Context, url, path string) error {
-	args := m.Called(ctx, url, path)
+func (m *MockClient) Clone(ctx context.Context, url, path string, opts *CloneOptions) error {
+	args := m.Called(ctx, url, path, opts)
 	return testutil.ExtractError(args)
 }
 
 // CloneWithBranch mock implementation
-func (m *MockClient) CloneWithBranch(ctx context.Context, url, path, branch string) error {
-	args := m.Called(ctx, url, path, branch)
+func (m *MockClient) CloneWithBranch(ctx context.Context, url, path, branch string, opts *CloneOptions) error {
+	args := m.Called(ctx, url, path, branch, opts)
 	return testutil.ExtractError(args)
 }
 

internal/git/mock_test.go

@@ -29,37 +29,37 @@ func TestMockClientImplementation(t *testing.T) {
 	t.Run("Clone", func(t *testing.T) {
 		t.Run("success case", func(t *testing.T) {
 			mock := NewMockClient()
-			mock.On("Clone", ctx, "https://github.com/test/repo.git", "/tmp/repo").Return(nil)
+			mock.On("Clone", ctx, "https://github.com/test/repo.git", "/tmp/repo", (*CloneOptions)(nil)).Return(nil)
 
-			err := mock.Clone(ctx, "https://github.com/test/repo.git", "/tmp/repo")
+			err := mock.Clone(ctx, "https://github.com/test/repo.git", "/tmp/repo", nil)
 			require.NoError(t, err)
 			mock.AssertExpectations(t)
 		})
 
 		t.Run("error case", func(t *testing.T) {
 			mock := NewMockClient()
-			mock.On("Clone", ctx, "https://github.com/test/repo.git", "/tmp/repo").Return(errCloneFailed)
+			mock.On("Clone", ctx, "https://github.com/test/repo.git", "/tmp/repo", (*CloneOptions)(nil)).Return(errCloneFailed)
 
-			err := mock.Clone(ctx, "https://github.com/test/repo.git", "/tmp/repo")
+			err := mock.Clone(ctx, "https://github.com/test/repo.git", "/tmp/repo", nil)
 			require.Error(t, err)
 			require.Equal(t, errCloneFailed, err)
 			mock.AssertExpectations(t)
 		})
 
 		t.Run("improperly configured mock", func(t *testing.T) {
 			mock := NewMockClient()
-			mock.On("Clone", ctx, "url", "path").Return()
+			mock.On("Clone", ctx, "url", "path", (*CloneOptions)(nil)).Return()
 
-			err := mock.Clone(ctx, "url", "path")
+			err := mock.Clone(ctx, "url", "path", nil)
 			require.Error(t, err)
 			require.Contains(t, err.Error(), "mock not properly configured")
 		})
 
 		t.Run("mock returns non-error type", func(t *testing.T) {
 			mock := NewMockClient()
-			mock.On("Clone", ctx, "url", "path").Return("not an error")
+			mock.On("Clone", ctx, "url", "path", (*CloneOptions)(nil)).Return("not an error")
 
-			err := mock.Clone(ctx, "url", "path")
+			err := mock.Clone(ctx, "url", "path", nil)
 			require.Error(t, err)
 			require.Contains(t, err.Error(), "mock returned non-error type")
 		})
@@ -272,8 +272,8 @@ func TestMockClientDefensiveProgramming(t *testing.T) {
 		mock := NewMockClient()
 
 		// Test methods that return only error
-		mock.On("Clone", ctx, "url", "path").Return(nil).Once()
-		err := mock.Clone(ctx, "url", "path")
+		mock.On("Clone", ctx, "url", "path", (*CloneOptions)(nil)).Return(nil).Once()
+		err := mock.Clone(ctx, "url", "path", nil)
 		require.NoError(t, err)
 
 		mock.On("Checkout", ctx, "repo", "branch").Return(nil).Once()
@@ -322,7 +322,7 @@ func TestMockClientConcurrency(_ *testing.T) {
 	mock := NewMockClient()
 
 	// Set up expectations for concurrent calls
-	mock.On("Clone", ctx, "url", "path").Return(nil).Maybe()
+	mock.On("Clone", ctx, "url", "path", (*CloneOptions)(nil)).Return(nil).Maybe()
 	mock.On("Checkout", ctx, "repo", "branch").Return(nil).Maybe()
 	mock.On("CreateBranch", ctx, "repo", "branch").Return(nil).Maybe()
 	mock.On("Add", ctx, "repo", []string{"file"}).Return(nil).Maybe()
@@ -338,7 +338,7 @@ func TestMockClientConcurrency(_ *testing.T) {
 	// Launch goroutines for each method
 	go func() {
 		for i := 0; i < 10; i++ {
-			_ = mock.Clone(ctx, "url", "path")
+			_ = mock.Clone(ctx, "url", "path", nil)
 		}
 		done <- true
 	}()