fix(linters): disable revive var-naming rule globally

Disables the revive var-naming rule to prevent false positives for
internal packages (metrics, sync, version) that conflict with stdlib
package names. Path-based exclusion rules were not working reliably
due to golangci-lint issue #3717.

Also removes now-unused nolint directives from batch.go and
pool_test.go.

Author: mrz1836

.golangci.json

@@ -59,13 +59,6 @@
                     "gomoddirectives"
                 ],
                 "text": "replacement are not allowed: github.com/joho/godotenv"
-            },
-            {
-                "linters": [
-                    "revive"
-                ],
-                "text": "var-naming: avoid package names that conflict with Go standard library package names",
-                "path": "internal/(metrics|sync|version)/.*\\.go$"
             }
         ],
         "uniq-by-line": true
@@ -224,6 +217,14 @@
             },
             "unparam": {
                 "check-exported": false
+            },
+            "revive": {
+                "rules": [
+                    {
+                        "name": "var-naming",
+                        "disabled": true
+                    }
+                ]
             }
         }
     },

internal/sync/batch.go

@@ -105,7 +105,7 @@ func (bp *BatchProcessor) ProcessFiles(ctx context.Context, sourcePath string, j
 	if err := g.Wait(); err != nil {
 		// On error/cancellation, drain the result channel to prevent goroutine leaks
 		go func() {
-			for range resultChan { //nolint:revive // intentionally draining channel
+			for range resultChan {
 			}
 		}()
 		return nil, fmt.Errorf("batch processing failed: %w", err)
@@ -682,7 +682,7 @@ func (bp *BatchProcessor) ProcessFilesWithProgress(ctx context.Context, sourcePa
 	if err := g.Wait(); err != nil {
 		// On error/cancellation, drain the result channel to prevent goroutine leaks
 		go func() {
-			for range resultChan { //nolint:revive // intentionally draining channel
+			for range resultChan {
 			}
 		}()
 		return nil, fmt.Errorf("batch processing failed: %w", err)

internal/worker/pool_test.go

@@ -479,7 +479,7 @@ func TestPoolBatchSubmitPartialFailure(t *testing.T) {
 
 	// Consume any pending results before shutdown to avoid deadlock
 	go func() {
-		for range pool.Results() { //nolint:revive // intentionally draining channel
+		for range pool.Results() {
 		}
 	}()
 
@@ -808,7 +808,7 @@ func TestSubmitAfterShutdown(t *testing.T) {
 
 	// Drain results in background
 	go func() {
-		for range pool.Results() { //nolint:revive // Intentionally draining channel
+		for range pool.Results() {
 		}
 	}()
 
@@ -829,7 +829,7 @@ func TestDoubleShutdown(t *testing.T) {
 
 	// Drain results in background
 	go func() {
-		for range pool.Results() { //nolint:revive // Intentionally draining channel
+		for range pool.Results() {
 		}
 	}()
 
@@ -856,7 +856,7 @@ func TestNilTask(t *testing.T) {
 
 	// Drain results in background
 	go func() {
-		for range pool.Results() { //nolint:revive // Intentionally draining channel
+		for range pool.Results() {
 		}
 	}()