hw-mgmt: scripts: Cleanup and beautify *.py scripts

Cleanup and beautify *.py scripts

Signed-off-by: Oleksandr Shamray <oleksandrs@nvidia.com>

Author: sholeksandr

unittest/hw_mgmgt_sync/module_populate/run_all_tests.py

@@ -11,6 +11,7 @@
 import random
 import argparse
 
+
 def setup_import_path(hw_mgmt_path=None):
     """Setup import path for hw_management_sync module"""
     if hw_mgmt_path:
@@ -26,80 +27,83 @@ def setup_import_path(hw_mgmt_path=None):
             hw_mgmt_dir = './bin'
         else:
             raise FileNotFoundError("Cannot find hw_management_sync.py")
-    
+
     hw_mgmt_dir = os.path.abspath(hw_mgmt_dir)
     if hw_mgmt_dir not in sys.path:
         sys.path.insert(0, hw_mgmt_dir)
     return hw_mgmt_dir
 
+
 def test_basic_functionality():
     """Test basic function imports and constants"""
     print("🧪 Testing basic functionality...")
-    
+
     try:
         from hw_management_sync import CONST, sdk_temp2degree, module_temp_populate
-        
+
         # Test constants
         assert CONST.SDK_FW_CONTROL == 0, f"SDK_FW_CONTROL should be 0, got {CONST.SDK_FW_CONTROL}"
         assert CONST.SDK_SW_CONTROL == 1, f"SDK_SW_CONTROL should be 1, got {CONST.SDK_SW_CONTROL}"
         print("✅ Constants test PASSED")
-        
+
         # Test function existence
         assert callable(module_temp_populate), "module_temp_populate should be callable"
         assert callable(sdk_temp2degree), "sdk_temp2degree should be callable"
         print("✅ Function existence test PASSED")
-        
+
         return True
     except Exception as e:
         print(f"❌ Basic functionality test FAILED: {e}")
         return False
 
+
 def test_temperature_conversion():
     """Test sdk_temp2degree function with various inputs"""
     print("🧪 Testing temperature conversion...")
-    
+
     try:
         from hw_management_sync import sdk_temp2degree
-        
+
         test_cases = [
             (0, 0, "Zero temperature"),
             (25, 3125, "Normal positive temperature"),
-            (-10, 0xffff + (-10) + 1, "Normal negative temperature"), 
+            (-10, 0xffff + (-10) + 1, "Normal negative temperature"),
         ]
-        
+
         passed = 0
         total = len(test_cases)
-        
+
         for input_temp, expected, description in test_cases:
             result = sdk_temp2degree(input_temp)
             if result == expected:
                 print(f"  ✅ {description}: sdk_temp2degree({input_temp}) = {result}")
                 passed += 1
             else:
                 print(f"  ❌ {description}: sdk_temp2degree({input_temp}) = {result}, expected {expected}")
-        
+
         if passed == total:
             print(f"✅ Temperature conversion test PASSED ({passed}/{total})")
             return True
         else:
             print(f"❌ Temperature conversion test FAILED ({passed}/{total})")
             return False
-            
+
     except Exception as e:
         print(f"❌ Temperature conversion test FAILED: {e}")
         return False
 
+
 def test_random_module_states():
     """Test with randomized module states as requested"""
     print("🧪 Testing random module states (5 modules as requested)...")
-    
+
     try:
         from hw_management_sync import CONST
-        
+
         # Generate 5 random module states as requested
         random.seed(42)  # For reproducible results
         module_states = []
-        
+
         for i in range(5):
             state = {
                 'present': random.choice([0, 1]),
@@ -108,103 +112,106 @@ def test_random_module_states():
                 'threshold_hi': random.randint(60, 80)
             }
             module_states.append(state)
-            
+
             mode_str = "SDK_SW_CONTROL" if state['mode'] == CONST.SDK_SW_CONTROL else "SDK_FW_CONTROL"
             present_str = "Present" if state['present'] else "Not Present"
-            print(f"  Module {i+1}: {mode_str}, {present_str}, Temp={state['temperature']}")
-        
+            print(f"  Module {i + 1}: {mode_str}, {present_str}, Temp={state['temperature']}")
+
         # Test the logic expectations
         fw_control_count = sum(1 for state in module_states if state['mode'] == CONST.SDK_FW_CONTROL)
         sw_control_count = sum(1 for state in module_states if state['mode'] == CONST.SDK_SW_CONTROL)
         present_count = sum(1 for state in module_states if state['present'] == 1)
-        
+
         print(f"  📊 Summary: {fw_control_count} FW control, {sw_control_count} SW control, {present_count} present")
         print("✅ Random module states test PASSED")
         return True
-        
+
     except Exception as e:
         print(f"❌ Random module states test FAILED: {e}")
         return False
 
+
 def test_folder_agnostic_functionality(hw_mgmt_dir):
     """Test that the folder-agnostic import worked correctly"""
     print("🧪 Testing folder-agnostic functionality...")
-    
+
     try:
         import hw_management_sync
         module_file = hw_management_sync.__file__
         expected_dir = os.path.abspath(hw_mgmt_dir)
         actual_dir = os.path.dirname(os.path.abspath(module_file))
-        
+
         assert actual_dir == expected_dir, f"Module loaded from {actual_dir}, expected {expected_dir}"
-        
+
         print(f"  ✅ Module loaded from: {actual_dir}")
         print("✅ Folder-agnostic functionality test PASSED")
         return True
-        
+
     except Exception as e:
         print(f"❌ Folder-agnostic functionality test FAILED: {e}")
         return False
 
+
 def main():
     """Main test runner"""
     parser = argparse.ArgumentParser(description='Comprehensive test runner for module_temp_populate')
     parser.add_argument('--hw-mgmt-path', help='Path to hw_management_sync.py')
     args = parser.parse_args()
-    
+
     print("=" * 70)
     print("🚀 MODULE_TEMP_POPULATE TEST SUITE")
     print("=" * 70)
     print(f"Python version: {sys.version}")
-    
+
     try:
         # Setup import path
         hw_mgmt_dir = setup_import_path(args.hw_mgmt_path)
         print(f"📂 Using hw_management_sync.py from: {hw_mgmt_dir}")
         print("=" * 70)
-        
+
         # Run all tests
         tests = [
             ("Basic Functionality", test_basic_functionality),
-            ("Temperature Conversion", test_temperature_conversion), 
+            ("Temperature Conversion", test_temperature_conversion),
             ("Random Module States (5 modules)", test_random_module_states),
             ("Folder-Agnostic Functionality", lambda: test_folder_agnostic_functionality(hw_mgmt_dir)),
         ]
-        
+
         passed = 0
         total = len(tests)
-        
+
         for test_name, test_func in tests:
             print(f"\n🔬 Running: {test_name}")
             print("-" * 40)
             if test_func():
                 passed += 1
             print()
-        
+
         # Final results
         print("=" * 70)
         print("📋 FINAL TEST RESULTS")
         print("=" * 70)
-        
+
         for i, (test_name, _) in enumerate(tests):
             status = "✅ PASSED" if i < passed else "❌ FAILED"
             print(f"  {status} - {test_name}")
-        
+
         print(f"\n🏆 Tests Passed: {passed}/{total}")
-        
+
         if passed == total:
             print("🎉 ALL TESTS PASSED!")
             print("✅ The module_temp_populate test suite is working correctly!")
             print("✅ Folder-agnostic functionality confirmed!")
             print("✅ 5 modules with random parameters tested!")
         else:
             print("⚠️  Some tests failed. Please check the output above.")
-            
+
         return 0 if passed == total else 1
-        
+
     except Exception as e:
         print(f"❌ Critical error: {e}")
         return 1
 
+
 if __name__ == '__main__':
-    exit(main()) 
+    exit(main())

unittest/hw_mgmgt_sync/module_populate/simple_test.py

@@ -5,6 +5,7 @@
 import os
 import argparse
 
+
 def setup_import_path(hw_mgmt_path=None):
     """Setup import path for hw_management_sync module"""
     if hw_mgmt_path:
@@ -20,12 +21,13 @@ def setup_import_path(hw_mgmt_path=None):
             hw_mgmt_dir = './bin'
         else:
             raise FileNotFoundError("Cannot find hw_management_sync.py")
-    
+
     hw_mgmt_dir = os.path.abspath(hw_mgmt_dir)
     if hw_mgmt_dir not in sys.path:
         sys.path.insert(0, hw_mgmt_dir)
     return hw_mgmt_dir
 
+
 def main():
     parser = argparse.ArgumentParser(description='Simple test for folder-agnostic functionality')
     parser.add_argument('--hw-mgmt-path', help='Path to hw_management_sync.py')
@@ -34,36 +36,37 @@ def main():
     try:
         hw_mgmt_dir = setup_import_path(args.hw_mgmt_path)
         print(f"Found hw_management_sync.py in: {hw_mgmt_dir}")
-        
+
         from hw_management_sync import CONST, sdk_temp2degree, module_temp_populate
         print("✅ Import successful!")
         print(f"✅ CONST.SDK_FW_CONTROL = {CONST.SDK_FW_CONTROL}")
         print(f"✅ CONST.SDK_SW_CONTROL = {CONST.SDK_SW_CONTROL}")
         print(f"✅ sdk_temp2degree(25) = {sdk_temp2degree(25)}")
         print(f"✅ sdk_temp2degree(-10) = {sdk_temp2degree(-10)}")
-        
+
         # Test temperature conversion formula
         assert sdk_temp2degree(25) == 25 * 125, "Positive temperature conversion failed"
         assert sdk_temp2degree(-10) == 0xffff + (-10) + 1, "Negative temperature conversion failed"
         print("✅ Temperature conversion tests PASSED")
-        
+
         # Test constants
         assert CONST.SDK_FW_CONTROL == 0, "SDK_FW_CONTROL should be 0"
         assert CONST.SDK_SW_CONTROL == 1, "SDK_SW_CONTROL should be 1"
         print("✅ Constants tests PASSED")
-        
+
         # Test function exists
         assert callable(module_temp_populate), "module_temp_populate should be callable"
         print("✅ Function existence tests PASSED")
-        
+
         print("✅ ALL TESTS PASSED!")
         print(f"✅ Successfully tested folder-agnostic import from: {hw_mgmt_dir}")
-        
+
     except Exception as e:
         print(f"❌ Error: {e}")
         return 1
-    
+
     return 0
 
+
 if __name__ == '__main__':
-    exit(main()) 
+    exit(main())