fix: no-conditional-in-test does not trigger for conditionals in test metadata (fixes #363)

Author: mskelton

src/rules/no-conditional-in-test.test.ts

@@ -311,5 +311,9 @@ runRuleTester('no-conditional-in-test', rule, {
         },
       },
     },
+    // Issue 363: conditionals in test metadata should not trigger the rule
+    `test('My Test', { tag: productType === 'XYZ' ? '@regression' : '@smoke' }, () => {
+      expect(1).toBe(1);
+    })`,
   ],
 })

src/rules/no-conditional-in-test.ts

@@ -10,7 +10,34 @@ export default createRule({
       if (!call) return
 
       if (isTypeOfFnCall(context, call, ['test', 'step'])) {
-        context.report({ messageId: 'conditionalInTest', node })
+        // Check if the conditional is inside the test body (the function passed as the last argument)
+        const testFunction = call.arguments[call.arguments.length - 1]
+
+        // If the last argument is not a function, this is not a valid test call
+        if (
+          !testFunction ||
+          (testFunction.type !== 'FunctionExpression' &&
+            testFunction.type !== 'ArrowFunctionExpression')
+        ) {
+          return
+        }
+
+        // Check if the conditional node is inside the test function body
+        let currentNode: Rule.Node | null = node
+        let isInTestBody = false
+
+        while (currentNode && currentNode !== testFunction) {
+          if (currentNode === testFunction.body) {
+            isInTestBody = true
+            break
+          }
+          currentNode = currentNode.parent
+        }
+
+        // Only report if the conditional is inside the test body
+        if (isInTestBody) {
+          context.report({ messageId: 'conditionalInTest', node })
+        }
       }
     }