fix: Attach error to first unsorted node

Author: mskelton

src/rules/destructuring-properties.ts

@@ -12,6 +12,8 @@ import {
 
 export default {
   create(context) {
+    const source = context.getSourceCode()
+
     return {
       ObjectPattern(pattern) {
         const nodes = filterNodes(pattern.properties, ["Property"])
@@ -25,11 +27,10 @@ export default {
           .slice()
           .sort(alphaSorter((node) => getName(node.key).toLowerCase()))
 
-        if (isUnsorted(nodes, sorted)) {
-          const source = context.getSourceCode()
-
+        const firstUnsortedNode = isUnsorted(nodes, sorted)
+        if (firstUnsortedNode) {
           context.report({
-            node: nodes[0],
+            node: firstUnsortedNode,
             messageId: "unsorted",
             *fix(fixer) {
               for (const [node, complement] of enumerate(nodes, sorted)) {

src/rules/export-members.ts

@@ -23,9 +23,10 @@ export default {
           .slice()
           .sort(alphaSorter((node) => node.local.name.toLowerCase()))
 
-        if (isUnsorted(nodes, sorted)) {
+        const firstUnsortedNode = isUnsorted(nodes, sorted)
+        if (firstUnsortedNode) {
           context.report({
-            node: nodes[0],
+            node: firstUnsortedNode,
             messageId: "unsorted",
             *fix(fixer) {
               for (const [node, complement] of enumerate(nodes, sorted)) {

src/rules/exports.ts

@@ -51,9 +51,10 @@ export default {
             getSortValue(a).localeCompare(getSortValue(b))
         )
 
-        if (isUnsorted(nodes, sorted)) {
+        const firstUnsortedNode = isUnsorted(nodes, sorted)
+        if (firstUnsortedNode) {
           context.report({
-            node: nodes[0],
+            node: firstUnsortedNode,
             messageId: "unsorted",
             *fix(fixer) {
               for (const [node, complement] of enumerate(nodes, sorted)) {

src/rules/import-members.ts

@@ -11,6 +11,8 @@ import {
 
 export default {
   create(context) {
+    const source = context.getSourceCode()
+
     return {
       ImportDeclaration(decl) {
         const nodes = filterNodes(decl.specifiers, ["ImportSpecifier"])
@@ -24,11 +26,10 @@ export default {
           .slice()
           .sort(alphaSorter((node) => node.imported.name.toLowerCase()))
 
-        if (isUnsorted(nodes, sorted)) {
-          const source = context.getSourceCode()
-
+        const firstUnsortedNode = isUnsorted(nodes, sorted)
+        if (firstUnsortedNode) {
           context.report({
-            node: nodes[0],
+            node: firstUnsortedNode,
             messageId: "unsorted",
             *fix(fixer) {
               for (const [node, complement] of enumerate(nodes, sorted)) {

src/rules/imports.ts

@@ -72,14 +72,15 @@ export default {
             getSortValue(a).localeCompare(getSortValue(b))
         )
 
-        if (isUnsorted(nodes, sorted)) {
+        const firstUnsortedNode = isUnsorted(nodes, sorted)
+        if (firstUnsortedNode) {
           // When sorting, the comments for the first node are not copied as
           // we cannot determine if they are comments for the entire file or
           // just the first import.
           const isFirst = (node: ImportDeclaration) => node === nodes[0]
 
           context.report({
-            node: nodes[0],
+            node: firstUnsortedNode,
             messageId: "unsorted",
             *fix(fixer) {
               for (const [node, complement] of enumerate(nodes, sorted)) {

src/rules/object-properties.ts

@@ -33,18 +33,19 @@ function groupNodes(properties: (Property | SpreadElement)[]) {
 
 export default {
   create(context) {
+    const source = context.getSourceCode()
+
     return {
       ObjectExpression(expression) {
         for (const nodes of groupNodes(expression.properties)) {
           const sorted = nodes
             .slice()
             .sort(alphaSorter((node) => getName(node.key).toLowerCase()))
 
-          if (isUnsorted(nodes, sorted)) {
-            const source = context.getSourceCode()
-
+          const firstUnsortedNode = isUnsorted(nodes, sorted)
+          if (firstUnsortedNode) {
             context.report({
-              node: nodes[0],
+              node: firstUnsortedNode,
               messageId: "unsorted",
               *fix(fixer) {
                 for (const [node, complement] of enumerate(nodes, sorted)) {

src/rules/type-properties.ts

@@ -61,9 +61,10 @@ export default ESLintUtils.RuleCreator.withoutDocs({
           getSortValue(a).localeCompare(getSortValue(b))
       )
 
-      if (isUnsorted(nodes, sorted)) {
+      const firstUnsortedNode = isUnsorted(nodes, sorted)
+      if (firstUnsortedNode) {
         context.report({
-          node: nodes[0],
+          node: firstUnsortedNode,
           messageId: "unsorted",
           *fix(fixer) {
             for (const [node, complement] of enumerate(nodes, sorted)) {

src/utils.ts

@@ -2,11 +2,11 @@ import { AST, SourceCode } from "eslint"
 import { Expression, Node } from "estree"
 
 /**
- * Returns true if any node in the source array is different from the same
+ * Returns the first node in the source array that is different from the same
  * positioned node in the sorted array.
  */
 export function isUnsorted<T>(nodes: T[], sorted: T[]) {
-  return nodes.some((node, i) => node !== sorted[i])
+  return nodes.find((node, i) => node !== sorted[i])
 }
 
 /**