Skip to content

Commit 807e937

Browse files
kext: sysfs_node: fix memory leak in sysfsnode_find()
If vnode_getwithvid fails, new_sfsnode is overwritten with NULL without freeing the memory previously allocated via OSMalloc. Free new_sfsnode using OSFree(new_sfsnode, sizeof(sfsnode_t), sysfs_osmalloc_tag); before setting it to NULL.
1 parent dba3937 commit 807e937

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

kext/sysfs_node.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -242,6 +242,7 @@ sysfsnode_find(sfsmount_t *smp, sfsid_t node_id, sfssnode_t *snode,
242242
*/
243243
lck_mtx_lock(sfsnode_hash_mutex);
244244
target_sfsnode = NULL;
245+
OSFree(new_sfsnode, sizeof(sfsnode_t), sysfs_osmalloc_tag);
245246
new_sfsnode = NULL;
246247
locked = TRUE;
247248
continue;

0 commit comments

Comments
 (0)